go variable is initialised only after the switch case so it cannot be
dereferenced prior to that happening.
Signed-off-by: Michal Nazarewicz
---
drivers/staging/media/go7007/go7007-usb.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
On Sun, Nov 10 2013, Dan Carpenter wrote:
> Th
If none of the if conditions take a true path, the ret variable will
never be assigned a value.
Signed-off-by: Michal Nazarewicz
---
drivers/staging/comedi/drivers/vmk80xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Sun, Nov 10 2013, Dan Carpenter wrote:
> Don't use a From: unles
On Mon, Nov 11, 2013 at 12:46:24PM +0100, Michal Nazarewicz wrote:
> go variable is initialised only after the switch case so it cannot be
> dereferenced prior to that happening.
>
> Signed-off-by: Michal Nazarewicz
Looks good. Thanks. :)
regards,
dan carpenter
__
Hi All,
With v3.12-2839-gedae583 (Linus' tree as of this morning), the
ipuv3-crtc.ko module fails to link with the following messages:
ERROR: "ipu_plane_disable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
ERROR: "ipu_plane_enable" [drivers/staging/imx-drm/ipuv3-crtc.ko] undefined!
ERROR:
On Mon, Nov 04, 2013 at 01:32:20PM +0100, Ondrej Zary wrote:
>
> Shouldn't this be removed from the code, converted to a binary file and
> loaded
> by the kernel firmware loader instead?
Yes it should, please send patches to do so.
And don't quote the whole firmware blob when responding to pat
On Tue, Nov 05, 2013 at 01:53:28AM +1300, Simon Crequer wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Simon Crequer
> ---
> drivers/staging/dgnc/dgnc_cls.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Someone else beat you to this change, sorry, it no longer applies to
On Sun, Nov 10, 2013 at 03:44:20PM +0200, Aldo Iljazi wrote:
> Fixed the following coding style issues:
Note that I added the filename to the Subject:, please do so in the
future to make it easier to see what exactly you are changing.
>
> Lines 84-91,99-106,275,514: Replaced spaces at the start
On Sun, Nov 10, 2013 at 04:13:05PM +0100, Joachim Adolf Schuetz wrote:
> Fixed some coding style issues - a few braces and indentions.
>
> Signed-off-by: Joachim Adolf Schuetz
> ---
> drivers/staging/cxt1e1/comet.c | 31 +--
> 1 files changed, 13 insertions(+), 18 d
On Fri, Nov 08, 2013 at 05:00:43PM +0800, micky_ch...@realsil.com.cn wrote:
> --- /dev/null
> +++ b/drivers/staging/rts5208/TODO
> @@ -0,0 +1,5 @@
> +TODO:
> +- use kernel coding style
> +- checkpatch.pl fixes
> +- We will use the stack in drivers/mmc to implement
> + rts5208/5288 in the future
I
On Mon, Nov 04, 2013 at 02:15:22PM +0200, Aldo Iljazi wrote:
> Fixed the following styling issues:
>
> Line 30:
> Removed space before open square bracket '['
>
> Lines 31 to 155:
> Moved the commas that were in the start of the lines, to the end of the lines.
> Inserted spaces after the commas.
On Fri, Nov 01, 2013 at 06:01:56PM +0530, Conrad Gomes wrote:
> This is a patch which fixes coding style issues in unioxx5.c found
> by checkpatch.pl
>
> 1) Replaced printk with pr_info and pr_err
Drivers should never call printk() as they all have access to a struct
device somewhere. So please
Greg KH wrote:
> On Sun, Nov 10, 2013 at 03:44:20PM +0200, Aldo Iljazi wrote:
> > Fixed the following coding style issues:
>
> Note that I added the filename to the Subject:, please do so in the
> future to make it easier to see what exactly you are changing.
You are right. I'll do that.
--
Al
12 matches
Mail list logo
