Re: [PATCH] Staging: ft1000: fixed coding style issues

2013-11-03 Thread Aldo Iljazi
Dan Carpenter wrote: > On Sat, Nov 02, 2013 at 11:18:20PM +0200, Aldo Iljazi wrote: > > Aldo Iljazi wrote: > > > > > Fixed a few coding style issues that checkpatch reported. > > > > > > Specifically: > > > > > > 1. line over 80 characters issue on the lines 9 and 10. > > > 2. space prohibite

[PATCH] Staging: ft1000: fixed a few styling issues

2013-11-03 Thread Aldo Iljazi
Fixed a few styling issues, specifically: boot.h:30: ERROR: space prohibited before open square bracket '[' boot.h:31: ERROR: space required after that ',' (ctx:VxV) boot.h:31: ERROR: space required after that ',' (ctx:VxV) boot.h:31: ERROR: space required after that ',' (ctx:VxV) boot.h:31: ERROR

Re: [patch] Staging: sb105x: info leak in mp_get_count()

2013-11-03 Thread Josh Triplett
On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote: > The icount.reserved[] array isn't initialized so it leaks stack > information to userspace. > > Reported-by: Nico Golde > Reported-by: Fabian Yamaguchi > Signed-off-by: Dan Carpenter Reviewed-by: Josh Triplett Also, you don't q

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-03 Thread Dan Carpenter
On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > Fixed a few styling issues, specifically: > Gar... No one wants to read that changelog. That was over 700 lines of repeated text. regards, dan carpenter ___ devel mailing list de...@li

Re: [patch] Staging: sb105x: info leak in mp_get_count()

2013-11-03 Thread Dan Carpenter
On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote: > On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote: > > The icount.reserved[] array isn't initialized so it leaks stack > > information to userspace. > > > > Reported-by: Nico Golde > > Reported-by: Fabian Yamaguchi > >

Re: [PATCH 2/6] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices

2013-11-03 Thread Laurent Pinchart
Hi Hans, Thank you for the review. On Thursday 03 October 2013 08:54:19 Hans Verkuil wrote: > On 10/03/2013 01:55 AM, Laurent Pinchart wrote: > > From: Sergio Aguirre > > > > This adds a very simplistic driver to utilize the CSI2A interface inside > > the ISS subsystem in OMAP4, and dump the da

Re: [PATCH 1/6] v4l: omap4iss: Add support for OMAP4 camera interface - Core

2013-11-03 Thread Laurent Pinchart
Hi Sakari, Thank you for the review. On Sunday 06 October 2013 00:49:28 Sakari Ailus wrote: > Hi Laurent, > > Thanks for the patch! Some comments below. > > On Thu, Oct 03, 2013 at 01:55:28AM +0200, Laurent Pinchart wrote: > ... > > > +int omap4iss_get_external_info(struct iss_pipeline *pipe,

Re: [PATCH 2/6] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices

2013-11-03 Thread Laurent Pinchart
Hi Dan, Thank you for the comments. On Friday 04 October 2013 11:16:38 Dan Carpenter wrote: > On Thu, Oct 03, 2013 at 01:55:29AM +0200, Laurent Pinchart wrote: > > + > > + ret = vb2_streamon(&vfh->queue, type); > > + if (ret < 0) > > + goto err_iss_video_check_format; > > + > > +

Re: [patch] Staging: sb105x: info leak in mp_get_count()

2013-11-03 Thread Josh Triplett
On Mon, Nov 04, 2013 at 02:11:50AM +0300, Dan Carpenter wrote: > On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote: > > On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote: > > > The icount.reserved[] array isn't initialized so it leaks stack > > > information to userspace. >

Re: [patch] Staging: sb105x: info leak in mp_get_count()

2013-11-03 Thread Dan Carpenter
I've dropped most of the people from the CC list. On Sun, Nov 03, 2013 at 08:31:50PM -0800, Josh Triplett wrote: > On Mon, Nov 04, 2013 at 02:11:50AM +0300, Dan Carpenter wrote: > > On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote: > > > On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan C