From: Wei Yongjun
In case of error, the function platform_device_register_simple() returns
ERR_PTR() and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun
---
drivers/staging/imx-drm/imx-drm-core.c | 4 ++--
1 file changed,
On Tue, Oct 22, 2013 at 07:04:37PM +0530, Rashika Kheria wrote:
> As suggested by Jerome Marchand "The code in reset_store get the block device
> (bdget_disk()) but it does not put it (bdput()) when it's done using it.
> The usage count is therefor incremented but never decremented."
>
> Hence, th
Hello Rashika,
First of all, thanks for looking this!
On Tue, Oct 22, 2013 at 07:00:57PM +0530, Rashika Kheria wrote:
> This patch fixes the following Smatch warning in zram_drv.c-
> drivers/staging/zram/zram_drv.c:663
> reset_store() warn: variable dereferenced before check 'bdev' (see line 652)
Hey Rashika,
And please Cc LKML in next.
Thanks!
On Fri, Oct 25, 2013 at 7:13 PM, Minchan Kim wrote:
> On Tue, Oct 22, 2013 at 07:04:37PM +0530, Rashika Kheria wrote:
>> As suggested by Jerome Marchand "The code in reset_store get the block device
>> (bdget_disk()) but it does not put it (bdpu
On Sat, Oct 19, 2013 at 04:39:09PM +0200, Dominik Paulus wrote:
> +const char *usbip_net_strerror(int status)
> +{
> + static const char *const errs[] = {
> + /* ERR_OK */ "Success",
> + /* ERR_NA */ "Command failed",
> + /* ERR_MISMATCH */ "Protocol version
On Sat, Oct 19, 2013 at 04:39:13PM +0200, Dominik Paulus wrote:
> @@ -104,8 +105,10 @@ static int import_device(int sockfd, struct
> usbip_usb_device *udev)
> return -1;
> }
>
> - rc = usbip_vhci_attach_device(port, sockfd, udev->busnum,
> + usbip_net_bye(conn);
> +
On Sat, Oct 19, 2013 at 04:39:15PM +0200, Dominik Paulus wrote:
> @@ -367,10 +367,17 @@ int usbip_host_export_device(struct
> usbip_exported_device *edev,
> return -1;
> }
>
> - snprintf(sockfd_buff, sizeof(sockfd_buff), "%d\n", conf->sockfd);
> - dbg("write: %s", soc
Remove typedef keyword and rename the cfs_hash_bd_t struct to
cfs_hash_bd in libcfs_hash.h. These changes resolve the
"Do not add new typedefs" warning generated by checkpatch.pl
and meet kernel coding style.
Struct variables in other header and source files that depend
on libcfs_hash.h are update
Removed typedef keyword and rename the cfs_debug_limit_state_t
struct to cfs_debug_limit_state in libcfs_debug.h. These changes
resolve the "Do not add new typedefs" warning generated by
checkpatch.pl and meet kernel coding style.
Struct variables in other header and source files
that depend on li
Remove typedef keyword and rename the cfs_hash_bucket_t struct to
cfs_hash_bucket in libcfs_hash.h. These changes resolve the
"Do not add new typedefs" warning generated by checkpatch.pl and
meet kernel coding style.
The struct variables in hash.c are updated to reflect this change
as well.
Signe
Remove unnecessary parentheses from return statements in lib-lnet.h
to meet kernel coding style.
Signed-off-by: Lisa Nguyen
---
drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/include/lin
Reformat a pointer variable in lib-lnet.h to meet kernel
coding style and eliminate pointer format warning
generated by checkpatch.pl
Signed-off-by: Lisa Nguyen
---
drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/st
Remove spaces between function names and open parentheses to
meet kernel coding style and eliminate extra space warnings
generated by checkpatch.pl
Signed-off-by: Lisa Nguyen
---
.../staging/lustre/include/linux/lnet/lib-lnet.h | 78 +++---
1 file changed, 39 insertions(+), 39
This is for future reference, the current patch seems fine.
On Fri, Oct 25, 2013 at 01:20:56PM -0700, Lisa Nguyen wrote:
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_resource.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_resource.c
> @@ -159,7 +159,7 @@ static int lprocfs_ns_resources_seq_s
This patch replaces "PVOID" with "void *"
in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index 2074c18..c5891
This patch replace "USHORT" with "unsigned
short" in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
in
This patch replace "ULONG" with "unsigned
long" in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h | 42 -
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapt
This patch replaces "UINT32" with "u32"
in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index 27b5011..a34 100644
--- a/
This patch replaces "UINT" with "unsigned
int" in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h | 84 -
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapte
This patch removes a space before semicolon as
specified by checkpatch.pl.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index 1d8bf08..c2c0e6c 1
This patch replace "UCHAR" with "unsigned
char" in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h | 82 -
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapt
This patch removes typedef for _U_IP_ADDRESS, and
changes the name of the struct to bcm_ip_address. In
addition, any calls to struct "U_IP_ADDRESS" are
changed to call directly.
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h |8
1 file changed, 4 insertions(+), 4 de
This patch replace "B_UINT16" with "u16"
in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index 4c9662b..fbd06a1 100644
--- a/drive
This patch replaces "B_UINT8" with "u8"
in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index fbd06a1..27b5011 100644
--- a/dr
This patch replaces "BOOLEAN" with "bool"
in Adapter.h
Signed-off-by: Kevin McKinney
---
drivers/staging/bcm/Adapter.h | 122 -
1 file changed, 61 insertions(+), 61 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
i
25 matches
Mail list logo
