Re: [PATCH 7/8] staging: Remove OOM message after input_allocate_device

2013-10-24 Thread Jonathan Cameron
On 10/23/13 20:14, Joe Perches wrote: > Emitting an OOM message isn't necessary after input_allocate_device > as there's a generic OOM and a dump_stack already done. > > Signed-off-by: Joe Perches Acked-by: Jonathan Cameron (for iio driver) > --- > drivers/staging/cptm1217/clearpad_tm1217.c

Re: [PATCH NEXT 1/5] staging: r8188eu: Fix sparse warnings in ioctl_linux.c

2013-10-24 Thread Dan Carpenter
I have looked at how this is called from ioctl_private_call() and it seems like these are actual user pointers and the code is buggy. The patch silences the warnings instead of fixing the bugs. regards, dan carpenter ___ devel mailing list de...@linux

Re: [PATCH NEXT 5/5] staging: r8188eu: Fix sparse warnings in rtl_p2p.c

2013-10-24 Thread Dan Carpenter
The patches 2-5 seem ok. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH NEXT 1/5] staging: r8188eu: Fix sparse warnings in ioctl_linux.c

2013-10-24 Thread Larry Finger
On 10/24/2013 05:10 AM, Dan Carpenter wrote: I have looked at how this is called from ioctl_private_call() and it seems like these are actual user pointers and the code is buggy. The patch silences the warnings instead of fixing the bugs. Thanks for the review. Greg - please drop this one and

Re: [PATCH NEXT 1/5] staging: r8188eu: Fix sparse warnings in ioctl_linux.c

2013-10-24 Thread Greg KH
On Thu, Oct 24, 2013 at 09:46:53AM -0500, Larry Finger wrote: > On 10/24/2013 05:10 AM, Dan Carpenter wrote: > > I have looked at how this is called from ioctl_private_call() and it > > seems like these are actual user pointers and the code is buggy. The > > patch silences the warnings instead of

Re: [PATCH] drivers: staging: speakup: serialio: delay initializing 'old_serial_port.baud_base'

2013-10-24 Thread Greg KH
On Wed, Oct 23, 2013 at 11:20:12AM +0800, Chen Gang wrote: > For some architectures (e.g. arc), BASE_BAUD cannot be constant number. > So have to delay initializing 'old_serial_port.baud_base', or can not > pass compiling. > > The related error (allmodconfig for arc with gcc-4.8.0): > > CC [M