Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-15 Thread Sascha Hauer
On Mon, Oct 14, 2013 at 11:50:29PM +0100, Russell King - ARM Linux wrote: > Answers to these two questions may help stop me wasting a lot of time > chasing what is a really weird bug. > > So, I have X up and running on the Cubox-i carrier-1, using the imx-drm > stuff (I've slightly hacked my xf86-

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-15 Thread Russell King - ARM Linux
On Tue, Oct 15, 2013 at 09:46:18AM +0200, Sascha Hauer wrote: > On Mon, Oct 14, 2013 at 11:50:29PM +0100, Russell King - ARM Linux wrote: > > Answers to these two questions may help stop me wasting a lot of time > > chasing what is a really weird bug. > > > > So, I have X up and running on the Cub

Re: [PATCH] staging: octeon-ethernet: trivial: Avoid OOPS if phydev is not set

2013-10-15 Thread Dan Carpenter
On Mon, Oct 14, 2013 at 10:49:37PM +0300, Aaro Koskinen wrote: > On Mon, Oct 14, 2013 at 10:16:49PM +0300, Dan Carpenter wrote: > > On Mon, Oct 14, 2013 at 09:39:06PM +0300, Aaro Koskinen wrote: > > > It's initialized in cvm_oct_phy_setup_device(): > > > > > > priv->phydev = of_phy_connect(dev,

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-15 Thread Russell King - ARM Linux
On Mon, Oct 14, 2013 at 11:47:17PM -0300, Fabio Estevam wrote: > On Mon, Oct 14, 2013 at 2:38 PM, Russell King - ARM Linux > wrote: > > > Shouldn't the above be in patch 1 (or 1.5) rather than patch 2? Patch 2 > > advertises itself as adding support for the wandboard, but in actual > > fact it's

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-15 Thread Sascha Hauer
On Tue, Oct 15, 2013 at 11:00:26AM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 14, 2013 at 11:47:17PM -0300, Fabio Estevam wrote: > > On Mon, Oct 14, 2013 at 2:38 PM, Russell King - ARM Linux > > wrote: > > > > > Shouldn't the above be in patch 1 (or 1.5) rather than patch 2? Patch 2 >

Re: [PATCH v2 2/3] ARM: dts: imx6qdl-wandboard: Add HDMI support

2013-10-15 Thread Russell King - ARM Linux
On Tue, Oct 15, 2013 at 10:18:30AM +0100, Russell King - ARM Linux wrote: > On Tue, Oct 15, 2013 at 09:46:18AM +0200, Sascha Hauer wrote: > > This sounds like the wrong clock polarity. Could you try inverting > > sig_cfg.clk_pol in imx-drm/ipuv3-crtc.c? > > I tweaked it a different way - I used de

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-15 Thread Russell King - ARM Linux
Another point on patch 1. Sorry, I don't have patch 1 to reply to, it seems it was deleted from linux-arm-kernel's moderation queue. drm_mode_connector_attach_encoder() is called too early, before the base.id field in the encoder has been initialised. This causes the connectors encoder array to

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-15 Thread Fabio Estevam
On Tue, Oct 15, 2013 at 10:10 AM, Russell King - ARM Linux wrote: > Another point on patch 1. Sorry, I don't have patch 1 to reply to, it > seems it was deleted from linux-arm-kernel's moderation queue. > > drm_mode_connector_attach_encoder() is called too early, before the > base.id field in the

[PATCH] [media] staging: media: Fix build for iMON LIRC driver

2013-10-15 Thread Thierry Reding
Add a missing , between parameters in a call to dev_info(). Signed-off-by: Thierry Reding --- drivers/staging/media/lirc/lirc_imon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c index 8180187.

[GIT PULL FOR v3.13] OMAP4 ISS driver

2013-10-15 Thread Laurent Pinchart
Hello, Here's a pull request for v3.13 that adds a driver for the OMAP4 ISS (camera interface). The driver has been posted for review on the de...@driverdev.osuosl.org and linux-me...@vger.kernel.org mailing lists. A couple of review comments were received (thanks to the reviewers). I've decid

Re: [GIT PULL FOR v3.13] OMAP4 ISS driver

2013-10-15 Thread Greg Kroah-Hartman
On Tue, Oct 15, 2013 at 06:13:04PM +0200, Laurent Pinchart wrote: > Hello, > > Here's a pull request for v3.13 that adds a driver for the OMAP4 ISS (camera > interface). I don't take pull requests for staging drivers. But even if I did, Mauro takes drivers/staging/media/ code, so it's up to him

Re: [GIT PULL FOR v3.13] OMAP4 ISS driver

2013-10-15 Thread Laurent Pinchart
Hi Greg, On Tuesday 15 October 2013 09:35:30 Greg Kroah-Hartman wrote: > On Tue, Oct 15, 2013 at 06:13:04PM +0200, Laurent Pinchart wrote: > > Hello, > > > > Here's a pull request for v3.13 that adds a driver for the OMAP4 ISS > > (camera interface). > > I don't take pull requests for staging dr

Re: [PATCH v2] staging/olpc_dcon: fix kconfig to fix build errors

2013-10-15 Thread Greg Kroah-Hartman
On Mon, Oct 14, 2013 at 03:26:39PM -0700, Randy Dunlap wrote: > On 10/14/13 09:33, Greg Kroah-Hartman wrote: > > On Sun, Oct 13, 2013 at 12:30:00PM -0700, Randy Dunlap wrote: > >> From: Randy Dunlap > >> > >> Fix build errors when GPIO_CS5535=m and FB_OLPC_DCON=y > >> by preventing that kconfig co

Re: [GIT PULL FOR v3.13] OMAP4 ISS driver

2013-10-15 Thread Dan Carpenter
On Tue, Oct 15, 2013 at 09:35:30AM -0700, Greg Kroah-Hartman wrote: > On Tue, Oct 15, 2013 at 06:13:04PM +0200, Laurent Pinchart wrote: > > Hello, > > > > Here's a pull request for v3.13 that adds a driver for the OMAP4 ISS > > (camera > > interface). > > I don't take pull requests for staging

Re: [GIT PULL FOR v3.13] OMAP4 ISS driver

2013-10-15 Thread Laurent Pinchart
Hi Dan, On Tuesday 15 October 2013 23:03:45 Dan Carpenter wrote: > On Tue, Oct 15, 2013 at 09:35:30AM -0700, Greg Kroah-Hartman wrote: > > On Tue, Oct 15, 2013 at 06:13:04PM +0200, Laurent Pinchart wrote: > > > Hello, > > > > > > Here's a pull request for v3.13 that adds a driver for the OMAP4 IS

[PATCH 1/1] drivers: hv: Fix wrong check for synic_event_page

2013-10-15 Thread Felipe Pena
The check for calling free_page() on hv_context.synic_event_page[cpu] is the same for hv_context.synic_message_page[cpu], like a copy-paste error. Signed-off-by: Felipe Pena --- drivers/hv/hv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hv/hv.c b/drivers/hv/hv

RE: [PATCH 1/1] drivers: hv: Fix wrong check for synic_event_page

2013-10-15 Thread KY Srinivasan
> -Original Message- > From: Felipe Pena [mailto:felipe...@gmail.com] > Sent: Tuesday, October 15, 2013 4:23 PM > To: KY Srinivasan; Haiyang Zhang > Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Felipe Pena > Subject: [PATCH 1/1] drivers: hv: Fix wrong check for synic_ev

Re: A review of dm-writeboost

2013-10-15 Thread Mikulas Patocka
On Mon, 14 Oct 2013, Akira Hayakawa wrote: > Hi, DM Guys > > I suppose I have finished the tasks to > answer Mikulas's pointing outs. > So, let me update the progress report. > > The code is updated now on my Github repo. > Checkout the develop branch to avail > the latest source code. > > Co

Re: A review of dm-writeboost

2013-10-15 Thread Akira Hayakawa
Mikulas, > I/Os shouldn't be returned with -ENOMEM. If they are, you can treat it as > a hard error. It seems to be blkdev_issue_discard returns -ENOMEM when bio_alloc fails, for example. Waiting for a second and we can alloc the memory is my idea for handling -ENOMEM returned. > Blocking I/O un

Re: A review of dm-writeboost

2013-10-15 Thread Dave Chinner
[cc x...@oss.sgi.com] On Tue, Oct 15, 2013 at 08:01:45PM -0400, Mikulas Patocka wrote: > On Mon, 14 Oct 2013, Akira Hayakawa wrote: > > But, XFS stalls ... > > --- > > For testing, > > I manually turns `blockup` to 1 > > when compiling Ruby is in progress > > on XFS on a writeboost