On Tuesday 10 September 2013 22:54:44 Dan Carpenter wrote:
> On Tue, Sep 10, 2013 at 09:36:14AM +0200, Jürgen Beisert wrote:
> > > This patch seems to combine two things -- register access rework AND
> > > adjustment of the driver for MX23 touchscreen.
> >
> > It reworks the register access to avo
On Tuesday 10 September 2013 23:21:16 Marek Vasut wrote:
> Dear Dan Carpenter,
>
> > On Tue, Sep 10, 2013 at 09:36:14AM +0200, Jürgen Beisert wrote:
> > > > This patch seems to combine two things -- register access rework AND
> > > > adjustment of the driver for MX23 touchscreen.
> > >
> > > It re
On Tue, Sep 10, 2013 at 06:29:39PM -0700, Chris Brannon wrote:
> Ok. I just sent up a patch to the driverdev list. I missed a few
> of the Cc's that were on this thread, though.
> Also, it will conflict with Raphael's cleanup.
You're missing Raphael's CC in particular...
Really, Raphael's patch
The LRADC units in i.MX23 and i.MX28 differ and we need to distinguish both
SoC variants in order to make the touchscreen work on i.MX23
Signed-off-by: Juergen Beisert
CC: linux-arm-ker...@lists.infradead.org
CC: de...@driverdev.osuosl.org
CC: Marek Vasut
CC: Fabio Estevam
CC: Jonathan Cameron
Distinguish i.MX23 and i.MX28 at runtime and do the same for both SoC at least
for the 4 wire touchscreen.
Note: support for the remaining LRADC channels is not tested on an
i.MX23 yet.
Signed-off-by: Juergen Beisert
CC: linux-arm-ker...@lists.infradead.org
CC: de...@driverdev.osuosl.org
CC: Mar
The following series replaces the current busy loop touchscreen implementation
for i.MX28/i.MX23 SoCs by a fully interrupt driven implementation.
Since i.MX23 and i.Mx28 silicon differs, the existing implementation can
be used for the i.MX28 SoC only.
So, the first two patches of this series move
Signed-off-by: Juergen Beisert
CC: linux-arm-ker...@lists.infradead.org
CC: de...@driverdev.osuosl.org
CC: Marek Vasut
CC: Fabio Estevam
CC: Jonathan Cameron
---
drivers/staging/iio/adc/mxs-lradc.c | 165
1 file changed, 165 deletions(-)
diff --git a/drive
Replace the individual register access by a few shared access function to make
the
code easier to read and in order to add the i.MX23 SoC in the next step.
Signed-off-by: Juergen Beisert
CC: linux-arm-ker...@lists.infradead.org
CC: de...@driverdev.osuosl.org
CC: Marek Vasut
CC: Fabio Estevam
C
For battery driven systems it is a very bad idea to collect the touchscreen
data within a kernel busy loop.
This change uses the features of the hardware to delay and accumulate samples in
hardware to avoid a high interrupt and CPU load.
Note: this is only tested on an i.MX23 SoC yet.
Signed-off
In order to support i.MX23 and i.MX28 within one driver we need to separate the
register definitions which differ in both SoC variants.
Signed-off-by: Juergen Beisert
CC: linux-arm-ker...@lists.infradead.org
CC: de...@driverdev.osuosl.org
CC: Marek Vasut
CC: Fabio Estevam
CC: Jonathan Cameron
On Wed, Sep 11, 2013 at 10:46:37AM +0700, Vadim A. Misbakh-Soloviov wrote:
>
> P.S. is it correct maillist for such help requests at all? :)
>
You would probably have better luck asking on
linux-in...@vger.kernel.org.
Specify exactly which laptop you are using, btw. It may be a known
thing. Al
On Tue, 2013-09-10 at 21:41 -0700, Kees Cook wrote:
> Make sure that format strings cannot leak into printk() calls from the
> msgbuf string.
printf(string);
vs
printf("%s", string);
How does this help?
___
devel mailing list
de...@lin
Hi, Dan!
11.09.2013 15:30, Dan Carpenter пишет:
> On Wed, Sep 11, 2013 at 10:46:37AM +0700, Vadim A. Misbakh-Soloviov wrote:
>>
>> P.S. is it correct maillist for such help requests at all? :)
>>
>
> You would probably have better luck asking on
> linux-in...@vger.kernel.org.
Can I just add it a
On Wed, Sep 11, 2013 at 03:34:51PM +0700, Vadim A. Misbakh-Soloviov wrote:
> > You would probably have better luck asking on
> > linux-in...@vger.kernel.org.
>
> Can I just add it as CC, or should I rewrite there from the scratch?
>
Send it to them and drop us from the list. This list has a bro
On Tue, Sep 10, 2013 at 10:19:17PM -0700, Kees Cook wrote:
> In the former case, format characters will get processed by the
> sprintf logic. In the latter, they are printed as-is. In this specific
> case, if there was a way to inject strings like "ohai %n" into the
> msgbuf string, the former woul
From: Wei Yongjun
Fix to return -EINVAL in the version check error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/hv/connection.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/hv/connection.c b/drivers/hv/
On Wed, Sep 04, 2013 at 12:19:16PM +0300, Dan Carpenter wrote:
> Sorry, this is still in my postponed messages folder. I meant to send
> it earlier.
>
> On Mon, Sep 02, 2013 at 10:23:21PM +0100, Mark Einon wrote:
> > Ignoring checkpatch for some lines - now just over 80 chars, but much
> > more r
On Wed, Sep 11, 2013 at 01:29:49PM +0100, Mark Einon wrote:
> On Wed, Sep 04, 2013 at 12:19:16PM +0300, Dan Carpenter wrote:
> > Sorry, this is still in my postponed messages folder. I meant to send
> > it earlier.
> >
> > On Mon, Sep 02, 2013 at 10:23:21PM +0100, Mark Einon wrote:
> > > Ignoring
Remove braces from a few single line if statements.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index a8f7cd7..7cd3d34 100644
---
phy_lock is no longer used in any useful code, it's all been moved into
a phy_device. Remove the lock definition and init.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et13
Adding some trivial formatting suggestions made by Dan Carpenter to
the TODO.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/README |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
index 9272a24..8da9
The rcv_pend_lock spinlock isn't used anymore. remove it.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c |2 --
1 file changed, 2 deletions(-)
create mode 100644 drivers/staging/et131x/Module.symvers
diff --git a/drivers/staging/et131x/Module.symvers
b/drivers/staging/et131
This patch adds support for authenticating both client and server using
a pre-shared passphrase using SRP (Secure Remote Password) over TLS (see
RFC 5054) using GnuTLS. Both usbip and usbipd now accept a shared secret
as a command line argument. Currently, the established TLS connection is
only use
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/configure.ac
b/drivers/staging/usbip/userspace/configure.ac
index 099d24b..0b0e035 1006
getaddrinfo() leaves the order of the returned addrinfo structs
unspecified. On systems with bindv6only disabled (this is the default),
PF_INET6 sockets bind to IPv4, too. Thus, IPv6 support in usbipd was
broken when getaddrinfo returned first IPv4 and then IPv6 addrinfos, as
the IPv6 bind failed w
Not all new program versions necessarily introduce
non-backwards-compatible protocol changes. We thus move the definition
of the protocol version from configure.ac to usbip_network.h, where it
logically belongs to.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/u
This patch adds new error codes and features extended error reporting in
op_common packets.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbip_attach.c | 4 +-
drivers/staging/usbip/userspace/src/usbip_list.c | 3 +-
.../staging/usbip/us
usbip now prints an error message when started as user and requiring
root access. Also, some debug messages are changed to error messages so
the command line utilities now print less confusing (and more verbose)
error messages when not used correctly.
Signed-off-by: Dominik Paulus
Signed-off-by:
Interpret the ACLs stored in sysfs in usbipd and reject clients not
matching one of the ACLs.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/Makefile.am | 2 +-
drivers/staging/usbip/userspace/src/usbipd.c|
This patch adds the possibility to stored ACLs for allowed clients for
each stub device in sysfs. It adds a new sysfs entry called "usbip_acl"
for each stub device, containing a list of CIDR masks of allowed
clients. This file will be used by usbip and usbipd to store the ACL.
Signed-off-by: Kurt
For IPv6, IP:Port is unreadable.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/usbipd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/src/usbipd.c
b/drivers/staging/usbip/userspace/src/us
This patch adds a few utility functions to match IP addresses against
CIDR masks.
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/src/utils.c | 84 +
drivers/staging/usbip/userspace/src/utils.h | 15 ++
2 files chang
Hi,
this patch series includes an updated version of the IPv6 support patch (a call
to freeaddrinfo() was missing) as well as:
- The client/server authentication support using GnuTLS Tobias already
announced on the usbip-devel mailing list some time ago[1]
- Support for restricting the acce
Add the command line argument -a (--allow) to usbip bind to specify
networks allowed to attach to the device and code to store the ACLs in
sysfs.
Signed-off-by: Kurt Kanzenbach
Signed-off-by: Dominik Paulus
Signed-off-by: Tobias Polzer
---
drivers/staging/usbip/userspace/doc/usbip.8 | 8
On Wed, Sep 11, 2013 at 10:51:50AM +0800, Peng Tao wrote:
> I'm not fighting against removing the piece of code. But if there is a
> strong reason to keep the functionality, we need to find a way to
> implement it. The convenience of using environment variables is that
> job scheduler can set the e
When a new voice is selected, we set volume and pitch appropriate for
the voice. We need to use the numeric index corresponding to the
voice when indexing into the volume and pitch tables, rather than
the raw user input that was used to select the voice.
Note that using the raw input can also lead
On Wed, Sep 11, 2013 at 2:31 AM, Dan Carpenter wrote:
> On Tue, Sep 10, 2013 at 10:19:17PM -0700, Kees Cook wrote:
>> In the former case, format characters will get processed by the
>> sprintf logic. In the latter, they are printed as-is. In this specific
>> case, if there was a way to inject stri
On Wed, 2013-09-11 at 11:19 -0700, Kees Cook wrote:
> On Wed, Sep 11, 2013 at 2:31 AM, Dan Carpenter
> wrote:
> > On Tue, Sep 10, 2013 at 10:19:17PM -0700, Kees Cook wrote:
> >> In the former case, format characters will get processed by the
> >> sprintf logic. In the latter, they are printed as-
On Wed, Sep 11, 2013 at 12:09 PM, Joe Perches wrote:
> On Wed, 2013-09-11 at 11:19 -0700, Kees Cook wrote:
>> On Wed, Sep 11, 2013 at 2:31 AM, Dan Carpenter
>> wrote:
>> > On Tue, Sep 10, 2013 at 10:19:17PM -0700, Kees Cook wrote:
>> >> In the former case, format characters will get processed by
On Wed, Sep 11, 2013 at 12:22 PM, Dan Carpenter
wrote:
> On Wed, Sep 11, 2013 at 11:19:11AM -0700, Kees Cook wrote:
>> On Wed, Sep 11, 2013 at 2:31 AM, Dan Carpenter
>> wrote:
>> > On Tue, Sep 10, 2013 at 10:19:17PM -0700, Kees Cook wrote:
>> >> In the former case, format characters will get pro
> * %n is ignored
Really it should trigger a WARN_ON_ONCE(). There is code like
show_console_dev() which relies on it to work. If we ignore %n it
causes another bug.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://d
On Wed, Sep 11, 2013 at 11:19:11AM -0700, Kees Cook wrote:
> On Wed, Sep 11, 2013 at 2:31 AM, Dan Carpenter
> wrote:
> > On Tue, Sep 10, 2013 at 10:19:17PM -0700, Kees Cook wrote:
> >> In the former case, format characters will get processed by the
> >> sprintf logic. In the latter, they are prin
> -Original Message-
> From: Wei Yongjun [mailto:weiyj...@gmail.com]
> Sent: Wednesday, September 11, 2013 4:20 AM
> To: KY Srinivasan; Haiyang Zhang
> Cc: yongjun_...@trendmicro.com.cn; de...@linuxdriverproject.org; linux-
> ker...@vger.kernel.org
> Subject: [PATCH] Drivers: hv: vmbus: f
On Wed, Sep 11, 2013 at 12:45 PM, Joe Perches wrote:
> On Wed, 2013-09-11 at 12:25 -0700, Kees Cook wrote:
>> On Wed, Sep 11, 2013 at 12:09 PM, Joe Perches wrote:
>> > On Wed, 2013-09-11 at 11:19 -0700, Kees Cook wrote:
>> >> On Wed, Sep 11, 2013 at 2:31 AM, Dan Carpenter
>> >> wrote:
>> >> > O
Raphael S.Carvalho, le Mon 02 Sep 2013 19:20:18 -0300, a écrit :
> Well, there is no need to use strcmp since we can make a test of similar
> semantic by using the var_id field of param.
> I moved the test into the VAR_NUM:VAR_TIME case since VAR_STRING will never
> be "voice".
>
> spk_xlate isn
On 2013/09/10 8:25 PM, "Peng Tao" wrote:
>On Wed, Sep 11, 2013 at 9:44 AM, Christoph Hellwig
>wrote:
>> On Wed, Sep 11, 2013 at 01:14:11AM +0800, Peng Tao wrote:
>>> The problem is access_process_vm() is not exported since certain
>>> version of kernel including the latest. According to Christop
Christopher Brannon, le Tue 10 Sep 2013 18:21:18 -0700, a écrit :
> When a new voice is selected, we set volume and pitch appropriate for
> the voice. We need to use the numeric index corresponding to the
> voice when indexing into the volume and pitch tables, rather than
> the raw user input that
Signed-off-by: Jon Bernard
---
drivers/staging/lustre/lustre/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/Kconfig
b/drivers/staging/lustre/lustre/Kconfig
index 4e898e4..f949728 100644
--- a/drivers/staging/lustre/lustre/Kconfig
+++ b/d
Christopher Brannon, le Wed 11 Sep 2013 10:05:27 -0700, a écrit :
> When a new voice is selected, we set volume and pitch appropriate for
> the voice. We need to use the numeric index corresponding to the
> voice when indexing into the volume and pitch tables, rather than
> the raw user input that
On 2013/09/11 10:29 AM, "Christoph Hellwig" wrote:
>Talking about nasty code, the whole linux-curproc.c is highly
>questionable:
>
> - cfs_curproc_groups_nr:
> unused and should be removed
This is already removed in the upstream Lustre code, it just hasn't made
it into the kernel yet.
>- c
On 2013/09/10 10:37 PM, "Kees Cook" wrote:
>This fixes up the usage of snprintf, strncpy, and format strings in the
>call to kthread_run to avoid ever accidentally allowing a format string
>into the thread name.
>
>Signed-off-by: Kees Cook
No objection, though I don't think there was any securit
On Wed, 2013-09-11 at 12:25 -0700, Kees Cook wrote:
> On Wed, Sep 11, 2013 at 12:09 PM, Joe Perches wrote:
> > On Wed, 2013-09-11 at 11:19 -0700, Kees Cook wrote:
> >> On Wed, Sep 11, 2013 at 2:31 AM, Dan Carpenter
> >> wrote:
> >> > On Tue, Sep 10, 2013 at 10:19:17PM -0700, Kees Cook wrote:
> >
On Wed, Sep 11, 2013 at 4:22 PM, Joe Perches wrote:
> Using vsnprintf or its derivatives with %n can have security
> vulnerability implications.
>
> Prior to commit fef20d9c1380
> ("vsprintf: unify the format decoding layer for its 3 users"),
> any use of %n was ignored.
>
> Reintroduce this featu
On Tue, Aug 20, 2013 at 9:51 AM, Mitch Harder
wrote:
> On Sun, Aug 18, 2013 at 11:44 PM, Minchan Kim wrote:
>> Hello,
>>
>> On Mon, Aug 19, 2013 at 12:13:02PM +0800, Michael wang wrote:
>>> Hi, Mitch
>>>
>>> On 08/17/2013 10:01 PM, Mitch Harder wrote:
>>> > I'm encountering a BUG while using a ZR
Using vsnprintf or its derivatives with %n can have security
vulnerability implications.
Prior to commit fef20d9c1380
("vsprintf: unify the format decoding layer for its 3 users"),
any use of %n was ignored.
Reintroduce this feature and convert the existing uses of %n
to use the return length fro
On 09/12/2013 04:03 AM, KY Srinivasan wrote:
>
>> -Original Message-
>> From: Wei Yongjun [mailto:weiyj...@gmail.com]
>> Sent: Wednesday, September 11, 2013 4:20 AM
>> To: KY Srinivasan; Haiyang Zhang
>> Cc: yongjun_...@trendmicro.com.cn; de...@linuxdriverproject.org; linux-
>> ker...@vger.
On 09/10/2013 06:00 PM, Jon Bernard wrote:
This is a patch to fwserial.c that wraps a line which previously exceeded the 80
character limit warning found by checkpatch.pl. This driver is now warning and
error free, according to checkpatch.pl
Signed-off-by: Jon Bernard
Ok with me, thanks.
Re
Joe Perches wrote:
> - seq_printf(m, "%s%d%n", con->name, con->index, &len);
> + len = seq_printf(m, "%s%d", con->name, con->index);
Isn't len always 0 or -1 ?
int seq_vprintf(struct seq_file *m, const char *f, va_list args)
{
int len;
if (m->count < m->size) {
> -Original Message-
> From: Wei Yongjun [mailto:weiyj...@gmail.com]
> Sent: Wednesday, September 11, 2013 5:26 PM
> To: KY Srinivasan
> Cc: Haiyang Zhang; yongjun_...@trendmicro.com.cn;
> de...@linuxdriverproject.org; linux-ker...@vger.kernel.org
> Subject: Re: [PATCH] Drivers: hv: vmbus
On Wed, 2013-09-11 at 16:29 -0700, Kees Cook wrote:
> On Wed, Sep 11, 2013 at 4:22 PM, Joe Perches wrote:
> > Using vsnprintf or its derivatives with %n can have security
> > vulnerability implications.
> >
> > Prior to commit fef20d9c1380
> > ("vsprintf: unify the format decoding layer for its 3
On Wed, Sep 11, 2013 at 05:04:17PM -0700, Joe Perches wrote:
> On Thu, 2013-09-12 at 08:40 +0900, Tetsuo Handa wrote:
> > Joe Perches wrote:
> > > - seq_printf(m, "%s%d%n", con->name, con->index, &len);
> > > + len = seq_printf(m, "%s%d", con->name, con->index);
> >
> > Isn't len always 0 or -1 ?
On Thu, 2013-09-12 at 01:19 +0100, Al Viro wrote:
> On Wed, Sep 11, 2013 at 05:04:17PM -0700, Joe Perches wrote:
> > On Thu, 2013-09-12 at 08:40 +0900, Tetsuo Handa wrote:
> > > Joe Perches wrote:
> > > > - seq_printf(m, "%s%d%n", con->name, con->index, &len);
> > > > + len = seq_printf
62 matches
Mail list logo
