Re: [PATCH] Staging:BCM:DDRInit.c:Renaming __FUNCTION__

On Fri, Aug 30, 2013 at 06:49:16PM +0100, Paul McQuade wrote: > >From c21d0da84c92d351f37b70c0d9c01a66fcb84e88 Mon Sep 17 00:00:00 2001 > From: Paul McQuade > Date: Thu, 15 Aug 2013 20:00:50 +0100 > Subject: [PATCH] Staging:BCM:DDRInit.c:Renaming __FUNCTION__ > Don't put these in the patch descr

Re: [PATCH 2/2] staging: dgap: Remove unnecessary version check

On 31 August 2013 00:00, Greg KH wrote: > On Thu, Aug 29, 2013 at 03:36:55PM +0530, Sachin Kamat wrote: >> Code should be for the kernel version it is merged in. Version >> check is not necessary. >> >> Signed-off-by: Sachin Kamat >> --- >> Compile tested only. >> --- >> drivers/staging/dgap/dga

Re: staging: r8188eu: Add files for new driver - part 7

On 08/29/2013 04:48 PM, Dan Carpenter wrote: Hello Larry Finger, The patch d6846af679e0: "staging: r8188eu: Add files for new driver - part 7" from Aug 21, 2013, leads to the following Smatch warning: "drivers/staging/rtl8188eu/core/rtw_xmit.c:1570 dequeue_one_xmitframe() info: ignoring

Re: [patch 2/2] staging: rtl8188eu: || vs && typo

On 08/29/2013 04:46 PM, Dan Carpenter wrote: Obviously it's impossible for ->KeyLength to be both 5 and 13. I assume that && was intended here. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c index 5fab

Re: [patch] staging: r8188eu: copying one byte too much

On 08/29/2013 04:47 PM, Dan Carpenter wrote: There is a copy and paste bug here so we copy 4 bytes instead of 3. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c index a43fc88..013ea48 100644 --- a/driver

[PATCH] staging: android/timed_output: Create 'enable' attribute automatically

The 'enable' attribute is needed for all timed_output_class devices. It can thus be created automatically when creating the timed_output device. This simplifies the code and ensures that the attribute exists when the udev event announcing device registration is generated. Signed-off-by: Guenter Ro

[PATCH v2] staging: android/timed_output: Create 'enable' attribute automatically

The 'enable' attribute is needed for all timed_output_class devices. It can thus be created automatically when creating the timed_output device. This simplifies the code and ensures that the attribute exists when the udev event announcing device registration is generated. Signed-off-by: Guenter Ro

Re: staging: r8188eu: Add files for new driver - part 7

On Sat, Aug 31, 2013 at 11:36:09AM -0500, Larry Finger wrote: > On 08/29/2013 04:48 PM, Dan Carpenter wrote: > >Hello Larry Finger, > > > >The patch d6846af679e0: "staging: r8188eu: Add files for new driver - > >part 7" from Aug 21, 2013, leads to the following Smatch warning: > >"drivers/staging/r

Re: [PATCH] staging: android/timed_output: Create 'enable' attribute automatically

On Sat, Aug 31, 2013 at 11:32:58AM -0700, Guenter Roeck wrote: > The 'enable' attribute is needed for all timed_output_class devices. > It can thus be created automatically when creating the timed_output device. > This simplifies the code and ensures that the attribute exists when the > udev event

Hello

Hello, I am Mr. Donald Lawson, of Lapeer, MI 48446 USA. I won $337 million in the Powerball Millions Lottery as introduced on Friday August 17th 2012 by Michigan Lottery Officials. Please share in my joy and verify this by visiting: http://usnews.nbcnews.com/_news/2012/08/31/13591150-winner-of

Re: [PATCH] staging: dgnc: adds TODO

On Fri, Aug 30, 2013 at 2:28 PM, Greg KH wrote: > On Thu, Aug 29, 2013 at 07:00:37PM -0400, Lidza Louina wrote: >> This patchs adds a TODO for the driver. >> >> Signed-off-by: Lidza Louina >> --- >> drivers/staging/dgnc/TODO | 17 + >> 1 file changed, 17 insertions(+) >> create

[PATCH 01/12] staging: dgnc: removes casting when using kzalloc

This patch removes casting that is used when kzalloc is called. Casting isn't needed because kzalloc returns a void pointer. Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver

[PATCH 09/12] staging: dgnc: mgmt.c: checkpatch: removes parentheses around return statements

This patch removes this checkpatch warning: ERROR: return is not a function, parentheses are not required. Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_mgmt.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_mgmt.

[PATCH 11/12] staging: dgnc: sysfs.c: checkpatch: removes parentheses around return statements

This patch removes this checkpatch warning: ERROR: return is not a function, parentheses are not required. Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_sysfs.c | 116 +++--- 1 file changed, 58 insertions(+), 58 deletions(-) diff --git a/drivers/stagi

[PATCH 12/12] staging: dgnc: tty.c: checkpatch: removes parentheses around return statements

This patch removes this checkpatch warning: ERROR: return is not a function, parentheses are not required. Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_tty.c | 200 1 file changed, 100 insertions(+), 100 deletions(-) diff --git a/drivers/sta

[PATCH 04/12] staging: dgnc: replaces struct board_t with dgnc_board

This patch replaces struct board_t with dgnc_board. It contains the exact same information as board_t. This change was made because board_t isn't descriptive and the _t denotes a typedef, which it is not. Reported-by: Dan Carpenter Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_cls.c

[PATCH 08/12] staging: dgnc: driver.c: checkpatch: removes parentheses around return statements

This patch removes this checkpatch warning: ERROR: return is not a function, parentheses are not required. Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_driver.c | 102 ++--- 1 file changed, 51 insertions(+), 51 deletions(-) diff --git a/drivers/stagi

[PATCH 03/12] staging: dgnc: driver.h: adds struct dgnc_board

This patch adds the dgnc_board struct to driver.h. This struct will replace board_t in this driver. Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_driver.h | 85 ++ 1 file changed, 85 insertions(+) diff --git a/drivers/staging/dgnc/dgnc_driver.h b

[PATCH 07/12] staging: dgnc: cls.c: checkpatch: removes parentheses around return statements

This patch removes this checkpatch warning: ERROR: return is not a function, parentheses are not required. Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_cls.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging

[PATCH 02/12] staging: dgnc: replaces generic struct from sizeof calls

This patch replaces all instances of "sizeof(struct" with actual instances of the struct. For example "sizeof(struct tty_struct" is replaced with "sizeof(brd->SerialDriver.ttys". This patch affects driver.c, mgmt.c and tty.c. Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_driver.c |

[PATCH 06/12] staging: dgnc: removes kzalloc error statements

This patch removes the error statements that follow kzalloc. These are useless because kzalloc has its own error statement and the driver's error handling would never actually happen. Reported-by: Dan Carpenter Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_driver.c | 10 --

[PATCH 10/12] staging: dgnc: neo.c: checkpatch: removes parentheses around return statements

This patch removes this checkpatch warning: ERROR: return is not a function, parentheses are not required. Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_neo.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging

[PATCH 05/12] staging: dgnc: driver.h: removes struct board_t

This patch removes the struct board_t. This struct was replaced with dgnc_board in a previous patch. Signed-off-by: Lidza Louina --- drivers/staging/dgnc/dgnc_driver.h | 85 -- 1 file changed, 85 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b

[PATCH] staging: asus_oled: Create device attributes automatically

The 'enable' and 'picture' attributes are created for all oled_class devices. They can be created automatically when creating the oled_class device. This simplifies the code and ensures that the attributes exist when the udev event announcing device registration is generated. Signed-off-by: Guente

[PATCH] staging: dgrp: Convert to use device_create_with_groups

Use device_create_with_groups to create sysfs attributes together with device. Also create class attribute together with class registration. This simplifies the code and ensures that attribute files exist when udev events are generated. Signed-off-by: Guenter Roeck --- I suspect that the 'registe

Re: [PATCH v2] staging: android/timed_output: Create 'enable' attribute automatically

On 08/31/2013 01:20 PM, Guenter Roeck wrote: The 'enable' attribute is needed for all timed_output_class devices. It can thus be created automatically when creating the timed_output device. This simplifies the code and ensures that the attribute exists when the udev event announcing device regist

Re: [PATCH] staging: asus_oled: Create device attributes automatically

On 08/31/2013 03:24 PM, Guenter Roeck wrote: The 'enable' and 'picture' attributes are created for all oled_class devices. They can be created automatically when creating the oled_class device. This simplifies the code and ensures that the attributes exist when the udev event announcing device re

Re: [PATCH v2 net-next 0/9] set addr_assign_type when inheriting a dev_addr

From: Bjørn Mork Date: Fri, 30 Aug 2013 18:08:43 +0200 > Copying the dev_addr from a parent device is an operation > common to a number of drivers. The addr_assign_type should > be updated accordingly, either by reusing the value from > the source device or explicitly indicating that the address