On Wed, Aug 28, 2013 at 08:05:14PM -0400, Lidza Louina wrote:
>
> Also, can I put your name in the Reported-by: section of these patches?
It feels like cheating to boost your Reported-by count with style
comments. :P I'd be caught up to Fengguang.
Everyone likes credit though. I know the docs
Fixes the following compilation errors:
drivers/staging/dgap/dgap_driver.c:423:3: error:
implicit declaration of function ‘kfree’ [-Werror=implicit-function-declaration]
kfree(dgap_config_buf);
^
drivers/staging/dgap/dgap_driver.c: In function ‘dgap_driver_kzmalloc’:
drivers/staging/dgap/dgap_drive
Code should be for the kernel version it is merged in. Version
check is not necessary.
Signed-off-by: Sachin Kamat
---
Compile tested only.
---
drivers/staging/dgap/dgap_driver.c |4
drivers/staging/dgap/dgap_kcompat.h | 29 -
2 files changed, 33 deletions
On 2013-08-28 21:26, H Hartley Sweeten wrote:
The (*insn_bits) functions for DIO and DO subdevices typically use
the subdevice 's->state' to hold the current state of the output
channels. The 'insn' passed to these functions, INSN_BITS, specifies
two parameters passed in the 'data'.
data[0] =
On 2013-08-28 21:28, H Hartley Sweeten wrote:
Use comedi_dio_insn_bits() to handle the boilerplate code to update
the subdevice s->state for DIO and DO subdevices.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
[snip]
diff --git a/drivers/staging/comedi/drivers/8255
On 2013-08-28 21:29, H Hartley Sweeten wrote:
The subdevice 'io_bits' is a bit mask of the i/o configuration for
digital subdevices. '0' values indicate that a channel is configured
as an input and '1' values that the channel is an output. Since the
subdevice data is kzalloc()'d, all channels def
On 2013-08-28 21:29, H Hartley Sweeten wrote:
Use comedi_dio_insn_bits() to handle the boilerplate code to update
the subdevice s->state for DIO subdevices.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
[snip]
diff --git a/drivers/staging/comedi/drivers/addi_apci_3
On 2013-08-28 21:30, H Hartley Sweeten wrote:
Convert a couple more comedi drivers to use comedi_dio_insn_bits() to
handle the boilerplate code to update the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/amplc_dio20
On 2013-08-28 21:30, H Hartley Sweeten wrote:
Use comedi_dio_insn_bits() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ssv_dnp.c | 51 +---
On 2013-08-28 21:31, H Hartley Sweeten wrote:
Use comedi_dio_insn_bits() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adq12b.c | 22 ++
1 file c
On 2013-08-28 21:57, H Hartley Sweeten wrote:
Rename this function to better describe it's use.
Use comedi_dio_insn_bits() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/driv
On 2013-08-28 21:55, H Hartley Sweeten wrote:
Use the new comedi_dio_insn_bits() and comedi_dio_insn_config() helpers
to tidy up the digital subdevices in this driver.
Remove the need for the kzalloc'd private data.
H Hartley Sweeten (15):
staging: comedi: comedi_parport: tidy up the registe
On 2013-08-28 23:01, H Hartley Sweeten wrote:
Use the core provided helper function instead of duplicating it as
a private function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 10 ++
1 file changed, 2 inser
On 2013-08-28 22:59, H Hartley Sweeten wrote:
Use the core provided helper function instead of duplicating it as
a private function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcmad.c | 8 +---
1 file changed, 1 insertion(+
The result from crystalhd_get_sgle_paddr and crystalhd_get_sgle_len are later
used in calculations, so the result should be in CPU byte ordering.
Signed-off-by: Shaun Laing
---
Assumes sg_dma_address and sg_dma_len return values in CPU byte ordering.
drivers/staging/crystalhd/crystalhd_misc.h
On Thursday, August 29, 2013 4:14 AM, Ian Abbott wrote:
> On 2013-08-28 21:26, H Hartley Sweeten wrote:
>> The (*insn_bits) functions for DIO and DO subdevices typically use
>> the subdevice 's->state' to hold the current state of the output
>> channels. The 'insn' passed to these functions, INSN_B
On 2013-08-29 17:20, Hartley Sweeten wrote:
On Thursday, August 29, 2013 4:14 AM, Ian Abbott wrote:
On 2013-08-28 21:26, H Hartley Sweeten wrote:
The (*insn_bits) functions for DIO and DO subdevices typically use
the subdevice 's->state' to hold the current state of the output
channels. The 'in
On Thursday, August 29, 2013 5:32 AM, Ian Abbott wrote:
> On 2013-08-28 21:28, H Hartley Sweeten wrote:
>> Use comedi_dio_insn_bits() to handle the boilerplate code to update
>> the subdevice s->state for DIO and DO subdevices.
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc: Ian Abbott
>> Cc: Greg
Om Thursday, August 29, 2013 5:40 AM, Ian Abbott wrote:
> On 2013-08-28 21:29, H Hartley Sweeten wrote:
>> The subdevice 'io_bits' is a bit mask of the i/o configuration for
>> digital subdevices. '0' values indicate that a channel is configured
>> as an input and '1' values that the channel is an
On Thursday, August 29, 2013 5:52 AM, Ian Abbott wrote:
> On 2013-08-28 21:29, H Hartley Sweeten wrote:
>> Use comedi_dio_insn_bits() to handle the boilerplate code to update
>> the subdevice s->state for DIO subdevices.
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc: Ian Abbott
>> Cc: Greg Kroah-H
On 2013-08-29 17:39, Hartley Sweeten wrote:
On Thursday, August 29, 2013 5:32 AM, Ian Abbott wrote:
On 2013-08-28 21:28, H Hartley Sweeten wrote:
Use comedi_dio_insn_bits() to handle the boilerplate code to update
the subdevice s->state for DIO and DO subdevices.
Signed-off-by: H Hartley Sweet
On Thursday, August 29, 2013 9:37 AM, Ian Abbott wrote:
> On 2013-08-29 17:20, Hartley Sweeten wrote:
>> On Thursday, August 29, 2013 4:14 AM, Ian Abbott wrote:
>>> On 2013-08-28 21:26, H Hartley Sweeten wrote:
The (*insn_bits) functions for DIO and DO subdevices typically use
the subdevi
The lux_uscale value is not initialized at probe. The value will be
uninitialized unless a value is written to it through the iio channel interface.
This fixes that.
Signed-off-by: Derek Basehore
Reviewed-on: https://gerrit.chromium.org/gerrit/65998
---
drivers/staging/iio/light/isl29018.c | 1 +
drivers/staging/dgap/dgap_driver.c: In function ‘dgap_cleanup_module’:
drivers/staging/dgap/dgap_driver.c:423: error: implicit declaration of function
‘kfree’
drivers/staging/dgap/dgap_driver.c: In function ‘dgap_driver_kzmalloc’:
drivers/staging/dgap/dgap_driver.c:940: error: implicit declaration
These should be "<" instead of "<=". Also we can use the ARRAY_SIZE()
macro.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c
b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index 859fc19..9632ef4 100644
--- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
+++ b/drivers/
Obviously it's impossible for ->KeyLength to be both 5 and 13. I assume
that && was intended here.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
index 5fab477..193f641 100644
--- a/drivers/staging/rtl81
There is a copy and paste bug here so we copy 4 bytes instead of 3.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
index a43fc88..013ea48 100644
--- a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
+++ b/
Hello Larry Finger,
The patch 7b464c9fa5cc: "staging: r8188eu: Add files for new driver -
part 4" from Aug 21, 2013, leads to the following Smatch warning:
"drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:8328 mlme_evt_hdl()
error: buffer overflow 'wlanevents' 24 <= 24"
8321 /
"keyid" is used as an offset into the ->dot11DefKey[] array. The array
has 4 elements.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
index 9e12774..5fab477 100644
--- a/drivers/staging/rtl8188eu/core/rt
Hello Larry Finger,
The patch d6846af679e0: "staging: r8188eu: Add files for new driver -
part 7" from Aug 21, 2013, leads to the following Smatch warning:
"drivers/staging/rtl8188eu/core/rtw_xmit.c:1570
dequeue_one_xmitframe() info: ignoring unreachable code."
1559 while (!rtw
Hello Larry Finger,
The patch 615a4d12e556: "staging: r8188eu: Add files for new driver -
part 14" from Aug 21, 2013, leads to the following warning:
"drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:2008
Hal_ReadPowerValueFromPROM_8188E()
error: buffer overflow 'pwrInfo24G->IndexBW40_
This patchs adds a TODO for the driver.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/TODO | 17 +
1 file changed, 17 insertions(+)
create mode 100644 drivers/staging/dgnc/TODO
diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO
new file mode 100644
index
Consolidate the boilerplate code used to mask and set the output channels of
DIO and DO subdevices.
v2: address issues pointed out by Ian Abbott
reorder series a bit
pick up a couple drivers that were missed in v1
The comedi_parport driver still needs converted. This driver will b
The subdevice 'io_bits' is a bit mask of the i/o configuration for
digital subdevices. '0' values indicate that a channel is configured
as an input and '1' values that the channel is an output. Since the
subdevice data is kzalloc()'d, all channels default as inputs.
Modify __comedi_device_postconf
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
These drivers always need to update the hardware in order to update
the i/o configuration regardless of if the state has changed.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state for simple cases where the hardware is updated
when any channel is modified.
Also, fix a bug in the amplc_pc263 and amplc_pci263 drivers where the
current state is not returned in data[1].
Signed-off-by:
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Tidy up the vmk80xx_do_insn_bits() function a bit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/vmk80xx.c | 35 --
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Remove the DEBUG_DIO, its just added noise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 45 +-
Use the subdevice 'state' variable instead of carrying the state of
the output channels in the private data.
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/stagin
Use the subdevice 'state' variable instead of having to calculate the
current state based on the do_mux_bits in the private data.
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
Use the subdevice 'state' variable instead of carrying the state of
the output channels in the private data.
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/stagin
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Also, fix a bug where the state of the channels is returned in data[0].
The comedi core expects it to be returned in data[1].
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
--
On Thursday, August 29, 2013 7:19 AM, Ian Abbott wrote:
> On 2013-08-28 21:55, H Hartley Sweeten wrote:
>> Use the new comedi_dio_insn_bits() and comedi_dio_insn_config() helpers
>> to tidy up the digital subdevices in this driver.
>>
>> Remove the need for the kzalloc'd private data.
>>
>> H Hartl
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletion
Make sure that only the state of the channels configured as outputs are
updated.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers.c b/dr
Use comedi_dio_update_state() to handle the boilerplate code to update
the subdevice s->state.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_16xx.c | 12 +++-
drivers/staging/comedi/drivers/addi_apci_3xxx.c | 9 ++--
Kindly be informed that we are currently offering international Loan to
corporate companies / private individuals at low and affordable interest rate
of 2% for 1 to 30 years duration of the repayment period. Get yours now and
lift up your business returns. E-mail: easyloan.headoff...@gmail.com
47 matches
Mail list logo
