We set this using:
devs_closed |= (0x1 << bdev->minor)
Since 0x1 is an int then only the lower 32 bits are usable before we hit
a shift wrapping bug. There are some static checkers which complain
about this. I've silenced the warning by making devs_closed a 32 bit
number.
32 bits shoul
Smatch complains that there is a missing break statement here.
Signed-off-by: Dan Carpenter
---
This looks correct to me, but please double check.
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index 35251e7..03a0989 100644
--- a/drivers/staging/c
The error handling is messy and not in kernel style. On some paths it
frees "mux_dev" twice.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/gdm724x/gdm_mux.c
b/drivers/staging/gdm724x/gdm_mux.c
index 9e217ff..5b1ef40 100644
--- a/drivers/staging/gdm724x/gdm_mux.c
+++ b/drivers/stagi
"map" needs to be signed for the error handling to work. In the success
case then it holds a small non-negative value.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c
b/drivers/staging/imx-drm/ipu-v3/ipu-dc.c
index 59f03f9..21bf1c8 100644
--- a/drivers/staging
Dear Dan Carpenter,
> "map" needs to be signed for the error handling to work. In the success
> case then it holds a small non-negative value.
>
> Signed-off-by: Dan Carpenter
Nice catch and quick glance over the source makes it seem right
Acked-by: Marek Vasut
> diff --git a/drivers/stagi
On Wed, Aug 21, 2013 at 11:30:08AM +0300, Dan Carpenter wrote:
> "map" needs to be signed for the error handling to work. In the success
> case then it holds a small non-negative value.
>
> Signed-off-by: Dan Carpenter
Acked-by: Sascha Hauer
Sascha
>
> diff --git a/drivers/staging/imx-drm/i
On Wed, 21 Aug 2013, wei_w...@realsil.com.cn wrote:
> From: Wei WANG
>
> The default phase can meet most cards' requirement, but it is not the
> optimal one. In some extreme situation, the rx phase point produced by
> the following tuning process will drift quite a distance.
> Before tuning UHS
On 2013-08-21 09:28, Dan Carpenter wrote:
Smatch complains that there is a missing break statement here.
Signed-off-by: Dan Carpenter
---
This looks correct to me, but please double check.
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index 352
On 2013-08-21 09:27, Dan Carpenter wrote:
We set this using:
devs_closed |= (0x1 << bdev->minor)
Since 0x1 is an int then only the lower 32 bits are usable before we hit
a shift wrapping bug. There are some static checkers which complain
about this. I've silenced the warning by making
On 2013-08-21 11:44, Ian Abbott wrote:
On 2013-08-21 09:28, Dan Carpenter wrote:
Smatch complains that there is a missing break statement here.
Signed-off-by: Dan Carpenter
---
This looks correct to me, but please double check.
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/s
On Wed, Aug 21, 2013 at 11:50:22AM +0100, Ian Abbott wrote:
> On 2013-08-21 09:27, Dan Carpenter wrote:
> >We set this using:
> >
> > devs_closed |= (0x1 << bdev->minor)
> >
> >Since 0x1 is an int then only the lower 32 bits are usable before we hit
> >a shift wrapping bug. There are some stat
On Wed, Aug 21, 2013 at 12:35:22PM +0100, Ian Abbott wrote:
>
> Acked-by: Ian Abbott
> Reviewed-by: Ian Abbott
>
> (whichever is appropriate)
To me Acked-by is more emphatic. Since you're the maintainer it's
appropriate. I normally use "Reviewed-by" because I don't have the
authority to appr
This patch removes trailing whitespace in
the dgnc_driver.c file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_dr
This patch removes trailing whitespace in
the dgnc_cls.h file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_cls.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h
index dca5ea3..a273385 100644
This patch removes trailing whitespace in
the dpacompat.h file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dpacompat.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dpacompat.h b/drivers/staging/dgnc/dpacompat.h
index 44379eb..f96963b 1006
This patch removes trailing whitespace in
the dgnc_cls.c file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_cls.c | 48 -
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dg
This patch removes trailing whitespace in
the dgnc_tty.c file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 178
1 file changed, 89 insertions(+), 89 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dg
This patch removes trailing whitespace in
the kcompat.h file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_kcompat.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_kcompat.h
b/drivers/staging/dgnc/dgnc_kcompat.h
index a0f5874..00f5
This patch removes trailing whitespace in
the sysfs.c file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_sysfs.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
b/drivers/staging/dgnc/dgnc_sysfs.c
index f9c167
This patch removes trailing whitespace in
the digi.h file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/digi.h | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/dgnc/digi.h b/drivers/staging/dgnc/digi.h
index ab90382..802
This patch removes trailing whitespace in
the dgnc_neo.c file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_neo.c | 46 -
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dg
This patch removes trailing whitespace in
the dgnc_sysfs.h file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_sysfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.h
b/drivers/staging/dgnc/dgnc_sysfs.h
index fe99110..4b87ce1 100
This patch removes trailing whitespace in
the driver.h file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/staging/dgnc/dgnc_driver.h
index 33
This patch removes trailing whitespace in
the dgnc_mgmt.c file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_mgmt.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dg
This patch removes trailing whitespace in
the dgnc_trace.c file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_trace.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_trace.c
b/drivers/staging/dgnc/dgnc_trace.c
index e61
This patch removes trailing whitespace in
the neo.h file.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_neo.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h
index ffb4209..f7f569b 1006
On 2013-08-21 13:45, Dan Carpenter wrote:
On Wed, Aug 21, 2013 at 11:50:22AM +0100, Ian Abbott wrote:
On 2013-08-21 09:27, Dan Carpenter wrote:
We set this using:
devs_closed |= (0x1 << bdev->minor)
Since 0x1 is an int then only the lower 32 bits are usable before we hit
a shift wrapp
This patch fixes the error: "foo* bar" should be "foo *bar".
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 5938c4a..da035a5 100644
---
This patch fixes the error "code indent should use
tabs where possible" in dgnc_driver.h.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.h | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/
This patch fixes the error "code indent should use
tabs where possible" in dgnc_sysfs.c.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
b/drivers/staging/dgnc/dgnc_sysfs.
This patch fixes the error "code indent should use
tabs where possible" in dgnc_neo.c.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_neo.c | 46 -
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b
This patch fixes the error "code indent should use
tabs where possible" in dgnc_driver.c.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.c | 70 +++---
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driv
This patch fixes the error "code indent should use
tabs where possible" in dgnc_tty.c.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_tty.c | 156
1 file changed, 78 insertions(+), 78 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b
This patch removes the code supporting CVS
from its files.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_cls.c| 2 --
drivers/staging/dgnc/dgnc_driver.c | 2 --
drivers/staging/dgnc/dgnc_mgmt.c | 1 -
drivers/staging/dgnc/dgnc_neo.c| 2 --
drivers/staging/dgnc/dgnc_pci.h
This patch fixes the error: open brace '{'
following struct go on the same line.
Signed-off-by: Lidza Louina
---
drivers/staging/dgnc/dgnc_driver.h | 3 +--
drivers/staging/dgnc/digi.h| 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver
On Wed, Aug 21, 2013 at 05:44:34PM +0100, Ian Abbott wrote:
> On 2013-08-21 13:45, Dan Carpenter wrote:
> >On Wed, Aug 21, 2013 at 11:50:22AM +0100, Ian Abbott wrote:
> >>On 2013-08-21 09:27, Dan Carpenter wrote:
> >>>We set this using:
> >>>
> >>> devs_closed |= (0x1 << bdev->minor)
> >>>
> >>>S
Hi Paul,
> > > @@ -365,6 +366,7 @@ struct dwc2_hsotg {
> > > u8 otg_port;
> > > u32 *frame_list;
> > > dma_addr_t frame_list_dma;
> > > + int next_sched_frame;
> >
> > This variable is still not really used, I think. Most of the mentions in
> > the patch are assignments, except for these tw
Yes,
I added the next_sched_frame to track the next uframe that there is
anything to do in the periodic schedule. The SOF interrupt is then
disabled until that uframe (although the FIQ still runs each uframe to
decide whether to trigger the USB interrupt)
Gordon
On 21/08/2013 22:24, "Matthijs K
This patch fixes this error: invalid type
argument of ‘->’ (have ‘struct ktermios’).
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_tty.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/dgap/dgap_tty.c b/drivers/stagin
The declaration for the ioctl function has changed. The previous version
of this declaration took struct file *file as a parameter and the new
one does not. This patch removes that parameter.
It also removes cases for the commands TIOCGETP
TCGETS and TCGETA.
Signed-off-by: Lidza Louina
---
driv
This patch removes the unused variable page
in mgmt.c.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_mgmt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap_mgmt.c b/drivers/staging/dgap/dgap_mgmt.c
index 1147f1d..dce33d4 100644
--- a/drivers/staging/dgap/
This patch fixes the error: incompatible types
when assigning to type ‘struct ktermios *’ from
type ‘struct ktermios’
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_fep5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap_fep5.c b/drivers/st
This patch removes the use of read_cnt, real_raw and rawreadok.
These variables don't exist in the new API. Reading the data
raw is no longer supported by the tty layer.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_tty.c | 47 -
1 file changed
This patch removes references to proc code in this
driver. It still has proc.c, proc.h and a board
state called NEEDS_PROC_CREATION. All three of
these will be removed in another patch.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/Makefile | 2 +-
drivers/staging/dgap/dgap_driver.c
This patch adds the dgap driver to the kernel build process.
Signed-off-by: Lidza Louina
---
drivers/staging/Kconfig | 2 +-
drivers/staging/Makefile | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index 5e34ae4..d2d72c2 1
This patch fixes the error: incompatible types when
assigning to type ‘struct ktermios *’ from type
‘struct ktermios’
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgap/dgap_tty.c b/drivers/stag
On Wed, Aug 21, 2013 at 09:48:31PM -0400, Lidza Louina wrote:
> From:
I need a real email address, no "at" or "dot" please.
I'll edit it by hand this time, but in the future, please don't do that.
thanks,
greg k-h
___
devel mailing list
de...@linuxdr
This patch removes the HAVE_UNLOCKED_IOCTL conditional
statements from driver.c, mgmt.c and mgmt.h. This was
used to support older kernels. It isn't needed now.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_driver.c | 4
drivers/staging/dgap/dgap_mgmt.c | 6 --
drivers/sta
This patch fixes errors with the tty function calls
tty_buffer_request_room, tty_insert_flip_char and
tty_flip_buffer_push. They now take struct tty_port
as a parameter instead of tty_struct.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_fep5.c | 6 +++---
1 file changed, 3 insertion
This commit adds files hal/odm_RTL8188E.c, hal/odm_RegConfig8188E.c,
hal/rtl8188e_cmd.c, and hal/rtl8188e_dm.c.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 399 +++
drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 130
drivers/staging/rtl
This commit adds files os_dep/usb_intf.c, os_dep/usb_ops_linux.c,
and os_dep/xmit_linux.c.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 892 +++
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 288
drivers/staging/rtl8188eu/os
This commit adds files hal/rtl8188e_rxdesc.c, hal/rtl8188e_sreset.c, and
hal/rtl8188e_xmit.c.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 202
drivers/staging/rtl8188eu/hal/rtl8188e_sreset.c | 80 ++
drivers/staging/rtl8188e
Initially, the only Linux driver for the RTL8188EU chips incorporated
in devices such as the TP-Link TL-WN725N was one sent to me privately
by the Realtek engineers with permission to submit it to the Linux kernel.
Not only did it have limited availability, this version fails to build on
kernels 3.
This commit adds files include/autoconf.h, include/basic_types.h,
include/cmd_osdep.h, include/drv_types.h, include/drv_types_linux.h,
include/ethernet.h. include/h2clbk.h, include/hal_com.h, and include/hal_intf.h.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/autoconf.h
This commit adds files include/rtw_ht.h, include/rtw_io.h,
include/rtw_ioctl.h, include/rtw_ioctl_rtl.h, include/rtw_ioctl_set.h,
include/rtw_iol.h, and include/rtw_led.h.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/rtw_ht.h| 44 +++
drivers/staging/rtl8188eu/inclu
This commit adds files include/rtw_p2p.h, include/rtw_pwrctrl.h,
include/rtw_qos.h, include/rtw_recv.h, and include/rtw_rf.h.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/rtw_p2p.h | 135 +++
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 283 ++
drive
This commit adds files include/rtw_security.h, include/rtw_sreset.h,
include/rtw_version.h, and include/rtw_xmit.h.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/rtw_security.h | 383 ++
drivers/staging/rtl8188eu/include/rtw_sreset.h | 50 +++
drivers/s
This commit adds files include/rtw_android.h, include/rtw_ap.h,
include/rtw_br_ext.h, include/rtw_cmd.h, include/rtw_debug.h,
include/rtw_eeprom.h, include/rtw_efuse.h, and include/rtw_event.h.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/include/rtw_android.h | 64 ++
drivers/stag
This commit adds files os_dep/os_intfs.c, os_dep/recv_linux.c,
and os_dep/rtw_android.c.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c| 1251
drivers/staging/rtl8188eu/os_dep/recv_linux.c | 261 +
drivers/staging/rtl8188eu/os_dep/r
This commit adds files hal/HalHWImg8188E_BB.c, hal/HalHWImg8188E_MAC.c,
hal/HalHWImg8188E_RF.c, and
hal/hal_com.c.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/HalHWImg8188E_BB.c | 721 ++
drivers/staging/rtl8188eu/hal/HalHWImg8188E_MAC.c | 231 +++
dri
The configuration options include those to add code needed for
AP mode, and peer-to-peer mode.
Signed-off-by: Larry Finger
---
drivers/staging/Kconfig | 2 ++
drivers/staging/rtl8188eu/Kconfig | 29 +
2 files changed, 31 insertions(+)
create mode 100644 dr
This commit adds files hal/rtl8188eu_led.c, hal/rtl8188eu_recv.c,
and hal/rtl8188eu_xmit.c.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/rtl8188eu_led.c | 111
drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 138 +
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 706
This commit modifies drivers/staging/Makefile, and adds the
drivers/staging/rtl8188eu/Makefile.
Signed-off-by: Larry Finger
---
drivers/staging/Makefile | 1 +
drivers/staging/rtl8188eu/Makefile | 70 ++
drivers/staging/rtl8188eu/TODO | 15 +
This commit adds files odm_HWConfig.c and odm_interface.c.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/hal/odm_HWConfig.c | 596 ++
drivers/staging/rtl8188eu/hal/odm_interface.c | 203 +
2 files changed, 799 insertions(+)
create mode 100644 drivers
This patch fixes errors with the tty function calls
tty_buffer_request_room, tty_insert_flip_string_flags,
tty_insert_flip_string and tty_flip_buffer_push.
They now take struct tty_port as a parameter instead
of tty_struct.
Signed-off-by: Lidza Louina
---
drivers/staging/dgap/dgap_tty.c | 10 ++
65 matches
Mail list logo
