RE: [PATCH v2 0/4] staging: comedi: tidy up dio subdevice (*insn_config) boilerplate

2013-08-14 Thread H Hartley Sweeten
On Monday, August 12, 2013 3:18 PM, Greg Kroah-Hartman wrote: > On Tue, Aug 06, 2013 at 09:30:33AM -0700, H Hartley Sweeten wrote: >> All the comedi drivers that have DIO subdevices implement a (*insn_config) >> callback. This callback always handles the INSN_CONFIG_DIO_{INPUT,OUTPUT} >> instructio

Re: [PATCH v2 0/4] staging: comedi: tidy up dio subdevice (*insn_config) boilerplate

2013-08-14 Thread Greg Kroah-Hartman
On Wed, Aug 14, 2013 at 01:19:23PM -0500, H Hartley Sweeten wrote: > On Monday, August 12, 2013 3:18 PM, Greg Kroah-Hartman wrote: > > On Tue, Aug 06, 2013 at 09:30:33AM -0700, H Hartley Sweeten wrote: > >> All the comedi drivers that have DIO subdevices implement a (*insn_config) > >> callback. Th

Re: [PATCH 2/8] staging: dgnc: removes proc code

2013-08-14 Thread Greg KH
On Tue, Aug 13, 2013 at 03:49:52PM -0400, Lidza Louina wrote: > This patch removes the dgnc_proc.c file, all references to proc functions in > dgnc_driver.c and from the Makefile's build. > > There were a lot of issues with the proc code so I removed it to make sure it > builds. I'll work on the

Re: [PATCH 8/8] staging: dgnc: removes read_cnt, real_raw, rawreadok and buf

2013-08-14 Thread Greg KH
On Wed, Aug 14, 2013 at 02:27:58AM +0300, Dan Carpenter wrote: > On Tue, Aug 13, 2013 at 03:49:58PM -0400, Lidza Louina wrote: > > This patch removes the use of read_cnt, real_raw, buf and rawreadok. The > > variable buf is never used in the code. The variables rawreadok read_cnt > > and real_raw

Re: [PATCH v2] staging: gdm7240: a TTY rewrite according to the latest TTY APIs

2013-08-14 Thread Greg KH
On Tue, Aug 13, 2013 at 07:46:01PM +0900, Won Kang wrote: > Removed the old style reference countings and termios. > Renamed variables to meaninful ones. > > Fixed mis-use of mutex for gdm_table. gdm_table is refered to only > inside tty_install and port destrcut, and usb callbacks use internal >

Re: [PATCH 07/10] staging: ozwpan: Make oz_hcd_pd_departed() take a struct pointer.

2013-08-14 Thread Dan Carpenter
On Tue, Aug 13, 2013 at 09:46:36PM +0400, Sergei Shtylyov wrote: > > >> Do you really need a copy? Isn't it better to rename the parameter and > >>remove this line altogether? > > >>WBR, Sergei > > >Yes, that is the idea, for next patch series, as I don't want to mix two > >changes in single

Re: [PATCH 2/8] staging: dgnc: removes proc code

2013-08-14 Thread Lidza Louina
On Wed, Aug 14, 2013 at 5:04 PM, Greg KH wrote: > On Tue, Aug 13, 2013 at 03:49:52PM -0400, Lidza Louina wrote: >> This patch removes the dgnc_proc.c file, all references to proc functions in >> dgnc_driver.c and from the Makefile's build. >> >> There were a lot of issues with the proc code so I

[PATCH v2] staging: dgnc: removes proc code

2013-08-14 Thread Lidza Louina
This patch removes the dgnc_proc.c file, all references to proc functions in dgnc_driver.c and from the Makefile's build. Drivers now use sysfs instead of proc. Signed-off-by: Lidza Louina --- drivers/staging/dgnc/Makefile | 2 +- drivers/staging/dgnc/dgnc_driver.c | 9 - 2 files c

Re: [PATCH v2] staging: dgnc: removes proc code

2013-08-14 Thread Greg KH
On Wed, Aug 14, 2013 at 07:01:49PM -0400, Lidza Louina wrote: > This patch removes the dgnc_proc.c file, all references to proc > functions in dgnc_driver.c and from the Makefile's build. > > Drivers now use sysfs instead of proc. > > Signed-off-by: Lidza Louina > --- > drivers/staging/dgnc/Mak

Re: [PATCH v2] staging: dgnc: removes proc code

2013-08-14 Thread Lidza Louina
On Wed, Aug 14, 2013 at 7:04 PM, Greg KH wrote: > On Wed, Aug 14, 2013 at 07:01:49PM -0400, Lidza Louina wrote: >> This patch removes the dgnc_proc.c file, all references to proc >> functions in dgnc_driver.c and from the Makefile's build. >> >> Drivers now use sysfs instead of proc. >> >> Signed-

Re: [PATCH v3] staging: dgnc: removes proc code

2013-08-14 Thread Greg KH
On Wed, Aug 14, 2013 at 08:49:24PM -0400, Lidza Louina wrote: > This patch removes the dgnc_proc.c and dgnc_proc.h files and all > references to proc functions in dgnc_driver.c. This also removes proc.h > from the include headers in driver.c, mgmt.c and sysfs.c and proc.o > from the Makefile. > >