[PATCH] staging: gdm7240: a TTY rewrite according to the latest TTY APIs

2013-08-09 Thread Won Kang
Removed the old style reference countings and termios. Renamed variables to meaninful ones. Signed-off-by: Won Kang --- drivers/staging/gdm724x/gdm_tty.c | 294 ++--- drivers/staging/gdm724x/gdm_tty.h |5 +- 2 files changed, 142 insertions(+), 157 deletions(-

Re: [PATCH] staging: gdm7240: a TTY rewrite according to the latest TTY APIs

2013-08-09 Thread Dan Carpenter
Whenever I see "rewrite" in the subject, my first reaction is to start typing, "Please break this big patch up into a series of small patches". In this case, I guess it's hard to do that so you're ok. I do wish you had put the variable renaming into a separate patch though. On Fri, Aug 09, 2013 a

Re: [PATCH] Staging: rtl8192e: rtllib_rx: checking NULL value after doing dev_alloc_skb

2013-08-09 Thread Dan Carpenter
On Thu, Aug 08, 2013 at 12:56:44PM +0200, Iker Pedrosa wrote: > Checking the return of dev_alloc_skb as stated in the following > bug: https://bugzilla.kernel.org/show_bug.cgi?id=60401 > Using bugzilla to report these sorts of bugs is a bit awkward. Normally we would try to give credit for bug re

[patch] staging: cxt1e1: Remove #define SBE_INCLUDE_SYMBOLS

2013-08-09 Thread Shaun Laing
Removed the unneeded SBE_INCLUDE_SYMBOLS #define, and the associated STATIC #define, and replaced all occurances of STATIC with 'static'. This was in response to sparse warnings of the form "symbol 'XYZ' was not declared. Should it be static?". Removed a function prototype (musycc_init_port) as

[GIT PATCH] Staging driver fixes for 3.11-rc5

2013-08-09 Thread Greg KH
The following changes since commit 5ae90d8e467e625e447000cb4335c4db973b1095: Linux 3.11-rc3 (2013-07-28 20:53:33 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.11-rc5 for you to fetch changes up to cefe8a32f2a