On Fri 2013-08-02 13:37:56, Iker Pedrosa wrote:
> Fixed some coding style issues
>
> Signed-off-by: Iker Pedrosa
Reviewed-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
___
This patch replace some magic numbers. I believe it makes
the driver more readable.
The magic number 0x26 is the XO system embedded controller
(EC) command 'DCON power enable/disable'.
Number 0x41, and 0x42 are special memory controller settings
register. The 0x41 initialize bit sequence 0x101 m
The TODO entry - drop global variables, use a proper olpc_dcon_priv
struct - is already finished. The driver has no global variables.
It uses the private structure 'dcon_priv'.
Signed-off-by: Jens Frederich
diff --git a/drivers/staging/olpc_dcon/TODO b/drivers/staging/olpc_dcon/TODO
index f378e8
Please Cc Daniel on these. Cjb and myself are no longer at olpc.
On Sat, 3 Aug 2013 22:44:35 +0200
Jens Frederich wrote:
> This patch replace some magic numbers. I believe it makes
> the driver more readable.
>
> The magic number 0x26 is the XO system embedded controller
> (EC) command 'DC
On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon wrote:
> Please Cc Daniel on these. Cjb and myself are no longer at olpc.
>
Sorry, I've forgotten it. I will update the the TODO list.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.l
On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon wrote:
> Please Cc Daniel on these. Cjb and myself are no longer at olpc.
>
Do you know what's with Jon Nettleton? He is also on the TODO list?
___
devel mailing list
de...@linuxdriverproject.org
http://d
On Sat, 3 Aug 2013 23:36:15 +0200
Jens Frederich wrote:
> On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon
> wrote:
> > Please Cc Daniel on these. Cjb and myself are no longer at olpc.
> >
>
> Do you know what's with Jon Nettleton? He is also on the TODO list?
Let's ask. Jon, do you still wan
On Sat, Aug 03, 2013 at 10:44:35PM +0200, Jens Frederich wrote:
> @@ -126,7 +127,7 @@ static int dcon_bus_stabilize(struct dcon_priv *dcon, int
> is_powered_down)
> power_up:
> if (is_powered_down) {
> x = 1;
> - x = olpc_ec_cmd(0x26, (unsigned char *)&x, 1, NULL,
On Sat, Aug 03, 2013 at 02:38:45PM -0700, Andres Salomon wrote:
> On Sat, 3 Aug 2013 23:36:15 +0200
> Jens Frederich wrote:
>
> > On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon
> > wrote:
> > > Please Cc Daniel on these. Cjb and myself are no longer at olpc.
> > >
> >
> > Do you know what's w
