version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
.../lustre/include/linux/libcfs/linux/linux-cpu.h |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/linux/linux-cpu.h
b/drivers/staging/lus
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/mdc/lproc_mdc.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/mdc/lproc_mdc.c
b/drivers/staging/lustre/lustre/mdc/lproc_md
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
.../lustre/lustre/include/linux/lustre_user.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/linux/lustre_user.h
b/drivers/staging/lustre/lu
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
.../lustre/lustre/include/linux/lustre_handles.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/linux/lustre_handles.h
b/drivers/staging/lustre
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
.../lustre/lustre/include/linux/lustre_quota.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/linux/lustre_quota.h
b/drivers/staging/lustre/l
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
.../lustre/include/linux/libcfs/linux/linux-prim.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/linux/linux-prim.h
b/drivers/staging/lust
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/llite/lproc_llite.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c
b/drivers/staging/lustre/lustre/llit
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/lvfs/lvfs_linux.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lvfs/lvfs_linux.c
b/drivers/staging/lustre/lustre/lvfs/l
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/lmv/lproc_lmv.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lmv/lproc_lmv.c
b/drivers/staging/lustre/lustre/lmv/lproc_lm
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
.../lustre/lustre/include/linux/lprocfs_status.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/linux/lprocfs_status.h
b/drivers/staging/lustre
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
.../lustre/lustre/include/linux/lustre_lite.h |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/linux/lustre_lite.h
b/drivers/staging/lustre/
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
.../lustre/include/linux/libcfs/linux/linux-time.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/linux/linux-time.h
b/drivers/staging/lust
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/llite/llite_mmap.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/llite_mmap.c
b/drivers/staging/lustre/lustre/llite/
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/llite/llite_capa.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c
b/drivers/staging/lustre/lustre/llite/
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
.../lustre/lustre/include/linux/lustre_net.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/linux/lustre_net.h
b/drivers/staging/lustre/lus
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
.../lustre/include/linux/libcfs/linux/kp30.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/linux/kp30.h
b/drivers/staging/lustre/inc
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/llite/llite_lib.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c
b/drivers/staging/lustre/lustre/llite/ll
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/llite/symlink.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/symlink.c
b/drivers/staging/lustre/lustre/llite/symlin
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/llite/remote_perm.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/remote_perm.c
b/drivers/staging/lustre/lustre/llit
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/mgc/lproc_mgc.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/mgc/lproc_mgc.c
b/drivers/staging/lustre/lustre/mgc/lproc_mg
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
.../lustre/lustre/obdclass/linux/linux-sysctl.c|1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
b/drivers/staging/lustre/
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/lvfs/fsfilt_ext3.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lvfs/fsfilt_ext3.c
b/drivers/staging/lustre/lustre/lvfs/f
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/osc/lproc_osc.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c
b/drivers/staging/lustre/lustre/osc/lproc_os
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/lov/lproc_lov.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lov/lproc_lov.c
b/drivers/staging/lustre/lustre/lov/lproc_lo
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/obdclass/capa.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/capa.c
b/drivers/staging/lustre/lustre/obdclass/cap
version.h header inclusion is not necessary as detected by
versioncheck.
Signed-off-by: Sachin Kamat
---
drivers/staging/lustre/lustre/obdclass/obd_mount.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/obd_mount.c
b/drivers/staging/lustre/lustre/ob
On Wed, Jul 24, 2013 at 02:34:08PM +0900, Jingoo Han wrote:
> The usage of strict_strtol() is not preferred, because
> strict_strtol() is obsolete. Thus, kstrtos32() should be
> used in order to convert a string to s32. Also, error handling
> is added to get rid of a __must_check warning.
Also you
On Wednesday, July 24, 2013 4:09 PM, Dan Carpenter wrote:
> On Wed, Jul 24, 2013 at 02:34:08PM +0900, Jingoo Han wrote:
> > The usage of strict_strtol() is not preferred, because
> > strict_strtol() is obsolete. Thus, kstrtos32() should be
> > used in order to convert a string to s32. Also, error h
Looks great.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Dan,
Thanks, I am fixing the codes now. I plan to send v2 soon. However,
most of them are syntactic and style issues, not logical ones.
Probably they are due to the proprietary protocols being used between
the device and the host, and I do not have enough information to fix
those. I will have t
I have posted a similar fix quite some time ago and I guess Greg should
already have it.
Greg?
On Fri 19-07-13 16:46:41, Piotr Sarna wrote:
> Commit 835f2f5 ("staging: zcache: enable zcache to be built/loaded as
> a module") introduced an incorrect handling of "zcache=" parameter.
>
> Inside zca
On Wed 24-07-13 12:02:35, Michal Hocko wrote:
> I have posted a similar fix quite some time ago and I guess Greg should
> already have it.
For reference https://lkml.org/lkml/2013/6/26/410
> Greg?
>
> On Fri 19-07-13 16:46:41, Piotr Sarna wrote:
> > Commit 835f2f5 ("staging: zcache: enable zcac
Hi,
On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote:
> On Wed 24-07-13 12:02:35, Michal Hocko wrote:
> > I have posted a similar fix quite some time ago and I guess Greg should
> > already have it.
>
> For reference https://lkml.org/lkml/2013/6/26/410
There was a reply from Greg:
Hey Paul,
> > > diff --git a/drivers/staging/dwc2/core.h b/drivers/staging/dwc2/core.h
> > > index fc075a7..e771e40 100644
> > > --- a/drivers/staging/dwc2/core.h
> > > +++ b/drivers/staging/dwc2/core.h
> > > @@ -150,10 +150,11 @@ enum dwc2_lx_state {
> > > * are enabled
> >
Hey Paul,
one more thing:
> > > > + * -1 - GAHBCFG value will not be
> > > > overridden
This seems incorrect: If it is set to -1, GAHBCFG will be set to 0x06
(INCR4), it is not left unchanged. I'll also include this in my
documentation patch.
Gr.
Matthijs
___
On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote:
> > On Wed 24-07-13 12:02:35, Michal Hocko wrote:
> > > I have posted a similar fix quite some time ago and I guess Greg should
> > > already have it.
> >
> > For re
On Wednesday, July 24, 2013 01:41:57 PM Michal Hocko wrote:
> On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote:
> >
> > Hi,
> >
> > On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote:
> > > On Wed 24-07-13 12:02:35, Michal Hocko wrote:
> > > > I have posted a similar fix quite s
Hello Greg,
that's my second try to check the list.
thanks,
Jens
On Sat, Jul 20, 2013 at 10:47 PM, Greg KH wrote:
> The mailing list seems to be dead again, is anyone succeeding on sending
> any mail through it?
>
> thanks,
>
> greg k-h
> ___
> devel
This patch fixes coding style issues reported by Dan here:-
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2012-June/027767.html
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git
On Wed, Jul 24, 2013 at 01:54:56PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> On Wednesday, July 24, 2013 01:41:57 PM Michal Hocko wrote:
> > On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote:
> > >
> > > Hi,
> > >
> > > On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote:
> > >
On Wed, Jul 24, 2013 at 01:54:56PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> On Wednesday, July 24, 2013 01:41:57 PM Michal Hocko wrote:
> > On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote:
> > >
> > > Hi,
> > >
> > > On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote:
> > >
This patch updates the list of maintainers for the staging/comedi
driver.
Signed-off-by: Lidza Louina
---
MAINTAINERS | 2 +-
drivers/staging/comedi/TODO | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index bf61e04..6ddb33d 100644
On Wednesday, July 24, 2013 08:06:27 AM Greg KH wrote:
> On Wed, Jul 24, 2013 at 01:54:56PM +0200, Bartlomiej Zolnierkiewicz wrote:
> >
> > On Wednesday, July 24, 2013 01:41:57 PM Michal Hocko wrote:
> > > On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote:
> > > >
> > > > Hi,
> > > >
>
On Wednesday, July 24, 2013 05:39:20 PM Bartlomiej Zolnierkiewicz wrote:
>
> On Wednesday, July 24, 2013 08:06:27 AM Greg KH wrote:
> > On Wed, Jul 24, 2013 at 01:54:56PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > >
> > > On Wednesday, July 24, 2013 01:41:57 PM Michal Hocko wrote:
> > > > On We
On Wednesday, July 24, 2013 8:30 AM, Lidza Louina wrote:
> This patch updates the list of maintainers for the staging/comedi
> driver.
>
> Signed-off-by: Lidza Louina
> ---
> MAINTAINERS | 2 +-
> drivers/staging/comedi/TODO | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(
On 2013-07-24 17:01, H Hartley Sweeten wrote:
On Wednesday, July 24, 2013 8:30 AM, Lidza Louina wrote:
This patch updates the list of maintainers for the staging/comedi
driver.
Signed-off-by: Lidza Louina
---
MAINTAINERS | 2 +-
drivers/staging/comedi/TODO | 2 +-
2 files c
On Wed, Jul 24, 2013 at 05:45:34PM +0900, Won Kang wrote:
> Hi Dan,
>
> Thanks, I am fixing the codes now. I plan to send v2 soon. However,
> most of them are syntactic and style issues, not logical ones.
> Probably they are due to the proprietary protocols being used between
> the device and the
On 07/23/2013 10:21 AM, KY Srinivasan wrote:
>> You have allocated some large, physically contiguous areas of memory
>> under heavy pressure. But you also contend that there is too much
>> memory pressure to run a small userspace helper. Under heavy memory
>> pressure, I'd expect large, kernel al
On Wed, Jul 24, 2013 at 05:50:29PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> On Wednesday, July 24, 2013 05:39:20 PM Bartlomiej Zolnierkiewicz wrote:
> >
> > On Wednesday, July 24, 2013 08:06:27 AM Greg KH wrote:
> > > On Wed, Jul 24, 2013 at 01:54:56PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
The only difference in the if() and else if() check of the chanlist
is the source of the range table length. Consolidate the checks to
make the function a bit more concise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
v2: fix an issue when the range_table_list is u
The clean up of the global includes in comedidev.h missed adding a
couple includes to some of the comedi drivers. This series fixes
the build errors reported by the kbuild test robot.
H Hartley Sweeten (2):
staging: comedi: ni_mio_common: needs
staging: comedi: comedi_buf: needs
drivers/st
As reported by the kbuild test robot:
Commit: d92fef8d2552ffde42b6092cb467f3021ebf8b98
staging: comedi: do not include if its not needed
Removed the include from the ni_atmio driver, which did not need it.
Unfortunately, this driver includes ni_mio_common.c, which does need
it.
Add the include
As reported by the kbuild test robot:
Commit: ce157f8032bbd46d9427034c335b0afd751da25d
staging: comedi: con't rely on comedidev.h to include headers
Removed most the includes from comedidev.h and pushed only the needed
ones to all the comedi drivers.
This one was missed.
Signed-off-by: H Hartle
From: Piotr Sarna
Subject: [PATCH] zcache: fix "zcache=" kernel parameter
Commit 835f2f5 ("staging: zcache: enable zcache to be built/loaded as
a module") introduced an incorrect handling of "zcache=" parameter.
Inside zcache_comp_init() function, zcache_comp_name variable is
checked for being e
All the AO channels have the same ranges. Remove the subdevice
s->range_table_list and just use the s->range_table to setup the
ranges.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1724.c | 6 +-
1 file changed, 1 insertio
On Wed, Jul 24, 2013 at 07:04:14PM +0200, Bartlomiej Zolnierkiewicz wrote:
> From: Piotr Sarna
> Subject: [PATCH] zcache: fix "zcache=" kernel parameter
What's with the duplicated Subject: line here? Why? That means the
From: line there will probably not get recognized by git (well, it
might),
This driver is a great example of "bad kernel code"...
It greatly abuses the comedi API and will not work without patching
the comedi core. It's CodingStyle is terrible. It uses floating point
math. And, it's almost impossible to read.
A Kconfig option to enable this driver isn't even available.
Fix a couple comments within comments errors.
Remove the #include of eddi_eeprom.c. This driver does not use it.
Remove an unused local variable.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/APCI1710_82x54.c | 2 +-
driv
Move the necessary bits from addi_common.h to remove it's dependency
and make this driver standalone.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_1710.c | 142 +++-
1 file changed, 141 insertions(+), 1
Now that the addi_apci_1710 driver has been removed, get rid of all the
unnecessary stuff in addi_common.h.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/addi_common.h | 169 -
1 file changed, 169 deletions(-
Embedded systems with a PC/104 bus might have a configuration that
does not have ISA enabled. This creates a problem in Comedi where
the PC/104 drivers cannot be enabled.
Introduce a Kconfig option to allow enabling the Comedi ISA and
PC/104 drivers if ISA is disabled.
Signed-off-by: H Hartley Sw
On Thu, 2013-07-25 at 03:36 +0900, Won Kang wrote:
> GCT Semiconductor GDM7240 is 4G LTE chip.
> This driver supports GCT reference platform as a USB device.
>
> Signed-off-by: Won Kang
>
> staging: gdm7240: added contacts for code maintanance
>
> Signed-off-by: Won Kang
>
> staging: gdm7240:
Tidy up the interrupt support and the private data usage. Do a bit
of additional cleanup to clarify the driver a bit.
H Hartley Sweeten (13):
staging: comedi: pcmuio: fix interrupt requests
staging: comedi: pcmuio: spinlock pcmuio_{write,read}()
staging: comedi: pcmuio: tidy up pcmuio_handle
Legacy (ISA) interrupts are not sharable so this driver should not
be passing the IRQF_SHARED flag when requesting the interrupts.
This driver supports two board types:
PCM-UIO48 with one asic (one interrupt source)
PCM-UIO96 with two asics (two interrupt sources)
The PCM-UIO96 has a jumper t
The 'asic' associated with a subdevice can be easily calculated. The
only functions that use this member in the subdevice private data can
only be called by the subdevices that support interrupts. Just
calculate the 'asic' and remove the member variable and the sanity
checks.
Signed-off-by: H Hart
The interrupt subdevice associated with the 'asic' can be easily
calculated. Remove the for() loop that searched for it and tidy
up the function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcmuio.c | 43 +++-
Currently only the pcmuio_handle_asic_interrupt() function uses the
spinlock in the private data to protect the read of the paged interrupt
id registers. All accesses to the paged registers should be protected
to ensure that the page is not changed until the access is complete.
Move the lock/unlock
The subdevice private data is only needed for each 'asic' not for each
subdevice. Since the 'asic' can be calculated easily from the subdevice
we can merge the subdevice private data members directly into the
private data.
This removes the need to kcalloc/free the subdevice private data and
saves
The comedi_subdevice pointer is not used in this function. Its simply
passed on to pcmuio_handle_intr_subdev(). That function then needs to
calculate the 'asic' associated with the subdevice. Just pass on the
'asic' instead and let pcmuio_handle_intr_subdev() get the subdevice
from that.
Signed-of
When updating the output channels make sure the channels configured as
inputs stay inputs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcmuio.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/stagi
The 'triggered' value is read directly from the three trigger id
registers and does not have any extra data that needs masked off.
Remove the 'mytrig' local variable and just use 'triggered' directly.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/co
Add a comment about what this spinlock is used for. Also, add
comments for two helper functions that do not need to lock/unlock
the spinlock.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcmuio.c | 4 +++-
1 file changed, 3 insertion
The 'enabled_mask' is a bit mask of the channels that are enabled
for interrupt detection and should be an unsigned int.
The 'stop_count' is a >= 0 value that is set by the unsigned int
cmd->stop_arg. Make it an unsigned int.
The 'active' and 'continuous' members are flags. Make them unsigned
int
The header is no longer needed by this driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcmuio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcmuio.c
b/drivers/staging/comedi/drivers/pcmuio
To reduce the potential for bugs, introduce a couple inline helper
functions to consolidate the calculations needed to get the 'iobase'
for a given asic and the 'asic' and 'port' associated with a given
subdevice.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drive
For aesthetics, tidy up a couple of the function declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcmuio.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/p
Hi Joe,
Got it. Thanks
Regards,
Won
원본 메시지
발신: Joe Perches
날짜: 2013/07/25 오전 3:42 (GMT+09:00)
수신: Won Kang
참조:
linux-ker...@vger.kernel.org,de...@driverdev.osuosl.org,gre...@linuxfoundation.org,Won
Kang
제목: Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver
On
Tidy up this legacy comedi driver.
H Hartley Sweeten (14):
staging: comedi: ii_pci20kc: use comedi_alloc_spriv()
staging: comedi: ii_pci20kc: remove forward declarations 1
staging: comedi: ii_pci20kc: remove forward declarations 2
staging: comedi: ii_pci20kc: remove forward declarations 3
Move the pci20xxx_attach() and pci20xxx_detach() functions to remove
the need for some of the forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ii_pci20kc.c | 184
1 file changed, 75 inse
For aesthetic reasons, use the helper function to allocate the
subdevice private data instead of hanging it on the device
private data. The core will free the memory during the detach.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ii_
Move a couple functions to remove the need for the last forward
declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ii_pci20kc.c | 135 +---
1 file changed, 62 insertions(+), 73 deletions(-)
diff --git
This macro is not used, and it looks to much like the comedi CR_CHAN
macro. Just remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ii_pci20kc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers
Move the pci20xxx_dio_*() functions to remove the need for some of
the forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ii_pci20kc.c | 190 +---
1 file changed, 88 insertions(+), 102 deletion
For aesthetic reasons, move the static const data to the head of
the file.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ii_pci20kc.c | 65 +++--
1 file changed, 34 insertions(+), 31 deletions(-)
diff --git a/
For asethetics, redefine the register map for the carrier board.
The 'PCI*' names lead one to think this is a PCI board not a
legacy ISA board.
Remove the #if 0'd out pci20xxx_{do,di}() functions. They are not
needed.
Rename, and fix, the pci20xxx_dio_config() function. The control
and direction
Use the carrier board id to determine if a module is installed for
a given subdevice.
Consolidate the module init code into ii20k_init_module().
For aesthetic reasons, rename the subdevice functions to remove
'pci' from them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartm
The 'iobase' can be calculated when needed. Remove it from the
subdevice private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ii_pci20kc.c | 58 +++--
1 file changed, 31 insertions(+), 27 deletions(-)
d
The PCI-20006M-1 and PCI-20006M-2 modules can both provide an
analog output subdevice in this driver. Fix the module init code
to detect both of them.
The analog output can support +/-5, 0-10, or +/-10 volt ranges
depending on jumpers on the board. Report all the ranges to the
user instead of rely
The union used for the subdevice private data just adds confusion.
Split the union into two separate private data structs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ii_pci20kc.c | 64 +++--
1 file changed,
The PCI-200341M-1 module can both provide an analog input subdevice
in this driver. The module provides four differential input channels
with four programmable gains.
Currently the gain is configured as an option passed when the board
is attached. Rewrite the ai subdevice support functions to prop
Make the built-on dio subdevice 0 and the three add-on modules
subdevices 1-3. This allows the driver to consistently use the
ii20k_module_iobase() helper to get the base address needed to
access a the registers used by a given subdevice.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg
Tidy up the multi-line comments at the beginning of the file and
remove any irrelevant information.
Fix the II20K_ID_PCI200341M_1 define, there are one to many 0's.
Rename all the remaining pci20xxx_* to ii20k_*. The "pci" just adds
confusion, this is not a PCI board.
Remove the private (*detach
As reported by the kbuild test robot:
Commit: 0bdab509bf9c6d838dc0a3b1d68bbf841fc20b5a
staging: comedi: usee comedi_alloc_devpriv
Removed the include of from many of the comedi drivers.
Unfortunately, this header uses kfree() in an inline function.
Instead of adding to each of the drivers that
> -Original Message-
> From: Dave Hansen [mailto:d...@sr71.net]
> Sent: Wednesday, July 24, 2013 12:43 PM
> To: KY Srinivasan
> Cc: Dave Hansen; Michal Hocko; gre...@linuxfoundation.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@canonical.com; a
The SDF_GROUND and SDF_COMMON flags only apply to analog subdevices.
It makes no sense to set these flags for digital subdevices.
Digital input (COMEDI_SUBD_DI) subdevices only need the SDF_READABLE
flag and optionally SDF_CMD_READ it the subdevice supports commands.
Digital output (COMEDI_SUBD_D
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Tuesday, July 23, 2013 2:59 PM
>
> On Wed, Jul 17, 2013 at 12:35:46PM -0700, Paul Zimmerman wrote:
> > The transfer scheduler in the dwc2 driver is pretty basic, not to
> > mention buggy. It works fairly well with just a couple of devices
On Thu, Jul 25, 2013 at 03:36:17AM +0900, Won Kang wrote:
> GCT Semiconductor GDM7240 is 4G LTE chip.
> This driver supports GCT reference platform as a USB device.
I've applied this now, and fixed up the tty build warnings (which you
should have also seen.) I'm not sure I got the tty fixes corre
Leverage the newly exported functionality to bring memory online
without involving user level code.
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hv_balloon.c | 20 +++-
1 files changed, 3 insertions(+), 17 deletions(-)
diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_bal
The current machinery for hot-adding memory requires having user
level to bring the memory segments online. Export the necessary functionality
to bring the memory segment online without involving user space code.
Signed-off-by: K. Y. Srinivasan
---
drivers/base/memory.c | 35 +
On 07/24/2013 12:45 PM, KY Srinivasan wrote:
> All I am saying is that I see two classes of failures: (a) Our
> inability to allocate memory to manage the memory that is being hot added
> and (b) Our inability to bring the hot added memory online within a reasonable
> amount of time. I am not sure
1 - 100 of 161 matches
Mail list logo