Re: staging: sm750fb: removed hungarian prfx and replace CamelCase variables

2017-05-24 Thread Tobin C. Harding
On Wed, May 24, 2017 at 01:24:14PM +0530, Richa Jha wrote: [snip] Nice work so far. I'm having trouble with your patches. Here are a few nitpicks to help you on your way. There are 4 emails in the last few days with similar subjects but they are not linked together. Also your email subject does n

staging: sm750fb: removed hungarian prfx and replace CamelCase variables

2017-05-24 Thread Richa Jha
Replace CamelCase variable names with underscores and remove hungarian prefixes to comply with the standard kernel coding style Signed-off-by: Richa Jha --- drivers/staging/sm750fb/ddk750_chip.c | 59 ++- drivers/staging/sm750fb/ddk750_chip.h | 18 +--

Re: staging: sm750fb: removed hungarian prfx and replace CamelCase variables

2017-05-23 Thread Tobin C. Harding
On Tue, May 23, 2017 at 06:37:39PM +0530, Richa Jha wrote: > Replace CamelCase variable names with underscores and remove > hungarian prefixes to comply with the standard kernel coding style Hi Richa, Nice work. You may like to do all the camel case at the same time. You could limit yourself to

staging: sm750fb: removed hungarian prfx and replace CamelCase variables

2017-05-23 Thread Richa Jha
Replace CamelCase variable names with underscores and remove hungarian prefixes to comply with the standard kernel coding style Signed-off-by: Richa Jha --- drivers/staging/sm750fb/ddk750_chip.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers