Re: staging: ks7010: Checkpatch fixes

2017-02-24 Thread Greg Kroah-Hartman
On Mon, Feb 20, 2017 at 04:45:05PM +1100, Tobin C. Harding wrote: > Checkpatch emits various messages. Struct ks_stdio_card contains a > spinlock. It is never used. The data structure contains two fields, > both of which are accessed in ways that don't seem to allow use of a > spinlock. I am not fu

staging: ks7010: Checkpatch fixes

2017-02-19 Thread Tobin C. Harding
Checkpatch emits various messages. Struct ks_stdio_card contains a spinlock. It is never used. The data structure contains two fields, both of which are accessed in ways that don't seem to allow use of a spinlock. I am not fully qualified however to analyse this. Spinlock is either not correctly u

[PATCH 0/9] staging: ks7010: Checkpatch fixes

2017-02-19 Thread Tobin C. Harding
Checkpatch emits numerous warnings and checks. Line over 80 warnings are not touched. Each patch addresses an individual checkpatch warning (or check). Code is refactored over a series of patches in an effort to modularize the changes. When a patch reduces the indentation no other changes are made