Re: staging: comedi: dt9812: Resolves sparse endian warnings.

2013-07-30 Thread Shaun Laing
Thank you. On Tue, Jul 30, 2013 at 11:13 AM, H Hartley Sweeten wrote: > On Tuesday, July 30, 2013 10:06 AM, Shaun Laing wrote: >> Ok, >> >> 1) I'm unclear as to the process at this point: should I re-send this patch >> with the suggested change? > > Yes. Please repost the patch with the prefix

RE: staging: comedi: dt9812: Resolves sparse endian warnings.

2013-07-30 Thread H Hartley Sweeten
On Tuesday, July 30, 2013 10:06 AM, Shaun Laing wrote: > Ok, > > 1) I'm unclear as to the process at this point:  should I re-send this patch > with the suggested change? Yes. Please repost the patch with the prefix changed to [PATCH v2]. Make sure to add Ian's Reviewed-by tag to the patch. You c

Re: staging: comedi: dt9812: Resolves sparse endian warnings.

2013-07-30 Thread Ian Abbott
On 2013/07/30 04:07 PM, Shaun Laing wrote: > Resolves warnings from the "sparse" checker of the form "warning: incorrect > type in assignment (different base types)". > > Signed-off-by: Shaun Laing Okay, but we have two patches with the same subject line (apart from the "[PATCH]" prefix missing

staging: comedi: dt9812: Resolves sparse endian warnings.

2013-07-30 Thread Shaun Laing
Resolves warnings from the "sparse" checker of the form "warning: incorrect type in assignment (different base types)". Signed-off-by: Shaun Laing --- diff --git a/drivers/staging/comedi/drivers/dt9812.c b/drivers/staging/comedi/drivers/dt9812.c index 6c60949..0bb2bd4 100644 --- a/drivers/stagin

Re: [patch] staging: comedi: dt9812: Resolves sparse endian warnings.

2013-07-29 Thread Shaun Laing
Ok, I'll send in this additional patch. On Mon, Jul 29, 2013 at 9:03 AM, Ian Abbott wrote: > On 2013-07-26 19:19, H Hartley Sweeten wrote: >> >> On Friday, July 26, 2013 10:59 AM, Shaun Laing wrote: >> >> Please make sure to copy the mailing list... ;-) >> >>> I'm sorry Hartley, >>> >>> I'm real

Re: [patch] staging: comedi: dt9812: Resolves sparse endian warnings.

2013-07-29 Thread Ian Abbott
On 2013-07-26 19:19, H Hartley Sweeten wrote: On Friday, July 26, 2013 10:59 AM, Shaun Laing wrote: Please make sure to copy the mailing list... ;-) I'm sorry Hartley, I'm really new at this so there's probably something I'm doing wrong. Do you have time to help me figure this out? Here's ho

RE: [patch] staging: comedi: dt9812: Resolves sparse endian warnings.

2013-07-26 Thread H Hartley Sweeten
On Friday, July 26, 2013 10:59 AM, Shaun Laing wrote: Please make sure to copy the mailing list... ;-) > I'm sorry Hartley, > > I'm really new at this so there's probably something I'm doing wrong. > Do you have time to help me figure this out? Here's how I'm building > this module: > > shaun@ri

RE: [patch] staging: comedi: dt9812: Resolves sparse endian warnings.

2013-07-26 Thread H Hartley Sweeten
On Friday, July 26, 2013 7:26 AM, Shaun Laing wrote: > > Resolves warnings from the "sparse" checker of the form "warning: cast to > restricted __le??". Hmm.. I don't see this sparse warning.. All I see for this file is: CHECK drivers/staging/comedi/drivers/dt9812.c CC [M] drivers/staging/

[patch] staging: comedi: dt9812: Resolves sparse endian warnings.

2013-07-26 Thread Shaun Laing
Resolves warnings from the "sparse" checker of the form "warning: cast to restricted __le??". Signed-off-by: Shaun Laing --- diff --git a/drivers/staging/comedi/drivers/dt9812.c b/drivers/staging/comedi/drivers/dt9812.c index 6c60949..fdd008c 100644 --- a/drivers/staging/comedi/drivers/dt9812.c