On Tue, Dec 06, 2016 at 02:10:13PM -0500, Oleg Drokin wrote:
>
> On Dec 6, 2016, at 1:37 PM, Dan Carpenter wrote:
>
> > On Tue, Dec 06, 2016 at 10:44:54AM -0500, Oleg Drokin wrote:
> >> I see, indeed, it all makes sense now.
> >> So basically if we unconditionally check for the size to be > 0, we
On Tue, Dec 06, 2016 at 02:10:13PM -0500, Oleg Drokin wrote:
>
> On Dec 6, 2016, at 1:37 PM, Dan Carpenter wrote:
>
> > On Tue, Dec 06, 2016 at 10:44:54AM -0500, Oleg Drokin wrote:
> >> I see, indeed, it all makes sense now.
> >> So basically if we unconditionally check for the size to be > 0, we
On Dec 6, 2016, at 1:37 PM, Dan Carpenter wrote:
> On Tue, Dec 06, 2016 at 10:44:54AM -0500, Oleg Drokin wrote:
>> I see, indeed, it all makes sense now.
>> So basically if we unconditionally check for the size to be > 0, we should be
>> fine then, I imagine.
>> On the other hand there's probably
On Tue, Dec 06, 2016 at 10:44:54AM -0500, Oleg Drokin wrote:
> I see, indeed, it all makes sense now.
> So basically if we unconditionally check for the size to be > 0, we should be
> fine then, I imagine.
> On the other hand there's probably no se for no param and nonzero param len,
> so it's prob
On Dec 6, 2016, at 6:02 AM, Dan Carpenter wrote:
> On Mon, Dec 05, 2016 at 06:43:37PM -0500, Oleg Drokin wrote:
>>
>> On Nov 23, 2016, at 7:29 AM, Dan Carpenter wrote:
>>
>>> Hi Lustre Devs,
>>>
>>> The patch d7e09d0397e8: "staging: add Lu
On Mon, Dec 05, 2016 at 06:43:37PM -0500, Oleg Drokin wrote:
>
> On Nov 23, 2016, at 7:29 AM, Dan Carpenter wrote:
>
> > Hi Lustre Devs,
> >
> > The patch d7e09d0397e8: "staging: add Lustre file system client
> > support" from May 2, 2013, leads
On Nov 23, 2016, at 7:29 AM, Dan Carpenter wrote:
> Hi Lustre Devs,
>
> The patch d7e09d0397e8: "staging: add Lustre file system client
> support" from May 2, 2013, leads to the following static checker
> warning:
>
> drivers/staging/lustre/lnet/selftest
Hi Lustre Devs,
The patch d7e09d0397e8: "staging: add Lustre file system client
support" from May 2, 2013, leads to the following static checker
warning:
drivers/staging/lustre/lnet/selftest/console.c:1336 lstcon_test_add()
error: 'paramlen' from user is not
On Apr 27, 2016, at 8:28 AM, Dan Carpenter wrote:
> Hello Lustre devs,
>
> The patch d7e09d0397e8: "staging: add Lustre file system client
> support" from May 2, 2013, leads to the following Parfait warning.
> Parfait is an Oracle static analysis tool. If there is a pa
> Hello Lustre devs,
>
> The patch d7e09d0397e8: "staging: add Lustre file system client
> support" from May 2, 2013, leads to the following Parfait warning.
> Parfait is an Oracle static analysis tool. If there is a patch from
> this could you give credit to Lidza L
Hello Lustre devs,
The patch d7e09d0397e8: "staging: add Lustre file system client
support" from May 2, 2013, leads to the following Parfait warning.
Parfait is an Oracle static analysis tool. If there is a patch from
this could you give credit to Lidza Louina ?
drivers/staging/lus
Hello Peng Tao,
The patch d7e09d0397e8: "staging: add Lustre file system client
support" from May 2, 2013, leads to the following static checker
warning:
drivers/staging/lustre/lustre/obdecho/echo_client.c:1040
cl_echo_enqueue0()
error: 'lck' dereferenc
On Thu, Oct 15, 2015 at 02:38:45PM +0300, Dan Carpenter wrote:
> Actually this we can't overflow here, it will return -EFAULT if param is
> NULL and paramlen is non-zero. I'll send a patch to clean this up.
Ugh... No, I won't send a patch for this. That LIBCFS_ALLOC() macro is
inscrutible and I
Actually this we can't overflow here, it will return -EFAULT if param is
NULL and paramlen is non-zero. I'll send a patch to clean this up.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.o
Hello Lustre Devs,
The patch d7e09d0397e8: "staging: add Lustre file system client
support" from May 2, 2013, leads to the following static checker
warning:
drivers/staging/lustre/lnet/selftest/console.c:1330 lstcon_test_add()
error: 'paramlen' from user is
Hello Lustre Devs,
The patch d7e09d0397e8: "staging: add Lustre file system client
support" from May 2, 2013, leads to the following static checker
warning:
drivers/staging/lustre/lustre/libcfs/kernel_user_comm.c:150
libcfs_kkuc_group_rem()
error: buffer overflow '
On Thu, Apr 24, 2014 at 02:51:15PM +0300, Dan Carpenter wrote:
> > >> if (libcfs_ioctl_is_invalid(data)) {
> > >>
> > >> Why do we even have all the "> (1<<30)" checks? I don't understand.
> > >> Anything over 1024 is invalid.
> > >>
> > I believe it is just a safe keeper. Anything that larg
On Thu, Apr 24, 2014 at 11:14:46AM +0800, Peng Tao wrote:
> Hi Dan,
>
> Thanks for reporting this.
>
> On Wed, Apr 23, 2014 at 10:13 PM, Dan Carpenter
> wrote:
> > Btw, what's the trick to navigating the lustre source? I normally do
> > a make cscope but that doesn't work and I am having a very
On Thu, Apr 24, 2014 at 05:55:21AM +, Drokin, Oleg wrote:
> Hello!
>
> On Apr 23, 2014, at 11:14 PM, Peng Tao wrote:
> >> Btw, what's the trick to navigating the lustre source? I normally do
> >> a make cscope but that doesn't work and I am having a very hard time
> >> with this code.
> >>
>
Hello!
On Apr 23, 2014, at 11:14 PM, Peng Tao wrote:
>> Btw, what's the trick to navigating the lustre source? I normally do
>> a make cscope but that doesn't work and I am having a very hard time
>> with this code.
>>
> I use cscope + ctags to navigate the lustre source. I guess you hit
> some
carpenter
>
> On Wed, Apr 23, 2014 at 04:54:26PM +0300, Dan Carpenter wrote:
>> Hello Peng Tao,
>>
>> The patch d7e09d0397e8: "staging: add Lustre file system client
>> support" from May 2, 2013, leads to the following static checker
>> warning:
&g
09d0397e8: "staging: add Lustre file system client
> support" from May 2, 2013, leads to the following static checker
> warning:
>
> drivers/staging/lustre/include//linux/libcfs/libcfs_ioctl.h:200
> libcfs_ioctl_is_invalid()
> error: buffer overflow 'da
Hello Peng Tao,
The patch d7e09d0397e8: "staging: add Lustre file system client
support" from May 2, 2013, leads to the following static checker
warning:
drivers/staging/lustre/include//linux/libcfs/libcfs_ioctl.h:200
libcfs_ioctl_is_invalid()
error: buffer over
23 matches
Mail list logo
