Re: [PATCH] staging: r8192e_pci driver broken 3.14+

2014-05-28 Thread Greg KH
The Subject: here is not really that descriptive, I've fixed it up when committing it. Try to be a bit better for your next patch. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/lis

[PATCH] r8192e_pci driver broken 3.14+

2014-05-28 Thread Sean MacLennan
A sparse error fixup removed a htons() which is required for the driver to function. This patch puts the htons() back and fixes the sparse warning correctly by changing the left side cast. Signed-off-by: Sean MacLennan --- diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl819

Re: r8192e_pci driver broken 3.14+

2014-05-22 Thread Greg KH
On Wed, May 21, 2014 at 10:39:43PM -0400, Sean MacLennan wrote: > On Sat, 19 Apr 2014 16:57:45 -0400 > Sean MacLennan wrote: > > > A sparse error fixup removed a htons() which is required for the > > driver to function. This patch puts the htons() back and fixes the > > sparse warning correctly b

Re: r8192e_pci driver broken 3.14+

2014-05-21 Thread Sean MacLennan
On Sat, 19 Apr 2014 16:57:45 -0400 Sean MacLennan wrote: > A sparse error fixup removed a htons() which is required for the > driver to function. This patch puts the htons() back and fixes the > sparse warning correctly by changing the left side cast. > > Signed-off-by: Sean MacLennan > --- > d

Re: [PATCH] r8192e_pci driver broken 3.14+

2014-05-05 Thread Jouke Witteveen
> A sparse error fixup removed a htons() which is required for the driver > to function. This patch puts the htons() back and fixes the sparse > warning correctly by changing the left side cast. > > Signed-off-by: Sean MacLennan I found that this patch is necessary and sufficient on my Samsung N5

[PATCH] r8192e_pci driver broken 3.14+

2014-04-19 Thread Sean MacLennan
A sparse error fixup removed a htons() which is required for the driver to function. This patch puts the htons() back and fixes the sparse warning correctly by changing the left side cast. Signed-off-by: Sean MacLennan --- diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl81

Re: r8192e_pci driver broken 3.14+

2014-04-19 Thread Greg KH
On Sat, Apr 19, 2014 at 03:10:04PM -0400, Sean MacLennan wrote: > On Sat, 19 Apr 2014 11:17:23 -0700 > Greg KH wrote: > > > On Sat, Apr 19, 2014 at 02:12:34PM -0400, Sean MacLennan wrote: > > > Fix a sparse error in the htons() call. htons() returns a __be16 > > > not a u16. > > > > > > Signed-o

Re: r8192e_pci driver broken 3.14+

2014-04-19 Thread Sean MacLennan
On Sat, 19 Apr 2014 11:17:23 -0700 Greg KH wrote: > On Sat, Apr 19, 2014 at 02:12:34PM -0400, Sean MacLennan wrote: > > Fix a sparse error in the htons() call. htons() returns a __be16 > > not a u16. > > > > Signed-off-by: Sean MacLennan > > --- > > You sent 2 patches, which should I apply? >

Re: r8192e_pci driver broken 3.14+

2014-04-19 Thread Greg KH
On Sat, Apr 19, 2014 at 02:12:34PM -0400, Sean MacLennan wrote: > Fix a sparse error in the htons() call. htons() returns a __be16 not a > u16. > > Signed-off-by: Sean MacLennan > --- You sent 2 patches, which should I apply? I've deleted both from my inbox, please resend the proper one, with a

Re: r8192e_pci driver broken 3.14+

2014-04-19 Thread Sean MacLennan
Fix a sparse error in the htons() call. htons() returns a __be16 not a u16. Signed-off-by: Sean MacLennan --- diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c index 3e79bff..b7dd153 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rt

Re: r8192e_pci driver broken 3.14+

2014-04-19 Thread Sean MacLennan
A sparse error fixup removed a htons() which is required for the driver to function. Put the htons() back. Signed-off-by: Sean MacLennan --- diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c index 11d0a9d..3e79bff 100644 --- a/drivers/staging/rtl8192e/rtlli

Re: r8192e_pci driver broken 3.14+

2014-04-18 Thread Dan Carpenter
On Fri, Apr 18, 2014 at 01:36:19PM -0400, Sean MacLennan wrote: > Commit 198e0d17c on November 2 by Rashika Kheria breaks the r8192e_pci > driver on my laptop. This patch went through the intern code review process and not the normal code review process. The changelog didn't justify why changing

Re: r8192e_pci driver broken 3.14+

2014-04-18 Thread Greg KH
On Fri, Apr 18, 2014 at 01:36:19PM -0400, Sean MacLennan wrote: > Commit 198e0d17c on November 2 by Rashika Kheria breaks the r8192e_pci > driver on my laptop. The bulk of the commit is fine. It is just the > following change that causes grief: > > diff --git a/drivers/staging/rtl8192e/rtllib_tx.c

r8192e_pci driver broken 3.14+

2014-04-18 Thread Sean MacLennan
Commit 198e0d17c on November 2 by Rashika Kheria breaks the r8192e_pci driver on my laptop. The bulk of the commit is fine. It is just the following change that causes grief: diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c index 3183627..7796488 100644 ---