Re: staging: add Lustre file system client support

2016-05-13 Thread Drokin, Oleg
On Apr 27, 2016, at 8:28 AM, Dan Carpenter wrote: > Hello Lustre devs, > > The patch d7e09d0397e8: "staging: add Lustre file system client > support" from May 2, 2013, leads to the following Parfait warning. > Parfait is an Oracle static analysis tool. If there is a patch from > this could you

re: staging: add Lustre file system client support

2016-05-11 Thread James Simmons
> Hello Lustre devs, > > The patch d7e09d0397e8: "staging: add Lustre file system client > support" from May 2, 2013, leads to the following Parfait warning. > Parfait is an Oracle static analysis tool. If there is a patch from > this could you give credit to Lidza Louina Just to let you know

re: staging: add Lustre file system client support

2016-04-27 Thread Dan Carpenter
Hello Lustre devs, The patch d7e09d0397e8: "staging: add Lustre file system client support" from May 2, 2013, leads to the following Parfait warning. Parfait is an Oracle static analysis tool. If there is a patch from this could you give credit to Lidza Louina ? drivers/staging/lustre/lustre/ldl

re: staging: add Lustre file system client support

2016-03-19 Thread Dan Carpenter
Hello Peng Tao, The patch d7e09d0397e8: "staging: add Lustre file system client support" from May 2, 2013, leads to the following static checker warning: drivers/staging/lustre/lustre/obdecho/echo_client.c:1040 cl_echo_enqueue0() error: 'lck' dereferencing possible ERR_PTR() dri

Re: staging: add Lustre file system client support

2015-10-15 Thread Dan Carpenter
On Thu, Oct 15, 2015 at 02:38:45PM +0300, Dan Carpenter wrote: > Actually this we can't overflow here, it will return -EFAULT if param is > NULL and paramlen is non-zero. I'll send a patch to clean this up. Ugh... No, I won't send a patch for this. That LIBCFS_ALLOC() macro is inscrutible and I

Re: staging: add Lustre file system client support

2015-10-15 Thread Dan Carpenter
Actually this we can't overflow here, it will return -EFAULT if param is NULL and paramlen is non-zero. I'll send a patch to clean this up. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.o

re: staging: add Lustre file system client support

2015-10-15 Thread Dan Carpenter
Hello Lustre Devs, The patch d7e09d0397e8: "staging: add Lustre file system client support" from May 2, 2013, leads to the following static checker warning: drivers/staging/lustre/lnet/selftest/console.c:1330 lstcon_test_add() error: 'paramlen' from user is not capped properly dr

re: staging: add Lustre file system client support

2015-10-15 Thread Dan Carpenter
Hello Lustre Devs, The patch d7e09d0397e8: "staging: add Lustre file system client support" from May 2, 2013, leads to the following static checker warning: drivers/staging/lustre/lustre/libcfs/kernel_user_comm.c:150 libcfs_kkuc_group_rem() error: buffer overflow 'kkuc_groups' 3

Re: staging: add Lustre file system client support

2014-04-24 Thread Dan Carpenter
On Thu, Apr 24, 2014 at 02:51:15PM +0300, Dan Carpenter wrote: > > >> if (libcfs_ioctl_is_invalid(data)) { > > >> > > >> Why do we even have all the "> (1<<30)" checks? I don't understand. > > >> Anything over 1024 is invalid. > > >> > > I believe it is just a safe keeper. Anything that larg

Re: staging: add Lustre file system client support

2014-04-24 Thread Dan Carpenter
On Thu, Apr 24, 2014 at 11:14:46AM +0800, Peng Tao wrote: > Hi Dan, > > Thanks for reporting this. > > On Wed, Apr 23, 2014 at 10:13 PM, Dan Carpenter > wrote: > > Btw, what's the trick to navigating the lustre source? I normally do > > a make cscope but that doesn't work and I am having a very

Re: staging: add Lustre file system client support

2014-04-24 Thread Dan Carpenter
On Thu, Apr 24, 2014 at 05:55:21AM +, Drokin, Oleg wrote: > Hello! > > On Apr 23, 2014, at 11:14 PM, Peng Tao wrote: > >> Btw, what's the trick to navigating the lustre source? I normally do > >> a make cscope but that doesn't work and I am having a very hard time > >> with this code. > >> >

Re: staging: add Lustre file system client support

2014-04-23 Thread Drokin, Oleg
Hello! On Apr 23, 2014, at 11:14 PM, Peng Tao wrote: >> Btw, what's the trick to navigating the lustre source? I normally do >> a make cscope but that doesn't work and I am having a very hard time >> with this code. >> > I use cscope + ctags to navigate the lustre source. I guess you hit > some

Re: staging: add Lustre file system client support

2014-04-23 Thread Peng Tao
Hi Dan, Thanks for reporting this. On Wed, Apr 23, 2014 at 10:13 PM, Dan Carpenter wrote: > Btw, what's the trick to navigating the lustre source? I normally do > a make cscope but that doesn't work and I am having a very hard time > with this code. > I use cscope + ctags to navigate the lustre

Re: staging: add Lustre file system client support

2014-04-23 Thread Dan Carpenter
Btw, what's the trick to navigating the lustre source? I normally do a make cscope but that doesn't work and I am having a very hard time with this code. regards, dan carpenter On Wed, Apr 23, 2014 at 04:54:26PM +0300, Dan Carpenter wrote: > Hello Peng Tao, > > The patch d7e09d0397e8: "staging:

re: staging: add Lustre file system client support

2014-04-23 Thread Dan Carpenter
Hello Peng Tao, The patch d7e09d0397e8: "staging: add Lustre file system client support" from May 2, 2013, leads to the following static checker warning: drivers/staging/lustre/include//linux/libcfs/libcfs_ioctl.h:200 libcfs_ioctl_is_invalid() error: buffer overflow 'data->ioc_bu