On 07/15, Kevin Folz wrote:
> Hello,
>
>
>
> I noticed you two have worked on the staging rtl8821ae driver.
>
>
>
> I wrote to the mailing list last month, but have yet to receive a
> response.
>
> http://permalink.gmane.org/gmane.linux.kernel.wireless.general/125235
>
>
>
>
> I downl
> Looks good. It would be best to submit the bugfixes first like where
> you add error checking for pci_map_single().
Yes, this is exactly what I started to do this morning :)
I'm preparing a patchseries where I extracting fixes or improvements
unrelated to rtl8187se, including pci_map_single fix
>
> Somehow I missed this patch. Do you know if John Linville picked it up?
>
AFAIK no..
> I'm not sure if the ANAPARAM3 register could handle a 16-bit write on an
> RTL8187B. To be cautious, I wrote and have tested the attached patch using a
> union. The patch includes a fix for an undefined sym
On 02/04/2014 01:57 PM, Andrea Merello wrote:
Sorry, my fault.. you had already reported me the iowrite16 vs
iowrite8 for anaparam3 issue, but I forgot to fix it :(
If you are reasonably sure that a 16bits-wide write is OK on the
rtl8187b hardware (In reference code I have here only 8bits are
wr
Sorry, my fault.. you had already reported me the iowrite16 vs
iowrite8 for anaparam3 issue, but I forgot to fix it :(
If you are reasonably sure that a 16bits-wide write is OK on the
rtl8187b hardware (In reference code I have here only 8bits are
written), then I agree applying your fix, and I wi
On Mon, Feb 3, 2014 at 6:22 PM, Andrea Merello wrote:
> Right now I have merged rtl8187se support in rtl8180 driver. But I must
> admit that I ever been in doubt about whether to produce a separate driver
> rather than going on merging.
If you've already merged them, and you think it works, keep
Andrea,
After applying the latest patch, I get the following warning and errors when
building the USB driver rtl8187:
CC drivers/video/fbmon.o
drivers/net/wireless/rtl818x/rtl8187/dev.c: In function ‘rtl8187_set_anaparam’:
drivers/net/wireless/rtl818x/rtl8187/dev.c:595:3: warning: passi
On 02/04/2014 08:41 AM, Andrea Merello wrote:
Yes, I attach a cumulative patch for latest version of my work.
When I will send this asking for merge in kernel, I will split it in
some patches, because I also also included fix and improvements for
other already supported cards (not directly relat
Nice. Thanks for doing that. Do you have some patches we could review
of the merged driver?
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Feb 03, 2014 at 11:05:42AM -0600, Larry Finger wrote:
> I am trying to improve the quality of this pile of , but I am only one
> person who was a life-long Fortran-coding scientist until I retired 15 years
> ago. Since then, I have been learning C and kernel-style coding practices.
>
On Mon, Feb 3, 2014 at 12:12 PM, Dan Carpenter wrote:
> On Mon, Feb 03, 2014 at 11:05:42AM -0600, Larry Finger wrote:
>> A combined driver would require very many branches based on chip
>> number and would certainly execute much more slowly.
>
> I seriously doubt there are performance issues with
On Mon, Feb 03, 2014 at 11:05:42AM -0600, Larry Finger wrote:
> A combined driver would require very many branches based on chip
> number and would certainly execute much more slowly.
I seriously doubt there are performance issues with merging the drivers.
regards,
dan carpenter
> >On Sunday 02 February 2014, Dave Jones wrote:
> >>The git logs are littered mostly with CodingStyle cleanups, sparse cleanups
> >>and such,
> >>meanwhile for five years they've had out of bounds reads, overflows, and
> >>such
> >>for this whole time.
Really, any sort of cleanup is good, thoug
On 02/02/2014 12:07 PM, Stefan Lippers-Hollmann wrote:
Hi
[ CC'ing the relevant parties ]
On Sunday 02 February 2014, Dave Jones wrote:
On Sun, Feb 02, 2014 at 03:41:27AM -0800, scan-ad...@coverity.com wrote:
>
> Please find the latest report on new defect(s) introduced to Linux found
wit
On Sun, 2014-02-02 at 18:07 +, Stefan Lippers-Hollmann wrote:
> Hi
>
> [ CC'ing the relevant parties ]
>
> On Sunday 02 February 2014, Dave Jones wrote:
> > On Sun, Feb 02, 2014 at 03:41:27AM -0800, scan-ad...@coverity.com wrote:
> > >
> > > Please find the latest report on new defect(s) i
Hi
[ CC'ing the relevant parties ]
On Sunday 02 February 2014, Dave Jones wrote:
> On Sun, Feb 02, 2014 at 03:41:27AM -0800, scan-ad...@coverity.com wrote:
> >
> > Please find the latest report on new defect(s) introduced to Linux found
> with Coverity Scan.
> >
> > Defect(s) Reported-by:
16 matches
Mail list logo
