On Wed, May 21, 2014 at 10:39:43PM -0400, Sean MacLennan wrote:
> On Sat, 19 Apr 2014 16:57:45 -0400
> Sean MacLennan wrote:
>
> > A sparse error fixup removed a htons() which is required for the
> > driver to function. This patch puts the htons() back and fixes the
> > sparse warning correctly b
On Sat, 19 Apr 2014 16:57:45 -0400
Sean MacLennan wrote:
> A sparse error fixup removed a htons() which is required for the
> driver to function. This patch puts the htons() back and fixes the
> sparse warning correctly by changing the left side cast.
>
> Signed-off-by: Sean MacLennan
> ---
> d
On Sat, Apr 19, 2014 at 03:10:04PM -0400, Sean MacLennan wrote:
> On Sat, 19 Apr 2014 11:17:23 -0700
> Greg KH wrote:
>
> > On Sat, Apr 19, 2014 at 02:12:34PM -0400, Sean MacLennan wrote:
> > > Fix a sparse error in the htons() call. htons() returns a __be16
> > > not a u16.
> > >
> > > Signed-o
On Sat, 19 Apr 2014 11:17:23 -0700
Greg KH wrote:
> On Sat, Apr 19, 2014 at 02:12:34PM -0400, Sean MacLennan wrote:
> > Fix a sparse error in the htons() call. htons() returns a __be16
> > not a u16.
> >
> > Signed-off-by: Sean MacLennan
> > ---
>
> You sent 2 patches, which should I apply?
>
On Sat, Apr 19, 2014 at 02:12:34PM -0400, Sean MacLennan wrote:
> Fix a sparse error in the htons() call. htons() returns a __be16 not a
> u16.
>
> Signed-off-by: Sean MacLennan
> ---
You sent 2 patches, which should I apply?
I've deleted both from my inbox, please resend the proper one, with a
Fix a sparse error in the htons() call. htons() returns a __be16 not a
u16.
Signed-off-by: Sean MacLennan
---
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c
b/drivers/staging/rtl8192e/rtllib_tx.c
index 3e79bff..b7dd153 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rt
A sparse error fixup removed a htons() which is required for the driver
to function. Put the htons() back.
Signed-off-by: Sean MacLennan
---
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c
b/drivers/staging/rtl8192e/rtllib_tx.c
index 11d0a9d..3e79bff 100644
--- a/drivers/staging/rtl8192e/rtlli
On Fri, Apr 18, 2014 at 01:36:19PM -0400, Sean MacLennan wrote:
> Commit 198e0d17c on November 2 by Rashika Kheria breaks the r8192e_pci
> driver on my laptop.
This patch went through the intern code review process and not the
normal code review process. The changelog didn't justify why changing
On Fri, Apr 18, 2014 at 01:36:19PM -0400, Sean MacLennan wrote:
> Commit 198e0d17c on November 2 by Rashika Kheria breaks the r8192e_pci
> driver on my laptop. The bulk of the commit is fine. It is just the
> following change that causes grief:
>
> diff --git a/drivers/staging/rtl8192e/rtllib_tx.c
