Re: lustre: question about lov_request.c

2015-06-08 Thread Drokin, Oleg
On Jun 8, 2015, at 3:24 AM, Julia Lawall wrote: >> You are right, set_pga seems to be a dead member. It was alive a once, but >> somehow not fully removed now, >> so it's safe to drop the whole if and also the struct member itself. >> set_oabufs could be dropped as well. > > Looking further,

Re: lustre: question about lov_request.c

2015-06-08 Thread Julia Lawall
> You are right, set_pga seems to be a dead member. It was alive a once, but > somehow not fully removed now, > so it's safe to drop the whole if and also the struct member itself. > set_oabufs could be dropped as well. Looking further, in the same function I also don't see any other uses o

Re: lustre: question about lov_request.c

2015-06-07 Thread Julia Lawall
On Sun, 7 Jun 2015, Drokin, Oleg wrote: > Hello! > > You are right, set_pga seems to be a dead member. It was alive a once, but > somehow not fully removed now, > so it's safe to drop the whole if and also the struct member itself. > set_oabufs could be dropped as well. Thanks. I will do

Re: lustre: question about lov_request.c

2015-06-07 Thread Drokin, Oleg
Hello! You are right, set_pga seems to be a dead member. It was alive a once, but somehow not fully removed now, so it's safe to drop the whole if and also the struct member itself. set_oabufs could be dropped as well. Thanks. Bye, Oleg On Jun 7, 2015, at 4:11 PM, Julia Lawall wrote