Re: [PATCH v1] add binder genl for txn report

2024-08-14 Thread kernel test robot
Hi Li, kernel test robot noticed the following build errors: [auto build test ERROR on staging/staging-testing] [also build test ERROR on staging/staging-next staging/staging-linus linus/master v6.11-rc3 next-20240814] [If your patch is applied to the wrong git tree, kindly drop us a note. And w

Re: [PATCH v1] add binder genl for txn report

2024-08-14 Thread kernel test robot
Hi Li, kernel test robot noticed the following build errors: [auto build test ERROR on staging/staging-testing] [also build test ERROR on staging/staging-next staging/staging-linus linus/master v6.11-rc3 next-20240814] [If your patch is applied to the wrong git tree, kindly drop us a note. And w

Re: [PATCH v1] add binder genl for txn report

2024-08-12 Thread Greg KH
On Mon, Aug 12, 2024 at 11:16:27PM -0700, Li Li wrote: > On Mon, Aug 12, 2024 at 10:13 PM Greg KH wrote: > > > > On Mon, Aug 12, 2024 at 02:18:44PM -0700, Li Li wrote: > > > From: Li Li > > > > Sorry, but I can not parse your Subject: line at all. Please use > > vowels, we don't have a lack of t

Re: [PATCH v1] add binder genl for txn report

2024-08-12 Thread Li Li
On Mon, Aug 12, 2024 at 10:13 PM Greg KH wrote: > > On Mon, Aug 12, 2024 at 02:18:44PM -0700, Li Li wrote: > > From: Li Li > > Sorry, but I can not parse your Subject: line at all. Please use > vowels, we don't have a lack of them :) > > Also look at how other patches are formatted for these fil

Re: [PATCH v1] add binder genl for txn report

2024-08-12 Thread Greg KH
On Mon, Aug 12, 2024 at 02:18:44PM -0700, Li Li wrote: > From: Li Li Sorry, but I can not parse your Subject: line at all. Please use vowels, we don't have a lack of them :) Also look at how other patches are formatted for these files to get an idea of how to create a good subject line. > Froz

Re: [PATCH v3] staging: rtl8192e: Fix conflicting types error with net_device.

2024-06-25 Thread Philipp Hortmann
On 6/25/24 18:33, Teddy Engel wrote: Add a pre-declaration of struct net_device so the compiler is able to use rtl_pci.h / rtl_cam.h. Signed-off-by: Teddy Engel Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202406250858.l8rjmhqm-...@intel.com/ Fixes: 7dff0b27d9c

Re: [PATCH v2] staging: rtl8192e: Fix conflicting types error with net_device.

2024-06-25 Thread Greg Kroah-Hartman
On Tue, Jun 25, 2024 at 04:19:18PM +0100, Teddy Engel wrote: > Add a pre-declaration of struct net_device so the compiler is able to > use rtl_pci.h / rtl_cam.h. > > Fix for commit: 7dff0b27d9c842f88149bf611cbc0b59be1dcd3c: > [34/59] staging: rtl89192e: Remove unnecessary pre-declaration of struct

Re: [PATCH] staging: rtl8192e: Fix conflicting types error with net_device.

2024-06-25 Thread Greg Kroah-Hartman
On Tue, Jun 25, 2024 at 01:56:38PM +0100, Teddy Engel wrote: > Add a pre-declaration of struct net_device so the compiler is able to > use rtl_pci.h / rtl_cam.h. > > Signed-off-by: Teddy Engel > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202406250858.l8rjmh

Re: [PATCH] staging: rtl8192e: Fixes a coding style error

2024-06-04 Thread Greg Kroah-Hartman
On Fri, May 17, 2024 at 12:01:40PM +0100, Mohamed Karaoui wrote: > Adds a space before if statement's condition > > Signed-off-by: Mohamed Karaoui > --- > drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl819

RE: [PATCH AUTOSEL 6.1 3/7] x86/hyperv: Use slow_virt_to_phys() in page transition hypervisor callback

2024-03-12 Thread Michael Kelley
From: Pavel Machek Sent: Tuesday, March 12, 2024 1:35 PM > > > In preparation for temporarily marking pages not present during a > > transition between encrypted and decrypted, use slow_virt_to_phys() > > in the hypervisor callback. As long as the PFN is correct, > > This seems to be preparation

Re: [PATCH AUTOSEL 6.1 3/7] x86/hyperv: Use slow_virt_to_phys() in page transition hypervisor callback

2024-03-12 Thread Pavel Machek
Hi! > In preparation for temporarily marking pages not present during a > transition between encrypted and decrypted, use slow_virt_to_phys() > in the hypervisor callback. As long as the PFN is correct, This seems to be preparation for something we don't plan to do in -stable. Please drop. Best

Re: [PATCH] Staging: pi433: Updated bitrate range from datasheet

2024-03-03 Thread Greg KH
On Mon, Mar 04, 2024 at 02:28:02AM +0530, Aman Sharma wrote: > From a0528708b209739f0d566401bdd428e215abf366 Mon Sep 17 00:00:00 2001 > From: Aman Sharma > Date: Mon, 4 Mar 2024 00:44:06 +0530 > Subject: [PATCH] Staging: pi433: Updated bitrate range from datasheet Why is this all here in the chan

Re: [PATCH v4] Bluetooth: Fix for ACL disconnect when pairing fails

2023-08-17 Thread Muhammad Usama Anjum
On 6/17/14 4:04 PM, Lukasz Rymanowski wrote: > When pairing fails hci_conn refcnt drops below zero. This cause that > ACL link is not disconnected when disconnect timeout fires. > > Probably this is because l2cap_conn_del calls l2cap_chan_del for each > channel, and inside l2cap_chan_del conn is d

Re: [PATCH] staging: media: usbvision: Remove comparision to NULL

2023-05-23 Thread Hans Verkuil
Hi Anup, On 02/05/2023 03:05, Anup Sharma wrote: > Remove comparison to null in file usbvision-core.c and usbvision-i2c.c. > > Signed-off-by: Anup Sharma > --- > drivers/staging/media/usbvision/usbvision-core.c | 8 > drivers/staging/media/usbvision/usbvision-i2c.c | 2 +- > 2 files c

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2023-05-17 Thread Hongren Zheng
On Wed, Apr 29, 2020 at 01:53:02PM +, Stahl, Manuel wrote: > On Mi, 2020-04-29 at 11:41 +0200, gre...@linuxfoundation.org wrote: > > On Wed, Apr 29, 2020 at 07:51:01AM +, Stahl, Manuel wrote: > > > On Di, 2020-04-28 at 15:54 +0200, gregkh @ linuxfoundation . org wrote: > > > > On Thu, Apr 1

Re: [PATCH] staging: ks7010: remove unnecesary parentheses

2023-03-30 Thread Greg KH
On Fri, Mar 31, 2023 at 01:04:59AM +0800, Joel C. Chang wrote: > On Thu, Mar 30, 2023 at 02:49:54PM +0200, Greg KH wrote: > > On Thu, Mar 30, 2023 at 08:44:35PM +0800, Joel Camilo Chang Gonzalez wrote: > > > Remove parentheses not needed in if statement > > > > > > Signed-off-by: Joel Camilo Chang

Re: [PATCH] staging: ks7010: remove unnecesary parentheses

2023-03-30 Thread Joel C. Chang
On Thu, Mar 30, 2023 at 02:49:54PM +0200, Greg KH wrote: > On Thu, Mar 30, 2023 at 08:44:35PM +0800, Joel Camilo Chang Gonzalez wrote: > > Remove parentheses not needed in if statement > > > > Signed-off-by: Joel Camilo Chang Gonzalez > > --- > > drivers/staging/ks7010/ks_hostif.c | 2 +- > > 1

Re: [PATCH] staging: ks7010: remove unnecessary parentheses

2023-03-30 Thread Greg KH
On Thu, Mar 30, 2023 at 08:48:28PM +0800, Joel Camilo Chang Gonzalez wrote: > Remove redundant parentheses > > Signed-off-by: Joel Camilo Chang Gonzalez > --- > drivers/staging/ks7010/ks_wlan_net.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/sta

Re: [PATCH] staging: ks7010: remove unnecesary parentheses

2023-03-30 Thread Greg KH
On Thu, Mar 30, 2023 at 08:44:35PM +0800, Joel Camilo Chang Gonzalez wrote: > Remove parentheses not needed in if statement > > Signed-off-by: Joel Camilo Chang Gonzalez > --- > drivers/staging/ks7010/ks_hostif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s

Re: [PATCH v6] staging: sm750: Rename sm750_hw_cursor_* functions to snake_case

2023-03-29 Thread Fabio M. De Francesco
On mercoledì 29 marzo 2023 13:27:04 CEST Kloudifold wrote: > sm750 driver has sm750_hw_cursor_* functions, which are named in > camelcase. Rename them to snake case to follow the function naming > convention. > > - sm750_hw_cursor_setSize => sm750_hw_cursor_set_size > - sm750_hw_cursor_setPos =

Re: [PATCH v6] staging: sm750: Rename sm750_hw_cursor_* functions to snake_case

2023-03-29 Thread Kloudifold
On Wed, 29 Mar 2023 at 19:42, Greg Kroah-Hartman wrote: > > On Wed, Mar 29, 2023 at 07:27:04PM +0800, Kloudifold wrote: > > sm750 driver has sm750_hw_cursor_* functions, which are named in > > camelcase. Rename them to snake case to follow the function naming > > convention. > > > > - sm750_hw_cur

Re: [PATCH v6] staging: sm750: Rename sm750_hw_cursor_* functions to snake_case

2023-03-29 Thread Greg Kroah-Hartman
On Wed, Mar 29, 2023 at 07:27:04PM +0800, Kloudifold wrote: > sm750 driver has sm750_hw_cursor_* functions, which are named in > camelcase. Rename them to snake case to follow the function naming > convention. > > - sm750_hw_cursor_setSize => sm750_hw_cursor_set_size > - sm750_hw_cursor_setPos

Re: [PATCH] staging: android: ashmem.c: Declared file operation with const keyword

2023-03-09 Thread Greg Kroah-Hartman
On Mon, Mar 06, 2023 at 12:30:57AM +0530, Santosh Mahto wrote: > Warning found by checkpatch.pl script. > > Signed-off-by: Santosh Mahto > --- > drivers/staging/android/ashmem.c | 2 +- What kernel did you make this against? This is not in my tree anymore. thanks, greg k-h ___

Re: [PATCH v3 1/1] binder: return pending info for frozen async txns

2022-11-23 Thread Carlos Llamas
On Wed, Nov 23, 2022 at 12:16:54PM -0800, Li Li wrote: > From: Li Li > > An async transaction to a frozen process will still be successfully > put in the queue. But this pending async transaction won't be processed > until the target process is unfrozen at an unspecified time in the > future. Pas

Re: [PATCH v2 1/1] binder: return pending info for frozen async txns

2022-11-23 Thread Li Li
On Wed, Nov 23, 2022 at 10:58 AM Carlos Llamas wrote: > > This looks good. Could you rename the new op to signify the frozen > scenario though? We might have some other instances of pending > transactions in the future so might as well be specific here. Done [1]. v3: rename BR_TRANSACTION_PENDIN

Re: [PATCH v2 1/1] binder: return pending info for frozen async txns

2022-11-23 Thread Carlos Llamas
On Thu, Nov 10, 2022 at 12:34:05PM -0800, Li Li wrote: > From: Li Li > > An async transaction to a frozen process will still be successfully > put in the queue. But this pending async transaction won't be processed > until the target process is unfrozen at an unspecified time in the > future. Pas

Re: [PATCH v1 1/1] binder: return pending info for frozen async txns

2022-11-10 Thread Li Li
On Wed, Nov 9, 2022 at 2:43 PM Carlos Llamas wrote: > > On Thu, Nov 03, 2022 at 12:05:49PM -0700, Li Li wrote: > > From: Li Li > > > > An async transaction to a frozen process will still be successsfully > > nit: sucessfully typo Nice catch! Will remove the extra 's' in v2. > > > put in the que

Re: [PATCH v1 1/1] binder: return pending info for frozen async txns

2022-11-09 Thread Carlos Llamas
On Thu, Nov 03, 2022 at 12:05:49PM -0700, Li Li wrote: > From: Li Li > > An async transaction to a frozen process will still be successsfully nit: sucessfully typo > put in the queue. But this pending async transaction won't be processed > until the target process is unfrozen at an unspecified

Re: [PATCH] Staging: Android: ashmem.c: Fixed missing const modifier

2022-09-15 Thread Greg KH
On Thu, Sep 15, 2022 at 08:58:27PM +1200, Jonathan Bergh wrote: > Fixed missing const modifier line 370 > > Signed-off-by: Jonathan Bergh > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c > b/drive

Re: [PATCH] usb: Improves USB2.0 write performance

2022-08-30 Thread Alan Stern
On Tue, Aug 30, 2022 at 04:43:25PM +0800, Hu Xiaoying wrote: > USB external storage device(0x0b05:1932), use gnome-disk-utility tools > to test usb write < 30MB/s. if does not to load module of uas for this device > , can increase the write speed from 20MB/s to more than 40MB/s. > > Signed-off-by

Re: [PATCH v7 3/4] drm/loongson: Add interrupt driver for LS7A.

2022-07-11 Thread kernel test robot
Hi Chenyang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v5.19-rc6 next-20220708] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest t

Re: [PATCH 2/3] wfx: add antenna configuration files

2022-07-08 Thread Jérôme Pouiller
On Thursday 7 July 2022 19:40:27 CEST Josh Boyer wrote: > On Thu, Jul 7, 2022 at 1:04 PM Ben Brown wrote: > > On 21/02/2022 16:37, Jerome Pouiller wrote: > > > From: Jérôme Pouiller > > > > > diff --git a/WHENCE b/WHENCE > > > index 0a6cb15..96f67f7 100644 > > > --- a/WHENCE > > > +++ b/WHENCE >

Re: [PATCH 2/3] wfx: add antenna configuration files

2022-07-07 Thread Josh Boyer
On Thu, Jul 7, 2022 at 1:04 PM Ben Brown wrote: > > On 21/02/2022 16:37, Jerome Pouiller wrote: > > From: Jérôme Pouiller > > > diff --git a/WHENCE b/WHENCE > > index 0a6cb15..96f67f7 100644 > > --- a/WHENCE > > +++ b/WHENCE > > @@ -5845,8 +5845,18 @@ Driver: wfx - Silicon Labs Wi-Fi Transceiver

Re: [PATCH 2/3] wfx: add antenna configuration files

2022-07-07 Thread Ben Brown
On 21/02/2022 16:37, Jerome Pouiller wrote: > From: Jérôme Pouiller > diff --git a/WHENCE b/WHENCE > index 0a6cb15..96f67f7 100644 > --- a/WHENCE > +++ b/WHENCE > @@ -5845,8 +5845,18 @@ Driver: wfx - Silicon Labs Wi-Fi Transceiver > File: wfx/wfm_wf200_C0.sec > Version: 3.12.1 > > +File: wfx/

Re: [PATCH v7 2/4] drm/loongson: Add GPIO and I2C driver for loongson drm.

2022-06-25 Thread kernel test robot
Hi Chenyang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v5.19-rc3 next-20220624] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest t

Re: [PATCH v7 1/4] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip

2022-06-25 Thread kernel test robot
Hi Chenyang, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v5.19-rc3 next-20220624] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

Re: [PATCH] Staging: comedi: comedi_fops: fixed a spacing coding style issue

2022-06-09 Thread Ian Abbott
On 09/06/2022 05:53, Agam Kohli wrote: Fixed a coding style issue. Signed-off-by: Agam Kohli --- drivers/staging/comedi/comedi_fops.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index e85a99b68f31..3f70e5

Re: [PATCH v2] Binder: add TF_UPDATE_TXN to replace outdated txn

2022-05-19 Thread Greg KH
On Thu, May 19, 2022 at 11:34:54AM -0700, Li Li wrote: > From: Li Li > > When the target process is busy, incoming oneway transactions are > queued in the async_todo list. If the clients continue sending extra > oneway transactions while the target process is frozen, this queue can > become too l

Re: [PATCH v1] Binder: add TF_UPDATE_TXN

2022-05-19 Thread Li Li
On Thu, May 19, 2022 at 8:50 AM Greg KH wrote: > > On Wed, May 18, 2022 at 05:06:23PM -0700, Li Li wrote: > > From: Li Li > > Note, your subject does not say what TF_UPDATE_TXN is, so it's a bit > hard to determine what is happening here. Can you clean that up a bit > and sumarize what this new

Re: [PATCH v1] Binder: add TF_UPDATE_TXN

2022-05-19 Thread Greg KH
On Wed, May 18, 2022 at 05:06:23PM -0700, Li Li wrote: > From: Li Li Note, your subject does not say what TF_UPDATE_TXN is, so it's a bit hard to determine what is happening here. Can you clean that up a bit and sumarize what this new addition does? > > When the target process is busy, incomin

Re: [PATCH RFT/RFC v2 01/47] staging: media: Revert "media: zoran: remove deprecated driver"

2022-05-07 Thread Laurent Pinchart
On Sat, May 07, 2022 at 10:58:39AM -0500, Sergey Meirovich wrote: > Sergey Meirovich has sent you an email via Gmail confidential mode: > > Gmail logoRe: [PATCH RFT/RFC v2 01/47] staging: media: Revert "media: zoran: > remove deprecated driver" > > This message was sent on May 7, 2022 at 8:58:50

Re: [PATCH v7 1/4] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip

2022-04-22 Thread kernel test robot
Hi Chenyang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on v5.18-rc3 next-20220422] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as docum

Re: [PATCH v7 2/4] drm/loongson: Add GPIO and I2C driver for loongson drm.

2022-04-22 Thread kernel test robot
Hi Chenyang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on v5.18-rc3 next-20220422] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as docum

Re: [PATCH v10 0/1] wfx: get out from the staging area

2022-04-12 Thread Kalle Valo
+ stephen Greg Kroah-Hartman writes: > On Wed, Apr 06, 2022 at 10:06:33AM +0300, Kalle Valo wrote: >> Jakub Kicinski writes: >> >> > On Tue, 05 Apr 2022 10:16:58 +0300 Kalle Valo wrote: >> >> Sure, that would technically work. But I just think it's cleaner to use >> >> -rc1 (or later) as the b

Re: [PATCH v10 0/1] wfx: get out from the staging area

2022-04-07 Thread Greg Kroah-Hartman
On Wed, Apr 06, 2022 at 10:06:33AM +0300, Kalle Valo wrote: > Jakub Kicinski writes: > > > On Tue, 05 Apr 2022 10:16:58 +0300 Kalle Valo wrote: > >> Sure, that would technically work. But I just think it's cleaner to use > >> -rc1 (or later) as the baseline for an immutable branch. If the baselin

Re: [PATCH v10 0/1] wfx: get out from the staging area

2022-04-06 Thread Kalle Valo
Jakub Kicinski writes: > On Tue, 05 Apr 2022 10:16:58 +0300 Kalle Valo wrote: >> Sure, that would technically work. But I just think it's cleaner to use >> -rc1 (or later) as the baseline for an immutable branch. If the baseline >> is an arbitrary commit somewhere within merge windows commits, it

Re: [PATCH v10 0/1] wfx: get out from the staging area

2022-04-05 Thread Jakub Kicinski
On Tue, 05 Apr 2022 10:16:58 +0300 Kalle Valo wrote: > Sure, that would technically work. But I just think it's cleaner to use > -rc1 (or later) as the baseline for an immutable branch. If the baseline > is an arbitrary commit somewhere within merge windows commits, it's more > work for everyone to

Re: [PATCH v10 0/1] wfx: get out from the staging area

2022-04-05 Thread Kalle Valo
Jakub Kicinski writes: > On Mon, 4 Apr 2022 23:22:47 -0700 Jakub Kicinski wrote: >> On Mon, 04 Apr 2022 13:49:18 +0300 Kalle Valo wrote: >> > Dave&Jakub, once you guys open net-next will it be based on -rc1? >> >> Not normally. We usually let net feed net-next so it'd get -rc1 this >> Thursday

Re: [PATCH v10 0/1] wfx: get out from the staging area

2022-04-04 Thread Jakub Kicinski
On Mon, 4 Apr 2022 23:22:47 -0700 Jakub Kicinski wrote: > On Mon, 04 Apr 2022 13:49:18 +0300 Kalle Valo wrote: > > Dave&Jakub, once you guys open net-next will it be based on -rc1? > > Not normally. We usually let net feed net-next so it'd get -rc1 this > Thursday. But we should be able to fast-

Re: [PATCH v10 0/1] wfx: get out from the staging area

2022-04-04 Thread Jakub Kicinski
On Mon, 04 Apr 2022 13:49:18 +0300 Kalle Valo wrote: > Dave&Jakub, once you guys open net-next will it be based on -rc1? Not normally. We usually let net feed net-next so it'd get -rc1 this Thursday. But we should be able to fast-forward, let me confirm with Dave. > That would make it easier for

Re: [PATCH v10 0/1] wfx: get out from the staging area

2022-04-04 Thread Kalle Valo
Jérôme Pouiller writes: > On Saturday 26 February 2022 14:15:33 CEST Kalle Valo wrote: >> Greg Kroah-Hartman writes: >> >> > That sounds great to me, let's plan on that happening after 5.18-rc1 is >> > out. >> >> Very good, we have a plan then. I marked the patch as deferred in >> patchwork: >

Re: [PATCH v10 0/1] wfx: get out from the staging area

2022-04-04 Thread Jérôme Pouiller
Hi Kalle, On Saturday 26 February 2022 14:15:33 CEST Kalle Valo wrote: > Greg Kroah-Hartman writes: > > > On Sat, Feb 26, 2022 at 12:41:41PM +0200, Kalle Valo wrote: > >> + jakub > >> > >> Jerome Pouiller writes: > >> > >> > The firmware and the PDS files (= antenna configurations) are now a pa

Re: Re: [PATCH v1] pinctrl: ralink: rt2880: Check for return value of devm_kcalloc()

2022-04-01 Thread Andy Shevchenko
On Fri, Apr 1, 2022 at 6:06 AM unSimple wrote: > > The main consideration of the 'continue' in the patch is that those > statements are inner a loop. > > The next allocation may be successful so I think it is better to use > 'continue' here. Please, do not top-post! What you explained is logi

Re: [PATCH v1] pinctrl: ralink: rt2880: Check for return value of devm_kcalloc()

2022-03-29 Thread Andy Shevchenko
On Tue, Mar 29, 2022 at 11:36 AM QintaoShen wrote: > > The memory allocation function devm_kcalloc() may return NULL pointer, may --> might > so it is better to add a check for 'p->func[i]->pins' to avoid possible > NULL pointer dereference. ... > @@ -266,6 +266,10 @@ static int rt2880_pinmux_

Re: [PATCH v1] pinctrl: ralink: rt2880: Check for return value of devm_kcalloc()

2022-03-29 Thread Greg KH
On Tue, Mar 29, 2022 at 03:50:12PM +0800, QintaoShen wrote: > The memory allocation function devm_kcalloc() may return NULL pointer, > so it is better to add a check for 'p->func[i]->pins' to avoid possible > NULL pointer dereference. > > Signed-off-by: QintaoShen > --- > drivers/pinctrl/ralink/

Re: [PATCH 03/10] staging: wfx: format comments on 100 columns

2022-03-01 Thread Jeff Johnson
On 2/28/2022 5:12 PM, Joe Perches wrote: On Fri, 2022-02-25 at 12:23 +0100, Jerome Pouiller wrote: From: Jérôme Pouiller A few comments were not yet formatted on 100 columns. IMO, none of these changes are necessary or good changes. 80 columns is preferred. Really comments should most alwa

Re: [PATCH 03/10] staging: wfx: format comments on 100 columns

2022-02-28 Thread Joe Perches
On Fri, 2022-02-25 at 12:23 +0100, Jerome Pouiller wrote: > From: Jérôme Pouiller > > A few comments were not yet formatted on 100 columns. IMO, none of these changes are necessary or good changes. 80 columns is preferred. Really comments should most always use 80 columns, and only occasionall

Re: [PATCH v10 0/1] wfx: get out from the staging area

2022-02-28 Thread Jérôme Pouiller
+ Rob + devicetree On Saturday 26 February 2022 11:41:41 CET Kalle Valo wrote: > + jakub > > Jerome Pouiller writes: > > > The firmware and the PDS files (= antenna configurations) are now a part of > > the linux-firmware repository. > > > > All the issues have been fixed in staging tree. I thi

Re: [PATCH v10 0/1] wfx: get out from the staging area

2022-02-26 Thread Kalle Valo
Greg Kroah-Hartman writes: > On Sat, Feb 26, 2022 at 12:41:41PM +0200, Kalle Valo wrote: >> + jakub >> >> Jerome Pouiller writes: >> >> > The firmware and the PDS files (= antenna configurations) are now a part of >> > the linux-firmware repository. >> > >> > All the issues have been fixed in

Re: [PATCH v10 0/1] wfx: get out from the staging area

2022-02-26 Thread Greg Kroah-Hartman
On Sat, Feb 26, 2022 at 12:41:41PM +0200, Kalle Valo wrote: > + jakub > > Jerome Pouiller writes: > > > The firmware and the PDS files (= antenna configurations) are now a part of > > the linux-firmware repository. > > > > All the issues have been fixed in staging tree. I think we are ready to g

Re: [PATCH v10 0/1] wfx: get out from the staging area

2022-02-26 Thread Kalle Valo
+ jakub Jerome Pouiller writes: > The firmware and the PDS files (= antenna configurations) are now a part of > the linux-firmware repository. > > All the issues have been fixed in staging tree. I think we are ready to get > out from the staging tree for the kernel 5.18. [...] > rename Docume

Re: [PATCH 0/3] linux-firmware: update wfx

2022-02-24 Thread Josh Boyer
On Mon, Feb 21, 2022 at 11:38 AM Jerome Pouiller wrote: > > From: Jérôme Pouiller > > The two first patches reflect changes made in the kernel. > > Jérôme Pouiller (3): > wfx: rename silabs/ into wfx/ > wfx: add antenna configuration files > wfx: update to firmware 3.14 All 3 applied and p

Re: [PATCH] staging: wfx: fix scan with WFM200 and WW regulation

2022-02-18 Thread Riccardo Ferrazzo
>Da: Jérôme Pouiller >Inviato: venerdì 18 febbraio 2022 15:04 >A: Greg Kroah-Hartman; Riccardo Ferrazzo >Cc: linux-wirel...@vger.kernel.org; net...@vger.kernel.org; Kalle Valo; >de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; David S . Miller >Oggetto: Re: [PATCH]

Re: [PATCH] staging: wfx: fix scan with WFM200 and WW regulation

2022-02-18 Thread Jérôme Pouiller
Hello Riccardo, On Friday 18 February 2022 14:53:35 CET Riccardo Ferrazzo wrote: > > Signed-off-by: Riccardo Ferrazzo > > > Sorry for the footer it is added automatically > Your mail has probably not been received by everyone since you sent it in html[1] (try also to avoid top-posting). Ne

Re: [PATCH] staging: wfx: fix scan with WFM200 and WW regulation

2022-02-18 Thread Jérôme Pouiller
On Friday 18 February 2022 12:00:54 CET Greg Kroah-Hartman wrote: > On Fri, Feb 18, 2022 at 11:57:47AM +0100, Jérôme Pouiller wrote: > > On Friday 18 February 2022 11:53:58 CET Jerome Pouiller wrote: > > > From: Riccardo Ferrazzo > > > > > > Some variants of the WF200 disallow active scan on chann

Re: [PATCH] staging: wfx: fix scan with WFM200 and WW regulation

2022-02-18 Thread Greg Kroah-Hartman
On Fri, Feb 18, 2022 at 11:57:47AM +0100, Jérôme Pouiller wrote: > On Friday 18 February 2022 11:53:58 CET Jerome Pouiller wrote: > > From: Riccardo Ferrazzo > > > > Some variants of the WF200 disallow active scan on channel 12 and 13. > > For these parts, the channels 12 and 13 are marked IEEE80

Re: [PATCH] staging: wfx: fix scan with WFM200 and WW regulation

2022-02-18 Thread Jérôme Pouiller
On Friday 18 February 2022 11:53:58 CET Jerome Pouiller wrote: > From: Riccardo Ferrazzo > > Some variants of the WF200 disallow active scan on channel 12 and 13. > For these parts, the channels 12 and 13 are marked IEEE80211_CHAN_NO_IR. > > However, the beacon hint procedure was removing the fl

Re: [PATCH 2/2] staging: wfx: apply the necessary SDIO quirks for the Silabs WF200

2022-02-17 Thread Greg Kroah-Hartman
On Thu, Feb 17, 2022 at 04:41:38PM +0100, Jérôme Pouiller wrote: > On Thursday 17 February 2022 16:04:51 CET Kalle Valo wrote: > > Ulf Hansson writes: > > > On Thu, 17 Feb 2022 at 10:59, Kalle Valo wrote: > > >> Jerome Pouiller writes: > > >> > From: Jérôme Pouiller > > >> > > > >> > Until now,

Re: [PATCH 2/2] staging: wfx: apply the necessary SDIO quirks for the Silabs WF200

2022-02-17 Thread Jérôme Pouiller
On Thursday 17 February 2022 16:04:51 CET Kalle Valo wrote: > Ulf Hansson writes: > > On Thu, 17 Feb 2022 at 10:59, Kalle Valo wrote: > >> Jerome Pouiller writes: > >> > From: Jérôme Pouiller > >> > > >> > Until now, the SDIO quirks are applied directly from the driver. > >> > However, it is be

Re: [PATCH 2/2] staging: wfx: apply the necessary SDIO quirks for the Silabs WF200

2022-02-17 Thread Kalle Valo
Ulf Hansson writes: > On Thu, 17 Feb 2022 at 10:59, Kalle Valo wrote: >> >> Jerome Pouiller writes: >> >> > From: Jérôme Pouiller >> > >> > Until now, the SDIO quirks are applied directly from the driver. >> > However, it is better to apply the quirks before driver probing. So, >> > this patch

Re: [PATCH 2/2] staging: wfx: apply the necessary SDIO quirks for the Silabs WF200

2022-02-17 Thread Ulf Hansson
On Thu, 17 Feb 2022 at 10:59, Kalle Valo wrote: > > Jerome Pouiller writes: > > > From: Jérôme Pouiller > > > > Until now, the SDIO quirks are applied directly from the driver. > > However, it is better to apply the quirks before driver probing. So, > > this patch relocate the quirks in the MMC

Re: [PATCH 2/2] staging: wfx: apply the necessary SDIO quirks for the Silabs WF200

2022-02-17 Thread Kalle Valo
Jerome Pouiller writes: > From: Jérôme Pouiller > > Until now, the SDIO quirks are applied directly from the driver. > However, it is better to apply the quirks before driver probing. So, > this patch relocate the quirks in the MMC framework. It would be good to know how this is better, what's

Re: [PATCH 0/2] staging: wfx: apply SDIO suggestions

2022-02-16 Thread Ulf Hansson
On Wed, 16 Feb 2022 at 10:31, Jerome Pouiller wrote: > > From: Jérôme Pouiller > > Hi Ulf, Greg, > > The second patch of this series touch to the staging tree and to the MMC > framework. I don't know what is the rule for these cases, but I think it > makes more sense to carry this patch with the

Re: [PATCH 2/2] staging: wfx: apply the necessary SDIO quirks for the Silabs WF200

2022-02-16 Thread Pali Rohár
On Wednesday 16 February 2022 10:31:12 Jerome Pouiller wrote: > From: Jérôme Pouiller > > Until now, the SDIO quirks are applied directly from the driver. > However, it is better to apply the quirks before driver probing. So, > this patch relocate the quirks in the MMC framework. > > Note that t

Re: [PATCH 1/2] staging: wfx: WF200 has no official SDIO IDs

2022-02-16 Thread Pali Rohár
On Wednesday 16 February 2022 10:31:11 Jerome Pouiller wrote: > From: Jérôme Pouiller > > Some may think that SDIO_VENDOR_ID_SILABS / SDIO_DEVICE_ID_SILABS_WF200 > are official SDIO IDs. However, it is not the case, the values used by > WF200 are not official (BTW, the driver rely on the DT rathe

Re: [PATCH v9 05/24] wfx: add main.c/main.h

2022-02-10 Thread Kalle Valo
Jérôme Pouiller writes: >> > There is also the patch 01/24 about the SDIO IDs. >> > >> > I think the v10 could contain only 3 patches: >> > >> > 1. mmc: sdio: add SDIO IDs for Silabs WF200 chip >> > 2. dt-bindings: introduce silabs,wfx.yaml >> > 3. [all the patches 3 to 24 squashed] >

Re: [PATCH v9 05/24] wfx: add main.c/main.h

2022-02-10 Thread Jérôme Pouiller
On Thursday 10 February 2022 17:25:05 CET Kalle Valo wrote: > Jérôme Pouiller writes: > > > On Thursday 10 February 2022 15:51:03 CET Kalle Valo wrote: > >> Jérôme Pouiller writes: > >> > On Thursday 10 February 2022 15:20:56 CET Kalle Valo wrote: > >> >> Jérôme Pouiller writes: > >> >> > >> >>

Re: [PATCH v9 05/24] wfx: add main.c/main.h

2022-02-10 Thread Kalle Valo
Jérôme Pouiller writes: > On Thursday 10 February 2022 15:51:03 CET Kalle Valo wrote: >> Jérôme Pouiller writes: >> > On Thursday 10 February 2022 15:20:56 CET Kalle Valo wrote: >> >> Jérôme Pouiller writes: >> >> >> >> > Kalle, is this function what you expected? If it is right for you, I am >

Re: [PATCH v9 05/24] wfx: add main.c/main.h

2022-02-10 Thread Jérôme Pouiller
On Thursday 10 February 2022 15:51:03 CET Kalle Valo wrote: > Jérôme Pouiller writes: > > On Thursday 10 February 2022 15:20:56 CET Kalle Valo wrote: > >> Jérôme Pouiller writes: > >> > >> > Kalle, is this function what you expected? If it is right for you, I am > >> > going to send it to the sta

Re: [PATCH v9 05/24] wfx: add main.c/main.h

2022-02-10 Thread Kalle Valo
Jérôme Pouiller writes: > On Thursday 10 February 2022 15:20:56 CET Kalle Valo wrote: >> >> Jérôme Pouiller writes: >> >> > Kalle, is this function what you expected? If it is right for you, I am >> > going to send it to the staging tree. >> >> Looks better, but I don't get why '{' and '}' ar

Re: [PATCH v9 05/24] wfx: add main.c/main.h

2022-02-10 Thread Jérôme Pouiller
On Thursday 10 February 2022 15:20:56 CET Kalle Valo wrote: > > Jérôme Pouiller writes: > > > Hi Kalle, > > > > On Tuesday 11 January 2022 18:14:05 CET Jerome Pouiller wrote: > >> From: Jérôme Pouiller > >> > >> Signed-off-by: Jérôme Pouiller > >> --- > >> drivers/net/wireless/silabs/wfx/main

Re: [PATCH v9 05/24] wfx: add main.c/main.h

2022-02-10 Thread Pali Rohár
On Tuesday 11 January 2022 18:14:05 Jerome Pouiller wrote: > +/* The device needs data about the antenna configuration. This information in > + * provided by PDS (Platform Data Set, this is the wording used in WF200 > + * documentation) files. For hardware integrators, the full process to create >

Re: [PATCH v9 05/24] wfx: add main.c/main.h

2022-02-10 Thread Kalle Valo
Jérôme Pouiller writes: > Hi Kalle, > > On Tuesday 11 January 2022 18:14:05 CET Jerome Pouiller wrote: >> From: Jérôme Pouiller >> >> Signed-off-by: Jérôme Pouiller >> --- >> drivers/net/wireless/silabs/wfx/main.c | 485 + >> drivers/net/wireless/silabs/wfx/main.h | 4

Re: [PATCH] drivers: meson: vdec: add VP9 support to GXM

2022-02-10 Thread Neil Armstrong
On 09/02/2022 16:31, Christian Hewitt wrote: VP9 support for GXM appears to have been missed from the original codec submission [0] but it works well, so let's add support. [0] https://github.com/torvalds/linux/commit/00c43088aa680989407b6afbda295f67b3f123f1 Signed-off-by: Christian Hewitt --

Re: [PATCH] staging: drop fpgaboot driver

2022-02-08 Thread Greg Kroah-Hartman
On Fri, Feb 04, 2022 at 11:08:35AM -0800, Tong Zhang wrote: > The gs_fpgaboot driver is totally broken since 2014 and no one even > noticed the driver is not probing. Given the quality of the driver > and its current state it makes sense to drop it. > > Signed-off-by: Tong Zhang Thanks, now drop

Re: [PATCH] staging: gs_fpgaboot: revert removed board specific code

2022-02-04 Thread Tong Zhang
On Fri, Feb 4, 2022 at 6:23 AM Greg Kroah-Hartman wrote: > > On Thu, Feb 03, 2022 at 09:40:27PM -0800, Tong Zhang wrote: > > Loading the driver will always fail since > > xl_init_io() always returns -1. This driver is broken since 2014 and I > > doubt anyone is actually using it, we could either r

Re: [PATCH] staging: gs_fpgaboot: revert removed board specific code

2022-02-04 Thread Greg Kroah-Hartman
On Thu, Feb 03, 2022 at 09:40:27PM -0800, Tong Zhang wrote: > gs_fpgaboot is currently useless since the board specific code is > removed in 06a3fab941da. Nit, commits should be printed out like this: 06a3fab941da ("staging: gs_fpgaboot: remove checks for CONFIG_B4860G100") > Loading the driver w

Re: [PATCH] staging: gs_fpgaboot: revert removed board specific code

2022-02-04 Thread Dan Carpenter
On Thu, Feb 03, 2022 at 09:40:27PM -0800, Tong Zhang wrote: > gs_fpgaboot is currently useless since the board specific code is > removed in 06a3fab941da. Loading the driver will always fail since > xl_init_io() always returns -1. This driver is broken since 2014 and I > doubt anyone is actually us

Re: [PATCH v9 05/24] wfx: add main.c/main.h

2022-01-26 Thread Jérôme Pouiller
Hi Kalle, On Tuesday 11 January 2022 18:14:05 CET Jerome Pouiller wrote: > From: Jérôme Pouiller > > Signed-off-by: Jérôme Pouiller > --- > drivers/net/wireless/silabs/wfx/main.c | 485 + > drivers/net/wireless/silabs/wfx/main.h | 42 +++ > 2 files changed, 527 inserti

Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword

2022-01-24 Thread kernel test robot
Hi ratnesh-r1, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/ratnesh-r1/staging-android-ashmem-Declared-file-operation-with-const-keyword/20220124-151116 base: https://git.kernel.org/pub/s

Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword

2022-01-24 Thread kernel test robot
Hi ratnesh-r1, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/ratnesh-r1/staging-android-ashmem-Declared-file-operation-with-const-keyword/20220124-151116 base: https://git.kernel.org/pub/s

Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword

2022-01-23 Thread Greg Kroah-Hartman
On Sun, Jan 23, 2022 at 11:09:47PM -0800, ratnesh-r1 wrote: > warning found by checkpatch.pl script. > > Signed-off-by: ratnesh-r1 > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c > b/drivers/stag

Re: [PATCH v3 1/1] drm/bridge: anx7625: send DPCD command to downstream

2022-01-17 Thread Hsin-Yi Wang
On Tue, Jan 11, 2022 at 5:06 PM Xin Ji wrote: > > Send DPCD command to downstream before anx7625 power down, > let downstream monitor enter into standby mode. > > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 42 +++ > 1 file changed, 35 insertions

Re: [PATCH 02/31] staging: wfx: fix HIF API license

2022-01-13 Thread Jérôme Pouiller
On Thursday 13 January 2022 12:50:23 CET Kalle Valo wrote: > Jerome Pouiller writes: > > > From: Jérôme Pouiller > > > > Apache-2.0 is not allowed in the kernel. > > > > Signed-off-by: Jérôme Pouiller > > --- > > drivers/staging/wfx/hif_api_cmd.h | 2 +- > > drivers/staging/wfx/hif_api_gen

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

2022-01-13 Thread Ulf Hansson
On Wed, 12 Jan 2022 at 19:24, Jérôme Pouiller wrote: > > On Wednesday 12 January 2022 18:48:48 CET Pali Rohár wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you recognize the sender and know > > the content is safe. >

Re: [PATCH 02/31] staging: wfx: fix HIF API license

2022-01-13 Thread Kalle Valo
Jerome Pouiller writes: > From: Jérôme Pouiller > > Apache-2.0 is not allowed in the kernel. > > Signed-off-by: Jérôme Pouiller > --- > drivers/staging/wfx/hif_api_cmd.h | 2 +- > drivers/staging/wfx/hif_api_general.h | 2 +- > drivers/staging/wfx/hif_api_mib.h | 2 +- > 3 files change

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

2022-01-12 Thread Jérôme Pouiller
On Wednesday 12 January 2022 18:48:48 CET Pali Rohár wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > On Wednesday 12 January 2022 17:45:45 Jérôme Pouiller wro

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

2022-01-12 Thread Pali Rohár
On Wednesday 12 January 2022 17:45:45 Jérôme Pouiller wrote: > On Wednesday 12 January 2022 12:43:32 CET Pali Rohár wrote: > > > > On Wednesday 12 January 2022 12:18:58 Jérôme Pouiller wrote: > > > On Wednesday 12 January 2022 11:58:59 CET Pali Rohár wrote: > > > > On Tuesday 11 January 2022 18:14

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

2022-01-12 Thread Jérôme Pouiller
On Wednesday 12 January 2022 12:43:32 CET Pali Rohár wrote: > > On Wednesday 12 January 2022 12:18:58 Jérôme Pouiller wrote: > > On Wednesday 12 January 2022 11:58:59 CET Pali Rohár wrote: > > > On Tuesday 11 January 2022 18:14:08 Jerome Pouiller wrote: > > > > +static const struct sdio_device_id

Re: [PATCH v9 08/24] wfx: add bus_sdio.c

2022-01-12 Thread Ulf Hansson
On Wed, 12 Jan 2022 at 12:43, Pali Rohár wrote: > > On Wednesday 12 January 2022 12:18:58 Jérôme Pouiller wrote: > > On Wednesday 12 January 2022 11:58:59 CET Pali Rohár wrote: > > > On Tuesday 11 January 2022 18:14:08 Jerome Pouiller wrote: > > > > +static const struct sdio_device_id wfx_sdio_ids

  1   2   3   4   5   6   7   8   9   10   >