Aw: Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-24 Thread Lino Sanfilippo
org, > de...@driverdev.osuosl.org, linux-ker...@vger.kernel.org, > net...@vger.kernel.org > Betreff: Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit > ethernet driver > > On 15.11.2016 22:59, Andrew Lunn wrote: > >> The link state is retrieved by a command to the app

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
On 16.11.2016 00:03, Andrew Lunn wrote: >> > + val = MII_BMCR << 16 | SLIC_PCR_AUTONEG | >> > + SLIC_PCR_AUTONEG_RST; >> > + slic_write(sdev, SLIC_REG_WPHY, val); > >> Thats essentially what I meant by setting a fl

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Andrew Lunn
> > + val = MII_BMCR << 16 | SLIC_PCR_AUTONEG | > > +SLIC_PCR_AUTONEG_RST; > > + slic_write(sdev, SLIC_REG_WPHY, val); > Thats essentially what I meant by setting a flag in the irq handler. The mdio > function

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
On 15.11.2016 23:39, Florian Fainelli wrote: > On 11/15/2016 02:34 PM, Lino Sanfilippo wrote: >> On 15.11.2016 22:59, Andrew Lunn wrote: The link state is retrieved by a command to the application processor that is running on the network card. Also the register to set the phy confi

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Florian Fainelli
On 11/15/2016 02:34 PM, Lino Sanfilippo wrote: > On 15.11.2016 22:59, Andrew Lunn wrote: >>> The link state is retrieved by a command to the application processor that >>> is running >>> on the network card. Also the register to set the phy configuration is >>> write-only, so >>> it is not even

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
On 15.11.2016 22:59, Andrew Lunn wrote: >> The link state is retrieved by a command to the application processor that >> is running >> on the network card. Also the register to set the phy configuration is >> write-only, so >> it is not even possible to do the usual mdio bit-banging in the Phy r

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Andrew Lunn
> The link state is retrieved by a command to the application processor that is > running > on the network card. Also the register to set the phy configuration is > write-only, so > it is not even possible to do the usual mdio bit-banging in the Phy read() > and write() > functions (however the

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
Hi, On 15.11.2016 21:54, Florian Fainelli wrote: > On 11/15/2016 12:46 PM, Lino Sanfilippo wrote: >>> Could this be pulled out into a standard PHY driver? All the SLIC >>> SLIC_PCR_ defines seems to be the same as those in mii.h. This could >>> be a standard PHY hidden behind a single register. >>

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Florian Fainelli
On 11/15/2016 12:46 PM, Lino Sanfilippo wrote: >> Could this be pulled out into a standard PHY driver? All the SLIC >> SLIC_PCR_ defines seems to be the same as those in mii.h. This could >> be a standard PHY hidden behind a single register. >> >>Andrew > > You are right, the driver should rea

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
Hi, On 13.11.2016 20:55, Andrew Lunn wrote: >> +static const char slic_stats_strings[][ETH_GSTRING_LEN] = { >> +"rx_packets ", >> +"rx_bytes ", >> +"rx_multicasts ", >> +"rx_errors ", >> +"rx_buff_miss ", >> +"rx_tp_csum ", >> +"rx_tp_oflow",

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-13 Thread Andrew Lunn
> +static const char slic_stats_strings[][ETH_GSTRING_LEN] = { > + "rx_packets ", > + "rx_bytes ", > + "rx_multicasts ", > + "rx_errors ", > + "rx_buff_miss ", > + "rx_tp_csum ", > + "rx_tp_oflow", > + "rx_tp_hlen ", > + "rx_ip_csum

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-13 Thread kbuild test robot
Hi Lino, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Lino-Sanfilippo/net-ethernet-slicoss-add-slicoss-gigabit-ethernet-driver/20161113-125131 config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-12 Thread kbuild test robot
Hi Lino, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Lino-Sanfilippo/net-ethernet-slicoss-add-slicoss-gigabit-ethernet-driver/20161113-125131 config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20