Re: [RFC PATCH v3] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-20 Thread Greg KH
On Thu, Jul 19, 2018 at 09:45:31PM -0400, Jacob Feder wrote: > First I run "make menuconfig" and select my driver in "device drivers" > > "staging". If I run "make" or "make all" or > "make drivers/staging/axis-fifo" everything compiles without errors or > warnings even if I put blatant syntax err

Re: [RFC PATCH v3] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-20 Thread Stephen Hemminger
On Thu, 19 Jul 2018 21:45:31 -0400 Jacob Feder wrote: > First I run "make menuconfig" and select my driver in "device drivers" > > "staging". If I run "make" or "make all" or > "make drivers/staging/axis-fifo" everything compiles without errors or > warnings even if I put blatant syntax errors i

Re: [RFC PATCH v3] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-19 Thread Jacob Feder
First I run "make menuconfig" and select my driver in "device drivers" > "staging". If I run "make" or "make all" or "make drivers/staging/axis-fifo" everything compiles without errors or warnings even if I put blatant syntax errors in my code. What am I missing here? Thanks, Jacob __

Re: [RFC PATCH v3] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-19 Thread Stephen Hemminger
On Thu, 19 Jul 2018 13:16:57 +0300 Dan Carpenter wrote: > I'm getting some compile warnings where we us %u instead of %lu for > size_t. > > We also need a README explaining what else needs to be done before this > can be moved out of staging into the normal part of the kernel. Use %zu to print

Re: [RFC PATCH v3] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-19 Thread Stephen Hemminger
On Wed, 18 Jul 2018 22:46:34 -0400 Jacob Feder wrote: > +MODULE_DESCRIPTION("Xilinx AXI-Stream FIFO v4.1 IP core driver\n\n" > +"This IP core has read and write AXI-Stream FIFOs, the contents of which > can\n" > +"be accessed from the AXI4 memory-mapped interface. This is useful for\n" > +"trans

Re: [RFC PATCH v3] Xilinx AXI-Stream FIFO v4.1 IP core driver

2018-07-19 Thread Dan Carpenter
I'm getting some compile warnings where we us %u instead of %lu for size_t. We also need a README explaining what else needs to be done before this can be moved out of staging into the normal part of the kernel. On Wed, Jul 18, 2018 at 10:46:34PM -0400, Jacob Feder wrote: > I hope I did the Makef