Re: [RFC PATCH] staging: rtl8192e: Rework EEPROM handling code

2015-07-30 Thread Mateusz Kulikowski
On Thu, Jul 30, 2015 at 07:40:14AM -0700, Greg KH wrote: > On Thu, Jul 30, 2015 at 11:41:46AM +0300, Dan Carpenter wrote: > > On Thu, Jul 30, 2015 at 10:31:04AM +0200, Mateusz Kulikowski wrote: > > > As for other comments - could you take look at "Notes" from patch? > > > This was one of main conce

Re: [RFC PATCH] staging: rtl8192e: Rework EEPROM handling code

2015-07-30 Thread Greg KH
On Thu, Jul 30, 2015 at 11:41:46AM +0300, Dan Carpenter wrote: > On Thu, Jul 30, 2015 at 10:31:04AM +0200, Mateusz Kulikowski wrote: > > As for other comments - could you take look at "Notes" from patch? > > This was one of main concerns for me - Wouldn't it be better > > if I rewrite that code to

Re: [RFC PATCH] staging: rtl8192e: Rework EEPROM handling code

2015-07-30 Thread Dan Carpenter
On Thu, Jul 30, 2015 at 10:31:04AM +0200, Mateusz Kulikowski wrote: > As for other comments - could you take look at "Notes" from patch? > This was one of main concerns for me - Wouldn't it be better > if I rewrite that code to use GPIO/SPI/EEPROM subsystems? I don't know. Let's just merge this

Re: [RFC PATCH] staging: rtl8192e: Rework EEPROM handling code

2015-07-30 Thread Mateusz Kulikowski
On Wed, Jul 29, 2015 at 02:04:42AM +0300, Dan Carpenter wrote: > On Tue, Jul 28, 2015 at 11:52:42PM +0200, Mateusz Kulikowski wrote: > > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_eeprom.c > > b/drivers/staging/rtl8192e/rtl8192e/rtl_eeprom.c > > index ed54193..fe4e282 100644 > > --- a/d

Re: [RFC PATCH] staging: rtl8192e: Rework EEPROM handling code

2015-07-28 Thread Dan Carpenter
On Tue, Jul 28, 2015 at 11:52:42PM +0200, Mateusz Kulikowski wrote: > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_eeprom.c > b/drivers/staging/rtl8192e/rtl8192e/rtl_eeprom.c > index ed54193..fe4e282 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_eeprom.c > +++ b/drivers/staging/rtl81