Re: [PATCHv2 1/2] staging: dgap: cleanup driver module exit and remove function

2015-06-10 Thread Gujulan Elango, Hari Prasath (H.)
On Wed, Jun 10, 2015 at 10:11:37AM +0300, Dan Carpenter wrote: > I mean, yes, it doesn't seem to make much sense to continue polling > after all the hardware has been removed. The problem is that we pass a > pci_dev pointer to dgap_remove_one() and it ignores it and removes > everything. > > Othe

Re: [PATCHv2 1/2] staging: dgap: cleanup driver module exit and remove function

2015-06-10 Thread Sudip Mukherjee
On Wed, Jun 10, 2015 at 10:11:37AM +0300, Dan Carpenter wrote: > > Also this driver has active maintainers but somehow we have CC'd the > ATMEL people who maintain a different staging driver... The original patch had put the maintainers of WILC1000 WIFI DRIVER in the cc list. Now ccing the actual

Re: [PATCHv2 1/2] staging: dgap: cleanup driver module exit and remove function

2015-06-10 Thread Dan Carpenter
I mean, yes, it doesn't seem to make much sense to continue polling after all the hardware has been removed. The problem is that we pass a pci_dev pointer to dgap_remove_one() and it ignores it and removes everything. Otherwise, I would probably suggest that it start polling when the first hardwa

Re: [PATCHv2 1/2] staging: dgap: cleanup driver module exit and remove function

2015-06-09 Thread Sudip Mukherjee
On Wed, Jun 10, 2015 at 04:54:47AM +, Gujulan Elango, Hari Prasath (H.) wrote: > From: Hari Prasath Gujulan Elango > > @@ -7159,8 +7144,9 @@ err_stop: > */ > static void dgap_cleanup_module(void) > { > - if (dgap_numboards) > - pci_unregister_driver(&dgap_driver); > +