Re: [PATCHv2] staging: rtl8192e: fix wrong assignment

2015-05-05 Thread Gujulan Elango, Hari Prasath (H.)
On Tue, May 05, 2015 at 12:19:57PM +0300, Dan Carpenter wrote: > On Mon, May 04, 2015 at 10:17:09PM +0200, Mateusz Kulikowski wrote: > > As far as I know (radio) noise is rarely above 0 dBm - if it is, you're > > doing something wrong. > > This means we can just change rtllib_rx_stats::noise to s8

Re: [PATCHv2] staging: rtl8192e: fix wrong assignment

2015-05-05 Thread Dan Carpenter
On Mon, May 04, 2015 at 10:17:09PM +0200, Mateusz Kulikowski wrote: > As far as I know (radio) noise is rarely above 0 dBm - if it is, you're doing > something wrong. > This means we can just change rtllib_rx_stats::noise to s8. I think it's hard to do that because these definitions are part of t

Re: [PATCHv2] staging: rtl8192e: fix wrong assignment

2015-05-04 Thread Mateusz Kulikowski
Hi, On 04.05.2015 11:29, Gujulan Elango, Hari Prasath (H.) wrote: > This patch addresses a spatch warning on assigning a negative > value to a unsigned integer.Similar patch has been submitted by > Larry Finger earlier to silence the same spatch warning in another > file. > > Signed-off-by: Hari

Re: [PATCHv2] staging: rtl8192e: fix wrong assignment

2015-05-04 Thread Dan Carpenter
On Mon, May 04, 2015 at 09:29:05AM +, Gujulan Elango, Hari Prasath (H.) wrote: > This patch addresses a spatch warning on assigning a negative > value to a unsigned integer.Similar patch has been submitted by > Larry Finger earlier to silence the same spatch warning in another > file. Or, mor