Re: [PATCH v4 2/3] binder: use cred instead of task for getsecid

2021-10-12 Thread Paul Moore
On Tue, Oct 12, 2021 at 5:41 AM Dan Carpenter wrote: > > On Mon, Oct 11, 2021 at 02:59:13PM -0700, Casey Schaufler wrote: > > On 10/11/2021 2:33 PM, Paul Moore wrote: > > > On Wed, Oct 6, 2021 at 8:46 PM Todd Kjos wrote: > > >> Use the 'struct cred' saved at binder_open() to lookup > > >> the sec

Re: [PATCH v4 2/3] binder: use cred instead of task for getsecid

2021-10-12 Thread Dan Carpenter
On Mon, Oct 11, 2021 at 02:59:13PM -0700, Casey Schaufler wrote: > On 10/11/2021 2:33 PM, Paul Moore wrote: > > On Wed, Oct 6, 2021 at 8:46 PM Todd Kjos wrote: > >> Use the 'struct cred' saved at binder_open() to lookup > >> the security ID via security_cred_getsecid(). This > >> ensures that the

Re: [PATCH v4 2/3] binder: use cred instead of task for getsecid

2021-10-11 Thread Paul Moore
On Mon, Oct 11, 2021 at 5:59 PM Casey Schaufler wrote: > On 10/11/2021 2:33 PM, Paul Moore wrote: > > On Wed, Oct 6, 2021 at 8:46 PM Todd Kjos wrote: > >> Use the 'struct cred' saved at binder_open() to lookup > >> the security ID via security_cred_getsecid(). This > >> ensures that the security

Re: [PATCH v4 2/3] binder: use cred instead of task for getsecid

2021-10-11 Thread Casey Schaufler
On 10/11/2021 2:33 PM, Paul Moore wrote: > On Wed, Oct 6, 2021 at 8:46 PM Todd Kjos wrote: >> Use the 'struct cred' saved at binder_open() to lookup >> the security ID via security_cred_getsecid(). This >> ensures that the security context that opened binder >> is the one used to generate the secc

Re: [PATCH v4 2/3] binder: use cred instead of task for getsecid

2021-10-11 Thread Paul Moore
On Wed, Oct 6, 2021 at 8:46 PM Todd Kjos wrote: > > Use the 'struct cred' saved at binder_open() to lookup > the security ID via security_cred_getsecid(). This > ensures that the security context that opened binder > is the one used to generate the secctx. > > Fixes: ec74136ded79 ("binder: create