Re: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init

2017-03-14 Thread Bjorn Helgaas
On Tue, Mar 14, 2017 at 11:50:50AM -0700, Jessica Frazelle wrote: > I can update the patch series, sorry haven't had much time to devote > to this the past few weeks, but will update in the next day. Thanks, Jessica! No problem, I know the feeling :) Bjorn ___

Re: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init

2017-03-14 Thread Jessica Frazelle
I can update the patch series, sorry haven't had much time to devote to this the past few weeks, but will update in the next day. On Tue, Mar 7, 2017 at 11:07 AM, Bjorn Helgaas wrote: > On Thu, Feb 16, 2017 at 03:38:05PM +0100, Thomas Gleixner wrote: >> On Thu, 16 Feb 2017, Bjorn Helgaas wrote: >

Re: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init

2017-03-07 Thread Bjorn Helgaas
On Thu, Feb 16, 2017 at 03:38:05PM +0100, Thomas Gleixner wrote: > On Thu, 16 Feb 2017, Bjorn Helgaas wrote: > > On Wed, Feb 15, 2017 at 10:16:32PM +0100, Thomas Gleixner wrote: > > > > > I think I suggested to Jiang to do that 'update with default functions' to > > > > > > - avoid exporting the

Re: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init

2017-02-16 Thread Thomas Gleixner
On Thu, 16 Feb 2017, Bjorn Helgaas wrote: > On Wed, Feb 15, 2017 at 10:16:32PM +0100, Thomas Gleixner wrote: > > > I think I suggested to Jiang to do that 'update with default functions' to > > > > - avoid exporting the world and some more > > > > - have the flexibility to add new functions to t

Re: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init

2017-02-16 Thread Bjorn Helgaas
On Wed, Feb 15, 2017 at 10:16:32PM +0100, Thomas Gleixner wrote: > I think I suggested to Jiang to do that 'update with default functions' to > > - avoid exporting the world and some more > > - have the flexibility to add new functions to the ops w/o updating a > gazillion of existing usage si

Re: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init

2017-02-15 Thread Thomas Gleixner
On Wed, 15 Feb 2017, Bjorn Helgaas wrote: > We know at build-time what all the function pointers will be, so in > principle we should be able to make the struct const, which would be > even better than __ro_after_init. Not everywhere unfortunately. In some instances it's a runtime decision, but ye

Re: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init

2017-02-15 Thread Kees Cook
On Wed, Feb 15, 2017 at 12:33 PM, Bjorn Helgaas wrote: > [+cc Kees, Thomas, Marc] > > Hi Jess, > > Thanks for the patch! > > On Fri, Feb 10, 2017 at 05:37:56PM -0800, Jess Frazelle wrote: >> Marked msi_domain_ops structs as __ro_after_init when called only during >> init. >> This protects the dat

Re: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init

2017-02-15 Thread Bjorn Helgaas
[+cc Kees, Thomas, Marc] Hi Jess, Thanks for the patch! On Fri, Feb 10, 2017 at 05:37:56PM -0800, Jess Frazelle wrote: > Marked msi_domain_ops structs as __ro_after_init when called only during init. > This protects the data structure from accidental corruption. > > Suggested-by: Kees Cook > S

Re: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init

2017-02-13 Thread Keith Busch
On Fri, Feb 10, 2017 at 05:37:56PM -0800, Jess Frazelle wrote: > Marked msi_domain_ops structs as __ro_after_init when called only during init. > This protects the data structure from accidental corruption. > > Suggested-by: Kees Cook > Signed-off-by: Jess Frazelle > > drivers/pci/host/pci-hype

RE: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init

2017-02-11 Thread KY Srinivasan
> -Original Message- > From: Jess Frazelle [mailto:m...@jessfraz.com] > Sent: Friday, February 10, 2017 5:38 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; Bjorn Helgaas ; Keith > Busch ; open list:Hyper-V CORE AND DRIVERS > ; open list:PCI SUBSYSTEM p...@vger.kernel.or