Re: [PATCH v2 05/06] staging: crypto: skein: rename macros

2014-05-19 Thread Jason Cooper
On Mon, May 19, 2014 at 12:08:39PM +0300, Dan Carpenter wrote: > On Mon, May 19, 2014 at 12:09:58PM +0400, Anton Saraev wrote: > > +/* ignore all asserts, for performance */ > > +#define skein_assert_ret(x, ret_code) > > +#define skein_assert(x) > > Not related to this patch, but defining away ass

Re: [PATCH v2 05/06] staging: crypto: skein: rename macros

2014-05-19 Thread Dan Carpenter
On Mon, May 19, 2014 at 12:09:58PM +0400, Anton Saraev wrote: > +/* ignore all asserts, for performance */ > +#define skein_assert_ret(x, ret_code) > +#define skein_assert(x) Not related to this patch, but defining away asserts like this is a bad idea. What if they have side affects like: