Re: [PATCH v2] staging: gdm72xx: add userspace data struct

2015-12-10 Thread One Thousand Gnomes
On Fri, 11 Dec 2015 00:47:38 +0100 Wim de With wrote: > On Thu, Dec 10, 2015 at 02:44:45PM +, One Thousand Gnomes wrote: > > (except that you mean sizeof(struct fsm_s) and it doesn't compile at the > > moment! > > Oops, sloppy mistake. Compile/test/send - even when in a hurry > > data_s ca

Re: [PATCH v2] staging: gdm72xx: add userspace data struct

2015-12-10 Thread Wim de With
On Thu, Dec 10, 2015 at 02:44:45PM +, One Thousand Gnomes wrote: > (except that you mean sizeof(struct fsm_s) and it doesn't compile at the > moment! Oops, sloppy mistake. > data_s can just be modified to be __user. All uses of it follow that > rule. What do you mean? The data still needs to

Re: [PATCH v2] staging: gdm72xx: add userspace data struct

2015-12-10 Thread One Thousand Gnomes
> if (cmd != SIOCWMIOCTL) > return -EOPNOTSUPP; > @@ -482,8 +483,16 @@ static int gdm_wimax_ioctl(struct net_device *dev, > struct ifreq *ifr, int cmd) > /* NOTE: gdm_update_fsm should be called >* before gdm_wimax_i