Re: [PATCH v2] staging: dgap: fix kernel oops on port open

2014-02-28 Thread Dan Carpenter
On Fri, Feb 28, 2014 at 08:56:37AM -0500, Mark Hounschell wrote: > Thanks Dan. I see what should be done. I like and can work on this. > But is it OK to save all the 80 char problems until the end of this > next series or more likely a separate patch all together? What ever you want to do is ok.

Re: [PATCH v2] staging: dgap: fix kernel oops on port open

2014-02-28 Thread Mark Hounschell
On 02/27/2014 04:52 PM, Dan Carpenter wrote: This isn't a real patch, and it deliberately doesn't compile, but it's sort of what the patch should look like. The first thing to do is to get rid of the stupid DGAP_UNLOCK() macro. Disabling IRQs more than once doesn't help anything and it doesn't m

Re: [PATCH v2] staging: dgap: fix kernel oops on port open

2014-02-27 Thread Dan Carpenter
This isn't a real patch, and it deliberately doesn't compile, but it's sort of what the patch should look like. The first thing to do is to get rid of the stupid DGAP_UNLOCK() macro. Disabling IRQs more than once doesn't help anything and it doesn't make sense to have lock_flags and lock_flags2.

Re: [PATCH v2] staging: dgap: fix kernel oops on port open

2014-02-27 Thread Dan Carpenter
On Thu, Feb 27, 2014 at 03:39:08PM -0500, Mark Hounschell wrote: > On 02/26/2014 10:30 AM, Dan Carpenter wrote: > > On Wed, Feb 26, 2014 at 10:18:26AM -0500, Mark Hounschell wrote: > >> This patch addresses the follow error message followed > >> by a kernel oops: > >> > >> dgap: driver does not set

Re: [PATCH v2] staging: dgap: fix kernel oops on port open

2014-02-27 Thread Greg Kroah-Hartman
On Thu, Feb 27, 2014 at 03:39:08PM -0500, Mark Hounschell wrote: > On 02/26/2014 10:30 AM, Dan Carpenter wrote: > > On Wed, Feb 26, 2014 at 10:18:26AM -0500, Mark Hounschell wrote: > >> This patch addresses the follow error message followed > >> by a kernel oops: > >> > >> dgap: driver does not set

Re: [PATCH v2] staging: dgap: fix kernel oops on port open

2014-02-27 Thread Mark Hounschell
On 02/26/2014 10:30 AM, Dan Carpenter wrote: > On Wed, Feb 26, 2014 at 10:18:26AM -0500, Mark Hounschell wrote: >> This patch addresses the follow error message followed >> by a kernel oops: >> >> dgap: driver does not set tty->port. This will crash the kernel later. Fix >> the driver >> >> It als

Re: [PATCH v2] staging: dgap: fix kernel oops on port open

2014-02-26 Thread Dan Carpenter
On Wed, Feb 26, 2014 at 10:18:26AM -0500, Mark Hounschell wrote: > This patch addresses the follow error message followed > by a kernel oops: > > dgap: driver does not set tty->port. This will crash the kernel later. Fix > the driver > > It also renames the main function this patch addresses bec