Re: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum issues

2014-04-09 Thread David Miller
linux-ker...@vger.kernel.org; >> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; >> jasow...@redhat.com >> Subject: Re: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum >> issues >> >> From: KY Srinivasan >> Date: Wed, 9 Apr 2014 18:08:47 +

RE: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum issues

2014-04-09 Thread KY Srinivasan
; jasow...@redhat.com > Subject: Re: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum > issues > > From: KY Srinivasan > Date: Wed, 9 Apr 2014 18:08:47 + > > > Thanks Dave. I will COW the SKB before changing the checksum value. I > > do have a question thoug

Re: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum issues

2014-04-09 Thread David Miller
From: KY Srinivasan Date: Wed, 9 Apr 2014 18:08:47 + > Thanks Dave. I will COW the SKB before changing the checksum > value. I do have a question though. I looked at a bunch of hardware > drivers and they modify the header information, specially checksum > field and I could not see where the

RE: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum issues

2014-04-09 Thread KY Srinivasan
; jasow...@redhat.com > Subject: Re: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum > issues > > From: "K. Y. Srinivasan" > Date: Tue, 8 Apr 2014 12:46:11 -0700 > > > } else if (net_trans_info & INFO_UDP) { > > - csum_info->trans

Re: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum issues

2014-04-09 Thread David Miller
From: "K. Y. Srinivasan" Date: Tue, 8 Apr 2014 12:46:11 -0700 > } else if (net_trans_info & INFO_UDP) { > - csum_info->transmit.udp_checksum = 1; > + /* UDP checksum offload is not supported on ws2008r2. > + * Furthermore, on ws2012 and ws2012r2, there