RE: [PATCH 3/5] Drivers: hv: vmbus: Fix a bug in hv_need_to_signal_on_read()

2016-03-22 Thread KY Srinivasan
hat.com; sta...@vger.kernel.org > Subject: RE: [PATCH 3/5] Drivers: hv: vmbus: Fix a bug in > hv_need_to_signal_on_read() > > > > > -Original Message- > > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > > Sent: Tuesday, March 22, 2016 2:56 AM >

RE: [PATCH 3/5] Drivers: hv: vmbus: Fix a bug in hv_need_to_signal_on_read()

2016-03-22 Thread KY Srinivasan
nical.com; > jasow...@redhat.com; sta...@vger.kernel.org > Subject: Re: [PATCH 3/5] Drivers: hv: vmbus: Fix a bug in > hv_need_to_signal_on_read() > > KY Srinivasan writes: > > >> -Original Message- > >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > >&

Re: [PATCH 3/5] Drivers: hv: vmbus: Fix a bug in hv_need_to_signal_on_read()

2016-03-22 Thread Vitaly Kuznetsov
driverproject.org; o...@aepfle.de; a...@canonical.com; >> jasow...@redhat.com; sta...@vger.kernel.org >> Subject: Re: [PATCH 3/5] Drivers: hv: vmbus: Fix a bug in >> hv_need_to_signal_on_read() >> >> "K. Y. Srinivasan" writes: >> >> > We need to issue a

RE: [PATCH 3/5] Drivers: hv: vmbus: Fix a bug in hv_need_to_signal_on_read()

2016-03-21 Thread KY Srinivasan
; jasow...@redhat.com; sta...@vger.kernel.org > Subject: Re: [PATCH 3/5] Drivers: hv: vmbus: Fix a bug in > hv_need_to_signal_on_read() > > "K. Y. Srinivasan" writes: > > > We need to issue a full memory barrier prior making a signalling > > decision. >

Re: [PATCH 3/5] Drivers: hv: vmbus: Fix a bug in hv_need_to_signal_on_read()

2016-03-21 Thread Vitaly Kuznetsov
"K. Y. Srinivasan" writes: > We need to issue a full memory barrier prior making a signalling > decision. Any reason this should be mb()? This is pretty strong and will probably lead to performace regression ... and, btw, we have another mb() in hv_ringbuffer_read(). Could you please describe t