Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

2015-02-11 Thread Dan Carpenter
On Wed, Feb 11, 2015 at 01:40:37AM -0800, Joe Perches wrote: > On Wed, 2015-02-11 at 11:33 +0300, Dan Carpenter wrote: > > You can't fight checkpatch.pl. > > Sure you can, Ignore it whenever appropriate. People will just keep sending patches until something gets merged. It's rude to ignore patc

Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

2015-02-11 Thread Joe Perches
On Wed, 2015-02-11 at 11:33 +0300, Dan Carpenter wrote: > On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote: > > >> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct > > >> adapter *adapt, u8 *powerlevel) > > >> ptr++; > > >> } > > >>

Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

2015-02-11 Thread Dan Carpenter
On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote: > >> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter > >> *adapt, u8 *powerlevel) > >> ptr++; > >> } > >> } > >> - rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv

Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

2015-02-10 Thread Greg KH
On Tue, Feb 10, 2015 at 06:32:49PM +0530, Pushpendra Singh wrote: > Removed checkpatch.pl error > ERROR: code indent should use tabs where possible Then fix the indentation with a tab, not using over 8 spaces, don't make this a new coding style issue that I will then get an additional patch for la

Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

2015-02-10 Thread Bas Peters
>> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter >> *adapt, u8 *powerlevel) >> ptr++; >> } >> } >> - rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, >> - &pwrtrac_value

Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

2015-02-10 Thread Sudip Mukherjee
On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote: > >> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter > >> *adapt, u8 *powerlevel) > >> ptr++; > >> } > >> } > >> - rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv

Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

2015-02-10 Thread Sudip Mukherjee
On Tue, Feb 10, 2015 at 06:32:49PM +0530, Pushpendra Singh wrote: > Removed checkpatch.pl error > ERROR: code indent should use tabs where possible > > Signed-off-by: Pushpendra Singh > --- > drivers/staging/rtl8188eu/hal/rf.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff -