Re: [PATCH 2/2] staging: greybus: Added space between string concatenated

2018-12-06 Thread Bryan O'Donoghue
On 06/12/2018 16:23, Greg Kroah-Hartman wrote: On Thu, Dec 06, 2018 at 04:14:53PM +, Bryan O'Donoghue wrote: On 06/12/2018 15:05, Greg Kroah-Hartman wrote: On Thu, Dec 06, 2018 at 09:43:46AM +, Bryan O'Donoghue wrote: On 05/12/2018 21:00, Sicilia Cristian wrote: It doesn't change the

Re: [PATCH 2/2] staging: greybus: Added space between string concatenated

2018-12-06 Thread Greg Kroah-Hartman
On Thu, Dec 06, 2018 at 04:14:53PM +, Bryan O'Donoghue wrote: > On 06/12/2018 15:05, Greg Kroah-Hartman wrote: > > On Thu, Dec 06, 2018 at 09:43:46AM +, Bryan O'Donoghue wrote: > > > On 05/12/2018 21:00, Sicilia Cristian wrote: > > > > It doesn't change the result string > > > > > > So why

Re: [PATCH 2/2] staging: greybus: Added space between string concatenated

2018-12-06 Thread Bryan O'Donoghue
On 06/12/2018 15:05, Greg Kroah-Hartman wrote: On Thu, Dec 06, 2018 at 09:43:46AM +, Bryan O'Donoghue wrote: On 05/12/2018 21:00, Sicilia Cristian wrote: It doesn't change the result string So why do it then ? Because it is easier to read this way and odds are checkpatch is happier. F

Re: [PATCH 2/2] staging: greybus: Added space between string concatenated

2018-12-06 Thread Greg Kroah-Hartman
On Thu, Dec 06, 2018 at 09:43:46AM +, Bryan O'Donoghue wrote: > On 05/12/2018 21:00, Sicilia Cristian wrote: > > It doesn't change the result string > > So why do it then ? Because it is easier to read this way and odds are checkpatch is happier. thanks, greg k-h ___

Re: [PATCH 2/2] staging: greybus: Added space between string concatenated

2018-12-06 Thread Bryan O'Donoghue
On 05/12/2018 21:00, Sicilia Cristian wrote: It doesn't change the result string So why do it then ? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/2] staging: greybus: Added space between string concatenated

2018-12-05 Thread Sicilia Cristian
On Wed, Dec 05, 2018 at 10:12:24AM +, Bryan O'Donoghue wrote: > On 04/12/2018 20:58, Cristian Sicilia wrote: > >Some concatenated strings are now spaced. > > > >Signed-off-by: Cristian Sicilia > >--- > > drivers/staging/greybus/loopback.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 del

Re: [PATCH 2/2] staging: greybus: Added space between string concatenated

2018-12-05 Thread Bryan O'Donoghue
On 04/12/2018 20:58, Cristian Sicilia wrote: Some concatenated strings are now spaced. Signed-off-by: Cristian Sicilia --- drivers/staging/greybus/loopback.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybu