Re: [PATCH 2/2] staging: android: binder: use stack for locally used variable

2014-02-18 Thread SeongJae Park
Hello, On Wed, Feb 19, 2014 at 2:07 AM, Greg KH wrote: > On Tue, Feb 18, 2014 at 08:23:26PM +0900, SeongJae Park wrote: >> The variable `binder_debugfs_dir_entry_root` is declared as static >> global variable although it is accessed from init function only. Declare >> it as init function's local

Re: [PATCH 2/2] staging: android: binder: use stack for locally used variable

2014-02-18 Thread Greg KH
On Tue, Feb 18, 2014 at 08:23:26PM +0900, SeongJae Park wrote: > The variable `binder_debugfs_dir_entry_root` is declared as static > global variable although it is accessed from init function only. Declare > it as init function's local variable because it would be better to read > and memory effic