Re: [PATCH 1/1] staging: wilc1000: Use common structs to parse ip packets

2018-06-05 Thread Dan Carpenter
On Mon, Jun 04, 2018 at 09:27:02PM +0200, Thibaut Robert wrote: > Le lundi 04 juin 2018 à 10:55:49 (+0530), Ajay Singh a écrit : > > > > Thank you for submitting the patches. > > > > The modification in this patch looks okay to me. > > Please resend this by including changes as suggested by Dan.

Re: [PATCH 1/1] staging: wilc1000: Use common structs to parse ip packets

2018-06-04 Thread Thibaut Robert
Le lundi 04 juin 2018 à 10:55:49 (+0530), Ajay Singh a écrit : > > Thank you for submitting the patches. > > The modification in this patch looks okay to me. > Please resend this by including changes as suggested by Dan. > I can do the modification and resubmit this patch by including review > co

Re: [PATCH 1/1] staging: wilc1000: Use common structs to parse ip packets

2018-06-03 Thread Ajay Singh
Thank you for submitting the patches. The modification in this patch looks okay to me. Please resend this by including changes as suggested by Dan. I can do the modification and resubmit this patch by including review comments, if its okay with you. Regards, Ajay

Re: [PATCH 1/1] staging: wilc1000: Use common structs to parse ip packets

2018-05-30 Thread Dan Carpenter
On Tue, May 29, 2018 at 09:08:39PM +0200, Thibaut Robert wrote: > static inline void tcp_process(struct net_device *dev, struct txq_entry_t > *tqe) > { > - u8 *eth_hdr_ptr; > + const struct ethhdr *eth_hdr_ptr = (const struct ethhdr *)tqe->buffer; > + > u8 *buffer = tqe->buffer; N