Re: [PATCH 09/10] staging/android: add flags member to sync ioctl structs

2016-02-01 Thread Gustavo Padovan
2016-01-30 Emil Velikov : > Hi Gustavo, > > > @@ -54,6 +59,7 @@ struct sync_file_info { > > __u32 len; > As mentioned previously - can we rework this variable to indicate the > total length (or the number) of fence_info struct instances. It seems > to be the more common approach afaict.

Re: [PATCH 09/10] staging/android: add flags member to sync ioctl structs

2016-02-01 Thread Maarten Lankhorst
Op 29-01-16 om 22:20 schreef Gustavo Padovan: > From: Gustavo Padovan > > Play safe and add flags member to all structs. So we don't need to > break API or create new IOCTL in the future if new features that requires > flags arises. > This only helps if you reject flags != 0 in the ioctl, else whe

Re: [PATCH 09/10] staging/android: add flags member to sync ioctl structs

2016-01-30 Thread Emil Velikov
Hi Gustavo, > @@ -54,6 +59,7 @@ struct sync_file_info { > __u32 len; As mentioned previously - can we rework this variable to indicate the total length (or the number) of fence_info struct instances. It seems to be the more common approach afaict. Might also want to move it just above th