Re: [PATCH 05/11] staging: iio: ad2s1200: Introduce variable for repeated value

2018-03-24 Thread Jonathan Cameron
On Sat, 24 Mar 2018 13:22:22 +0100 David Julian Veenstra wrote: > On 23, March 2018 14:17, Jonathan Cameron wrote: > > > On Sun, 18 Mar 2018 14:35:46 +0100 > > David Veenstra wrote: > > > >> Add variable to hold &spi->dev in ad2s1200_probe. This value is repeatedly > >> used in ad2s1200_probe

Re: [PATCH 05/11] staging: iio: ad2s1200: Introduce variable for repeated value

2018-03-24 Thread David Julian Veenstra
On 23, March 2018 14:17, Jonathan Cameron wrote: > On Sun, 18 Mar 2018 14:35:46 +0100 > David Veenstra wrote: > >> Add variable to hold &spi->dev in ad2s1200_probe. This value is repeatedly >> used in ad2s1200_probe. >> >> Signed-off-by: David Veenstra > I'm a little unconvinced by this one. I

Re: [PATCH 05/11] staging: iio: ad2s1200: Introduce variable for repeated value

2018-03-23 Thread Jonathan Cameron
On Sun, 18 Mar 2018 14:35:46 +0100 David Veenstra wrote: > Add variable to hold &spi->dev in ad2s1200_probe. This value is repeatedly > used in ad2s1200_probe. > > Signed-off-by: David Veenstra I'm a little unconvinced by this one. It adds code to save a really very trivial bit of repetition.