Re: [PATCH] sysctl: Fix division by zero in percpu_pagelist_fraction handler

2014-06-02 Thread Oleg Drokin
Hello! On Jun 2, 2014, at 11:57 PM, David Rientjes wrote: > I'm pretty sure we want to allow users to restore the kernel default > behavior if they've already written to this file and now want to change it > back. > > What do you think about doing it like this instead? > --- > Documentation/sys

Re: [PATCH] sysctl: Fix division by zero in percpu_pagelist_fraction handler

2014-06-02 Thread Oleg Drokin
Hello! On Jun 2, 2014, at 9:40 PM, David Rientjes wrote: >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index 5dba293..91d0265 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -5854,7 +5854,7 @@ int percpu_pagelist_fraction_sysctl_handler(ctl_table >> *table, int write, >>

Re: [PATCH] sysctl: Fix division by zero in percpu_pagelist_fraction handler

2014-05-03 Thread Greg Kroah-Hartman
On Sat, May 03, 2014 at 09:28:03PM -0400, Oleg Drokin wrote: > percpu_pagelist_fraction_sysctl_handler calls proc_dointvec_minmax > and blindly assumes that return value of 0 means success. > In fact the other valid case is when it got a zero length input. > > After that it proceeds to a division