Re: [PATCH] staging: wfx: fix potential vulnerability to spectre

2019-10-11 Thread Dan Carpenter
On Fri, Oct 11, 2019 at 12:35:36PM +, Jerome Pouiller wrote: > On Friday 11 October 2019 14:10:35 CEST Greg Kroah-Hartman wrote: > > On Fri, Oct 11, 2019 at 10:15:54AM +, Jerome Pouiller wrote: > > > From: Jérôme Pouiller > > > > > > array_index_nospec() should be applied after a bound che

Re: [PATCH] staging: wfx: fix potential vulnerability to spectre

2019-10-11 Thread Jerome Pouiller
On Friday 11 October 2019 14:10:35 CEST Greg Kroah-Hartman wrote: > On Fri, Oct 11, 2019 at 10:15:54AM +, Jerome Pouiller wrote: > > From: Jérôme Pouiller > > > > array_index_nospec() should be applied after a bound check. > > > > Fixes: 9bca45f3d6924f19f29c0d019e961af3f41bdc9e ("staging: wfx:

Re: [PATCH] staging: wfx: fix potential vulnerability to spectre

2019-10-11 Thread Greg Kroah-Hartman
On Fri, Oct 11, 2019 at 10:15:54AM +, Jerome Pouiller wrote: > From: Jérôme Pouiller > > array_index_nospec() should be applied after a bound check. > > Fixes: 9bca45f3d6924f19f29c0d019e961af3f41bdc9e ("staging: wfx: allow to send > 802.11 frames") No need for the full sha1, this should be