Sudip Mukherjee wrote:
> fixed sparse warning : context imbalance in 'destroy_device'
> unexpected unlock
> this patch will generate warning from checkpatch for
> lines over 80 character , but since those are user-visible strings
> so it was not modified.
>
> Signed-off-by
On Wed, Sep 10, 2014 at 08:29:26AM -0500, Romer, Benjamin M wrote:
> On Tue, 2014-09-09 at 16:11 +0530, Sudip Mukherjee wrote:
> > fixed sparse warning : context imbalance in 'resume_device'
> > unexpected unlock
> > this patch will generate warning from checkpatch for
> > l
On Tue, 2014-09-09 at 16:11 +0530, Sudip Mukherjee wrote:
> fixed sparse warning : context imbalance in 'resume_device'
> unexpected unlock
> this patch will generate warning from checkpatch for
> lines over 80 character , but since those are user-visible strings
> so it was
On Mon, 2014-09-08 at 10:24 -0700, Greg Kroah-Hartman wrote:
> If you test it, do a tested-by.
>
> If you sign off on it (i.e. it flows through you to me), then a
> signed-off is correct.
>
> Hope this helps,
>
> greg k-h
It does. :) We should add the Tested-by then, too.
Acked-by: Benjamin Ro
On Mon, Sep 08, 2014 at 12:10:55PM -0500, Romer, Benjamin M wrote:
> On Mon, 2014-09-08 at 10:06 -0700, Greg Kroah-Hartman wrote:
> > Traditionally, you would respond with a:
> > Acked-by: Developer Name
> > so I can add it to the patch.
> >
> > Care to do that here?
> >
> > thanks,
> >
> >
On Mon, 2014-09-08 at 10:06 -0700, Greg Kroah-Hartman wrote:
> Traditionally, you would respond with a:
> Acked-by: Developer Name
> so I can add it to the patch.
>
> Care to do that here?
>
> thanks,
>
> greg k-h
Of course. :)
Acked-by: Benjamin Romer
Should I do this instead of Test
On Mon, Sep 08, 2014 at 10:57:08AM -0500, Romer, Benjamin M wrote:
> On Fri, 2014-09-05 at 14:52 +0530, Sudip Mukherjee wrote:
> > fixed sparse warning : context imbalance in 'pause_device'
> > unexpected unlock
> > this patch will generate warning from checkpatch for
> > line
On Mon, Sep 08, 2014 at 11:48:44AM -0500, Romer, Benjamin M wrote:
> On Mon, 2014-09-08 at 22:08 +0530, Sudip Mukherjee wrote:
> > Hi Ben,
> > sorry to disturb you again. i got confused , which one is perfect one
> > combined patch or
> > separate patches?
> >
> > thanks
> > sudip
>
> Two patch
On Mon, 2014-09-08 at 22:08 +0530, Sudip Mukherjee wrote:
> Hi Ben,
> sorry to disturb you again. i got confused , which one is perfect one
> combined patch or
> separate patches?
>
> thanks
> sudip
Two patches, as you preferred.
-- Ben
___
devel m
On Mon, Sep 08, 2014 at 11:30:48AM -0500, Romer, Benjamin M wrote:
> On Mon, 2014-09-08 at 21:57 +0530, Sudip Mukherjee wrote:
> > Hi Ben,
> > thanks. the same file is having two more similar warnings. if you want i can
> > resend a patch fixing all the three warnings , or i can send two separate
>
On Mon, 2014-09-08 at 21:57 +0530, Sudip Mukherjee wrote:
> Hi Ben,
> thanks. the same file is having two more similar warnings. if you want i can
> resend a patch fixing all the three warnings , or i can send two separate
> patches.
> I personally will prefer two separate patches , as that will b
On Mon, Sep 08, 2014 at 10:57:08AM -0500, Romer, Benjamin M wrote:
> On Fri, 2014-09-05 at 14:52 +0530, Sudip Mukherjee wrote:
> > fixed sparse warning : context imbalance in 'pause_device'
> > unexpected unlock
> > this patch will generate warning from checkpatch for
> > line
On Fri, 2014-09-05 at 14:52 +0530, Sudip Mukherjee wrote:
> fixed sparse warning : context imbalance in 'pause_device'
> unexpected unlock
> this patch will generate warning from checkpatch for
> lines over 80 character , but since those are user-visible strings
> so it was
13 matches
Mail list logo
