Re: [PATCH] staging: rts5208: add check on NULL before dereference

2018-06-12 Thread Dan Carpenter
On Sat, Jun 09, 2018 at 10:34:43PM +0300, Andy Shevchenko wrote: > On Sat, Jun 9, 2018 at 7:58 PM, wrote: > > On 2018-06-09 12:38, Anton Vasilyev wrote: > >> > >> If rtsx_probe fails to allocate dev->chip, then NULL pointer > >> dereference occurs at rtsx_release_resources(). > >> > >> Patch adds

Re: [PATCH] staging: rts5208: add check on NULL before dereference

2018-06-09 Thread okaya
On 2018-06-09 15:34, Andy Shevchenko wrote: On Sat, Jun 9, 2018 at 7:58 PM, wrote: On 2018-06-09 12:38, Anton Vasilyev wrote: If rtsx_probe fails to allocate dev->chip, then NULL pointer dereference occurs at rtsx_release_resources(). Patch adds checks chip on NULL before its dereference at

Re: [PATCH] staging: rts5208: add check on NULL before dereference

2018-06-09 Thread Andy Shevchenko
On Sat, Jun 9, 2018 at 7:58 PM, wrote: > On 2018-06-09 12:38, Anton Vasilyev wrote: >> >> If rtsx_probe fails to allocate dev->chip, then NULL pointer >> dereference occurs at rtsx_release_resources(). >> >> Patch adds checks chip on NULL before its dereference at >> rtsx_release_resources and pa

Re: [PATCH] staging: rts5208: add check on NULL before dereference

2018-06-09 Thread okaya
On 2018-06-09 12:38, Anton Vasilyev wrote: If rtsx_probe fails to allocate dev->chip, then NULL pointer dereference occurs at rtsx_release_resources(). Patch adds checks chip on NULL before its dereference at rtsx_release_resources and passing with dereference inside rtsx_release_chip. Found by