Re: [PATCH] staging: rtl8723bs: fix brace coding style issues

2018-06-26 Thread Andy Shevchenko
On Mon, Jun 25, 2018 at 3:24 PM, Dan Carpenter wrote: > On Mon, Jun 25, 2018 at 12:47:44PM +0300, Andy Shevchenko wrote: >> On Fri, Jun 22, 2018 at 1:28 PM, Dan Carpenter >> wrote: >> > On Thu, Jun 21, 2018 at 08:21:55PM +0200, Michael Straube wrote: >> >> Remove braces from single line if state

Re: [PATCH] staging: rtl8723bs: fix brace coding style issues

2018-06-25 Thread Dan Carpenter
On Mon, Jun 25, 2018 at 12:47:44PM +0300, Andy Shevchenko wrote: > On Fri, Jun 22, 2018 at 1:28 PM, Dan Carpenter > wrote: > > On Thu, Jun 21, 2018 at 08:21:55PM +0200, Michael Straube wrote: > >> Remove braces from single line if statements. > >> Also fix a comparsion to NULL in one of the condi

Re: [PATCH] staging: rtl8723bs: fix brace coding style issues

2018-06-25 Thread Andy Shevchenko
On Fri, Jun 22, 2018 at 1:28 PM, Dan Carpenter wrote: > On Thu, Jun 21, 2018 at 08:21:55PM +0200, Michael Straube wrote: >> Remove braces from single line if statements. >> Also fix a comparsion to NULL in one of the conditions. >> Issues found by checkpatch. >> >> Signed-off-by: Michael Straube

Re: [PATCH] staging: rtl8723bs: fix brace coding style issues

2018-06-23 Thread Dan Carpenter
On Fri, Jun 22, 2018 at 03:27:46PM +0200, Michael Straube wrote: > On 06/22/18 12:28, Dan Carpenter wrote: > > > if (count < 1) > > > return -EFAULT; > > > - if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) { > > > + if (buffer && !copy_from_user(tmp, buffer, siz

Re: [PATCH] staging: rtl8723bs: fix brace coding style issues

2018-06-22 Thread Michael Straube
On 06/22/18 12:28, Dan Carpenter wrote: if (count < 1) return -EFAULT; - if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) { + if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) sscanf(tmp, "%u", &g_wait_hiq_empty); - } The o

Re: [PATCH] staging: rtl8723bs: fix brace coding style issues

2018-06-22 Thread Dan Carpenter
On Thu, Jun 21, 2018 at 08:21:55PM +0200, Michael Straube wrote: > Remove braces from single line if statements. > Also fix a comparsion to NULL in one of the conditions. > Issues found by checkpatch. > > Signed-off-by: Michael Straube > --- > drivers/staging/rtl8723bs/core/rtw_debug.c | 6 ++---