On 07/08/15 at 08:26am, Jes Sorensen wrote:
> Johannes Postma writes:
> > On 06/08/15 at 08:21am, Jes Sorensen wrote:
> >>
> >> Looks OK to me. Probably worth changing the *(usPtr + index) to be
> >> usPtr[index] as well to make the code easier to read.
> >>
> >> Jes
> >>
> >
> > Thank you for
Johannes Postma writes:
> On 06/08/15 at 08:21am, Jes Sorensen wrote:
>>
>> Looks OK to me. Probably worth changing the *(usPtr + index) to be
>> usPtr[index] as well to make the code easier to read.
>>
>> Jes
>>
>
> Thank you for reviewing. I will make a seperate patch for that. I will
> sen
On 06/08/15 at 08:21am, Jes Sorensen wrote:
>
> Looks OK to me. Probably worth changing the *(usPtr + index) to be
> usPtr[index] as well to make the code easier to read.
>
> Jes
>
Thank you for reviewing. I will make a seperate patch for that. I will
send it after this one is accepted. Or s
Johannes Postma writes:
> usPtr is used as __le16 *, but was defined as u16 *.
> This was reported by sparse as:
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1850:29: warning: cast to
> restricted __le16
>
> This patch fixes the type of usPtr.
>
> Signed-off-by: Johannes Postma
> ---
> dr
Juston Li writes:
> change cast to __le16 to fix the following warning:
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1488:20: warning: cast to
> restricted __le16
>
> Signed-off-by: Juston Li
> ---
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +-
> 1 file changed, 1 insertion(
Marcus Folkesson writes:
> This patch fixes the following sparse warnings:
>
> CHECK drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:265:37: warning:
> cast to restricted __le16
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:267:
Aleh Suprunovich writes:
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:747:1: warning: symbol
> 'rtl8723a_EfusePgPacketRead' was not declared. Should it be static?
>
> Function 'rtl8723a_EfusePgPacketRead' seems to be unused in current
> staging code.
>
> Before, it was available as 'static
Clement Calmels writes:
> From: Clément Calmels
>
> Found running sparse on the rtl8723au driver.
>
> CHECK drivers/staging/rtl8723au/core/rtw_cmd.c
> drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54: warning: incorrect type in
> argument 2 (different base types)
> drivers/staging/rtl8723au/
On Thu, May 15, 2014 at 10:43:34PM +0200, Konrad Zapalowicz wrote:
> This commit fixes the following sparse warning:
>
> drivers/staging/rtl8723au/os_dep/os_intfs.c:
> - 322:14: warning: restricted __be16 degrades to integer
>
> Signed-off-by: Konrad Zapalowicz
> ---
> drivers/staging/rtl87
