On 15/05/15 04:26, Johannes Berg wrote:
> On Thu, 2015-05-14 at 19:03 -0300, Gaston Gonzalez wrote:
>
>> If Dan is a newbie to this, I would be a pre-under-newbie or something
>> below that. That being said, understood your explication, I'll look for
>> another way to deal with this warning.
> I do
On Thu, 2015-05-14 at 19:03 -0300, Gaston Gonzalez wrote:
> If Dan is a newbie to this, I would be a pre-under-newbie or something
> below that. That being said, understood your explication, I'll look for
> another way to deal with this warning.
I don't even see your original patch, so I have no
On 14/05/15 16:35, Johannes Berg wrote:
> On Wed, 2015-05-13 at 22:04 -0300, Gaston Gonzalez wrote:
>
>> .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 53
>> ++
>> include/net/mac80211.h | 3 ++
>> net/mac80211/tkip.c
On 05/14/2015 02:35 PM, Johannes Berg wrote:
On Wed, 2015-05-13 at 22:04 -0300, Gaston Gonzalez wrote:
.../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 53
++
include/net/mac80211.h | 3 ++
net/mac80211/tkip.c
On Wed, 2015-05-13 at 22:04 -0300, Gaston Gonzalez wrote:
> .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 53
> ++
> include/net/mac80211.h | 3 ++
> net/mac80211/tkip.c| 9 ++--
> 3 files changed, 10 inserti
Thanks Johannes.
I'm a total newbie to networking so I don't get offended when the
experts tell me I'm wrong. :) We'll look at the things you suggested.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linux
On Wed, May 13, 2015 at 10:04:14PM -0300, Gaston Gonzalez wrote:
> @@ -327,7 +280,7 @@ static int ieee80211_tkip_encrypt(struct sk_buff
> *skb, int hdr_len, void *priv)
> tkey->tx_iv32);
> tkey->tx_phase1_done = 1;
> }
> -tkip_mixing_phase2(rc4key,
On 13/05/15 05:36, Dan Carpenter wrote:
> How come you didn't use my patch as a base to work from, you shouldn't
> be passing tkip_ctx at all.
Hi Dan, my mistake. To be honest I assumed that the idea was not to
touch tkip.c at all, that's why I had to pass tkip_ctx... sorry about
that :-(
Coming b
What? No, that patch can't work at all. It will just oops directly
when you do:
> +memcpy(&tx->p1k, &tkey->tx_ttak, p1k_len);
How come you didn't use my patch as a base to work from, you shouldn't
be passing tkip_ctx at all.
regards,
dan carpenter
_
Hi Gaston,
A couple of minor style comments:
On Wed, May 13, 2015 at 8:23 AM, Gaston Gonzalez wrote:
> On 08/05/15 08:03, Dan Carpenter wrote:
>> To be honest, I'm a little bit a newbie myself when it comes to
>> linux-wireless so keep that in mind. ;) Changing the parameters seems
>> simple e
On 08/05/15 08:03, Dan Carpenter wrote:
> To be honest, I'm a little bit a newbie myself when it comes to
> linux-wireless so keep that in mind. ;) Changing the parameters seems
> simple enough. But it needs to an EXPORT_SYMBOL() and to be declared in
> a header file and I'm not sure what else.
To be honest, I'm a little bit a newbie myself when it comes to
linux-wireless so keep that in mind. ;) Changing the parameters seems
simple enough. But it needs to an EXPORT_SYMBOL() and to be declared in
a header file and I'm not sure what else. But we have four
implementations of this functi
On 27/04/15 07:12, Dan Carpenter wrote:
> Can't we just export the tkip.c function?
>
> regards,
> dan carpenter
>
Hi Dan,
(sorry for the delayed response)
The inputs of the two implementations of tkip_mixing_phase2() differ in
one parameter:
- ieee80211_crypt_tkip.c expects 'const u16 *TTAK'
Can't we just export the tkip.c function?
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 20/04/15 05:24, Dan Carpenter wrote:
> Mk16_le() is a bad function name and as we can see from tkip.c it just
> duplicates get_unaligned_le16(). Better to make TK void pointer instead
> of a u8 pointer (because it doesn't point to u8s so we have to cast it
> every time we use it). This is anot
On Sun, Apr 19, 2015 at 05:43:51PM -0300, Gaston Gonzalez wrote:
> Silence the following sparse warning:
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:184:16: warning:
> cast to restricted __le16
>
We have a tkip_mixing_phase2() function in net/mac80211/tkip.c. That's
probably
16 matches
Mail list logo
