On Mon, Jan 03, 2022 at 12:11:32PM +0100, Alberto Merciai wrote:
> Replace camelcase field CustomerID to customer_id, compliant
> with linux kernel coding style.
Apologize, don't consider it, wrong branch was used.
Regards,
Alberto Merciai
___
devel ma
I have built the file without any errors. I did not need to make any changes.
I apologise for not building my changes. I shall not repeat it again.
Should I create a v2 patch and resend, or will we continue from this patch ?
Thanks,
Benjamin Philip
___
On Wed, Jul 21, 2021 at 04:28:09PM +0530, Benjamin Philip wrote:
> This commit fixes some checkpatch checks for blank lines before
> and after braces in drivers/staging/rtl8188eu/core/rtw_ap.c
>
> Signed-off-by: Benjamin Philip
> ---
>
> This patch fixes some checkpatch.pl CHECKs for blank lines
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:
s/pasive/passive/
Also need to s/varable/variable/
Signed-off-by: Bhaskar Chowdhury
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
On Fri, Mar 5, 2021 at 12:33 PM Dan Carpenter wrote:
>
> It's good that you're reviewing code...
Right now watching the patches flow feels like I'm just shadowing.
Later, when I get the hang of it, I might try providing something on
my own. I'll just watch things from a distance for the time bein
On Fri, Mar 05, 2021 at 10:58:17AM -0600, Edmundo Carmona Antoranz wrote:
> On Fri, Mar 5, 2021 at 2:59 AM Dan Carpenter wrote:
> > - if (sec_len > 0 && sec_len <= len) {
> > + if (sec_len > 0 &&
> > +
On Fri, Mar 5, 2021 at 2:59 AM Dan Carpenter wrote:
> - if (sec_len > 0 && sec_len <= len) {
> + if (sec_len > 0 &&
> + sec_len <= len &&
> +
On Thu, Feb 18, 2021 at 10:50:43PM +0530, Suryashankar Das wrote:
> This patch fixes the checkpatch.pl warnings:
> WARNING: Block comments use * on subsequent lines
> WARNING: Block comments should align the * on each line
>
> Signed-off-by: Suryashankar Das
> ---
> drivers/staging/rtl8188eu/cor
On 2/4/21 2:52 AM, Martin Kaiser wrote:
The Edimax EW-7811UN V2 uses an RTL8188EU chipset and works with this
driver.
Signed-off-by: Martin Kaiser
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
On Tue, Oct 20, 2020 at 08:17:48AM -0700, Elena Afanasova wrote:
> Reported by checkpatch.pl
>
If I were trying to clean up this driver I would probably take a
different approach.
Just send a patch that introduces line breaks for RT_TRACE() printks.
The RT_TRACE() printks are super ugly, and if
> I review things in the order that they appear in my inbox so I hadn't
> seen Greg and Larry's comments. You've now stumbled into an area of
> politics where you have conflicting reviews... :P Fortunately, we're
> all of us reasonable people.
>
> I think your patch is correct in that it is wha
>
> Yes, in this routine, it would be possible for authmode to not be set;
> however,
> later code only compares it to either _WPA_IE_ID_ or _WPA2_IE_ID_. It is
> never
> used in a way that an unset value could make the program flow be different by
> arbitrarily setting the value to zero. Thu
I review things in the order that they appear in my inbox so I hadn't
seen Greg and Larry's comments. You've now stumbled into an area of
politics where you have conflicting reviews... :P Fortunately, we're
all of us reasonable people.
I think your patch is correct in that it is what the origin
On Fri, Jul 24, 2020 at 08:29:55PM +0800, Dinghao Liu wrote:
> The variable authmode will keep uninitialized if neither if
> statements used to initialize this variable are not triggered.
> Then authmode may contain a garbage value and influence the
> execution flow of this function.
>
> Fix this
On 7/24/20 8:28 AM, Dinghao Liu wrote:
The variable authmode will keep uninitialized if neither if
statements used to initialize this variable are not triggered.
Besides Greg's comment, you need to re-parse this sentence. I realize that
English is probably not your first language, but this one
On Fri, Jul 24, 2020 at 08:29:55PM +0800, Dinghao Liu wrote:
> The variable authmode will keep uninitialized if neither if
> statements used to initialize this variable are not triggered.
> Then authmode may contain a garbage value and influence the
> execution flow of this function.
>
> Fix this
On Sun, Jul 19, 2020 at 11:24:37AM +0200, Greg KH wrote:
> On Sat, Jul 18, 2020 at 04:01:25PM +0530, Anoop1507 wrote:
> > From: Anoop S
> >
> > This fixes the following checkpatch.pl warning
> > WARNING: Prefer using '"%s...", __func__' to using 'rtw_tkip_decrypt', this
> > function's name, in a
On Sat, Jul 18, 2020 at 04:01:25PM +0530, Anoop1507 wrote:
> From: Anoop S
>
> This fixes the following checkpatch.pl warning
> WARNING: Prefer using '"%s...", __func__' to using 'rtw_tkip_decrypt', this
> function's name, in a string.
>
> Signed-off-by: Anoop S
It would be great to have your
On Wed, Jul 15, 2020 at 02:55:59AM +0530, Arpitha wrote:
> Fixing WARNING: Prefer using '"%s...", __func__' to using 'function_name'
> in a string in rtw_ioctl_set.c
>
> Signed-off-by: Arpitha <98.a...@gmail.com>
We need a "full" name for kernel patches, what you use to sign
documents.
Same for
On Thu, Jul 02, 2020 at 07:15:56AM -0400, B K Karthik wrote:
> added blank spaces to improve code readability. (coding style issue)
>
> Signed-off-by: B K Karthik
> ---
> drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> d
On Thu, Jul 02, 2020 at 12:50:04AM -0400, B K Karthik wrote:
> add blank spaces for improved code readability.
>
> Signed-off-by: B K Karthik
> ---
> drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/in
On Thu, Jul 02, 2020 at 12:48:42AM -0400, B K Karthik wrote:
> added blank spaces to improve code readability.
>
> Signed-off-by: B K Karthik
> ---
> drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/s
On 2020-06-29 10:09, B K Karthik wrote:
removed multiple blank lines to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/ieee80211.h | 9 -
1 file changed, 9 deletions(-)
Hi, those lines are already removed in
commit 5bfb7eadc5874a3a08dd
On Sat, Jun 27, 2020 at 05:15:44PM +0200, Michael Straube wrote:
> @@ -145,21 +138,7 @@ struct bb_reg_def {
>*/
> };
>
> -/*--Define
> structure*/
> -
> -
> -/*Export global
> variab
On Sun, 2020-05-24 at 10:27 +0200, Michael Straube wrote:
> Clean up some array declarations in phy_iq_calibrate() to reduce
> indentation and clear line over 80 characters checkpatch warnings.
Better still would be to mark these as static const
and also mark the functions that use them to take
co
On Sat, May 09, 2020 at 03:19:31PM +0800, Qiuhao Li wrote:
> According to Documentation/timers/timers-howto.rst, sleeping for small
> milliseconds should use usleep_range() instead of msleep().
>
> Signed-off-by: Qiuhao Li
> ---
> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 3 ++-
> 1 file c
On Sun, Mar 29, 2020 at 12:04:50PM +0200, Michael Straube wrote:
> Refactor while loop in Efuse_GetCurrentSize() to reduce indentation
> level and clear line over 80 characters checkpatch warnings.
>
> Signed-off-by: Michael Straube
Reviewed-by: Dan Carpenter
regards,
dan carpenter
__
On 2020-03-26 01:08, Joe Perches wrote:
On Wed, 2020-03-25 at 22:59 +0100, Michael Straube wrote:
Cleanup line over 80 characters by removing unnecessary parentheses.
[]
diff --git a/drivers/staging/rtl8188eu/hal/odm.c
b/drivers/staging/rtl8188eu/hal/odm.c
[]
@@ -590,7 +590,7 @@ void odm
On Wed, 2020-03-25 at 22:59 +0100, Michael Straube wrote:
> Cleanup line over 80 characters by removing unnecessary parentheses.
[]
> diff --git a/drivers/staging/rtl8188eu/hal/odm.c
> b/drivers/staging/rtl8188eu/hal/odm.c
[]
> @@ -590,7 +590,7 @@ void odm_CCKPacketDetectionThresh(struct odm_dm_st
On Wed, Mar 11, 2020 at 01:23:32AM +, Thiago Souza Ferreira wrote:
> Fix "Block comments use * on subsequent lines" warning of
> rtw_mlme_ext.c, found by checkpatch.pl script
>
> Signed-off-by: Thiago Souza Ferreira
> ---
> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 69 ++---
On 10/1/19 6:11 AM, Dan Carpenter wrote:
There is another one earlier in the function as well.
drivers/staging/rtl8188eu/os_dep/usb_intf.c
336
337 pnetdev = rtw_init_netdev(padapter);
338 if (!pnetdev)
339 goto free_adapter;
340 SE
On Fri, Sep 27, 2019 at 02:44:15PM -0700, Connor Kuehl wrote:
> If kzalloc() returns NULL, the error path doesn't stop the flow of
> control from entering rtw_hal_read_chip_version() which dereferences the
> null pointer. Fix this by adding a 'goto' to the error path to more
> gracefully handle the
Hi,
[This is an automated email]
This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all
The bot has tested the following trees: v5.3.1, v5.2.17, v4.19.75, v4.14.146,
v4.9.194, v4.4.194.
v5.3.1: Build OK!
v5.2.1
On 9/26/19 2:31 AM, Denis Efremov wrote:
It's incorrect to compare HighestRate with 0x0b twice in the following
manner "if (HighestRate > 0x0b) ... else if (HighestRate > 0x0b) ...". The
"else if" branch is constantly false. The second comparision should be
with 0x03 according to the max_rate_idx
On 9/25/19 5:05 PM, Larry Finger wrote:
This change is a good one, but why not get the same fix at line 779?
Ah yes! Thanks for pointing that out. I missed that. I will send a V2
shortly.
Thank you,
Connor
Larry
___
devel mailing list
de...@
On 9/25/19 4:32 PM, Connor Kuehl wrote:
Inside a nested 'else' block at the beginning of this function is a
call that assigns 'psta' to the return value of 'rtw_get_stainfo()'.
If 'rtw_get_stainfo()' returns NULL and the flow of control reaches
the 'else if' where 'psta' is dereferenced, then we
On Mon, Sep 23, 2019 at 03:38:39PM -0500, Larry Finger wrote:
> This patch is correct; however, the do..while loop will always be executed
s/correct/harmless/.
> once, thus you could remove the loop and the loop variable bcmd_down.
>
> @greg: If you would prefer a two-step process, then this one
On Mon, Sep 23, 2019 at 12:48:06PM -0700, Connor Kuehl wrote:
> @@ -103,7 +102,7 @@ static s32 FillH2CCmd_88E(struct adapter *adapt, u8
> ElementID, u32 CmdLen, u8 *p
> adapt->HalData->LastHMEBoxNum =
> (h2c_box_num+1) % RTL88E_MAX_H2C_BOX_NUMS;
>
> - } wh
On 9/23/19 1:38 PM, Larry Finger wrote:
On 9/23/19 2:48 PM, Connor Kuehl wrote:
The local variable 'bcmd_down' is always set to true almost immediately
before the do-while's condition is checked. As a result, !bcmd_down
evaluates to false which short circuits the logical AND operator meaning
tha
On 9/23/19 2:48 PM, Connor Kuehl wrote:
The local variable 'bcmd_down' is always set to true almost immediately
before the do-while's condition is checked. As a result, !bcmd_down
evaluates to false which short circuits the logical AND operator meaning
that the second operand is never reached and
On 9/6/19 12:39 PM, Colin King wrote:
From: Colin Ian King
Don't populate two arrays on the stack but instead make them
static const. Makes the object code smaller by 49 bytes.
Before:
text data bss dec hex filename
26821 5616 0 324377eb5 rtl8
Looks good.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Aug 06, 2019 at 05:24:38PM +0530, Merwin Trever Ferrao wrote:
> Fixed WARNING: else is not generally useful after a break or return
> ---
Much better, but you forgot the the Signed-off-by so we can't apply it.
Also it's nice to be more specific with the subject.
[PATCH] Staging: rtl8188eu
1) Fix the From header.
2) Fix the subject.
3) Add a blank line after the subject.
4) Split the path up into multiple patches that each do one kind of
change.
On Mon, Aug 05, 2019 at 01:22:56PM +0530, merwintf wrote:
> Signed-off-by: merwintf
Use your real name like
On Mon, Aug 05, 2019 at 01:22:56PM +0530, merwintf wrote:
> Signed-off-by: merwintf
> ---
> drivers/staging/rtl8188eu/core/rtw_security.c | 525 +++---
> 1 file changed, 334 insertions(+), 191 deletions(-)
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent h
On Tue, Jun 04, 2019 at 01:42:22PM +0530, Nishka Dasgupta wrote:
> Remove function rtw_free_network_nolock, as all it does is call
> _rtw_free_network_nolock, and rename _rtw_free_network_nolock to
> rtw_free_network_nolock.
>
> Signed-off-by: Nishka Dasgupta
> ---
> drivers/staging/rtl8188eu/co
On Wed, Mar 13, 2019 at 12:11:30PM -0500, Aditya Pakki wrote:
> hwxmits is allocated via kcalloc and not checked for failure before its
> dereference. The patch fixes this problem similar to rtl8723bs.
>
> Signed-off-by: Aditya Pakki
> ---
> drivers/staging/rtl8188eu/core/rtw_xmit.c | 4
>
On 1/7/19 11:28 AM, Michael Straube wrote:
This device was added to the stand-alone driver on github.
Add it to the staging driver as well.
Link: https://github.com/lwfinger/rtl8188eu/commit/a0619a07cd1e
Signed-off-by: Michael Straube
Acked-by: Larry Finger
Thanks,
Larry
__
Yes, you are right.
I will send a patch to revert ef9209b642f.
Young
On 2018/11/27 16:49, Dan Carpenter wrote:
> On Tue, Nov 27, 2018 at 08:41:53AM +, Yang Xiao wrote:
>> Okay. I can send a patch to revert ef9209b642f.
>>
>> But, can you make sure that the condition "(pstapriv->sta_aid[pstat
On Tue, Nov 27, 2018 at 08:41:53AM +, Yang Xiao wrote:
> Okay. I can send a patch to revert ef9209b642f.
>
> But, can you make sure that the condition "(pstapriv->sta_aid[pstat->aid
> - 1] == NULL)" can satisfies in the for loop?
->max_num_sta is either set in _rtw_init_sta_priv() or rtw_set
Okay. I can send a patch to revert ef9209b642f.
But, can you make sure that the condition "(pstapriv->sta_aid[pstat->aid
- 1] == NULL)" can satisfies in the for loop?
Young
On 2018/11/27 16:34, Dan Carpenter wrote:
> On Tue, Nov 27, 2018 at 08:29:05AM +, Yang Xiao wrote:
>> Hi,
>>
>> See co
On Tue, Nov 27, 2018 at 08:29:05AM +, Yang Xiao wrote:
> Hi,
>
> See commit ef9209b642f ("staging: rtl8723bs: Fix indenting errors and an
> off-by-one mistake in core/rtw_mlme_ext.c") for detail.
>
> I don't know how can you make sure that line 3254 can be true in the for
> loop. If the co
Hi,
See commit ef9209b642f ("staging: rtl8723bs: Fix indenting errors and an
off-by-one mistake in core/rtw_mlme_ext.c") for detail.
I don't know how can you make sure that line 3254 can be true in the for
loop. If the condition never satisfies, then there is an off-by-one
access in line 3267
The original code is OK.
On Tue, Nov 27, 2018 at 07:29:07AM +, Yang Xiao wrote:
> From: Young_X
>
> The error at line 3267 was the result of an off-by-one error in
> a for loop in line 3253.
> If condition in line 3254 never satisfies, then the value of
> pstat->aid is NUM_ST
On Tue, Nov 27, 2018 at 07:29:07AM +, Yang Xiao wrote:
> From: Young_X
Please use your "full" name like you did in your from: line of your
email
>
> The error at line 3267 was the result of an off-by-one error in
> a for loop in line 3253.
> If condition in line 3254 never satis
On Tue, Nov 13, 2018 at 10:06:13PM +0800, Kevin Dou wrote:
> follow the linux coding style, rename the variable
> shortGIrate to short_gi_rate.
>
> Signed-off-by: Kevin Dou
> ---
> drivers/staging/rtl8188eu/core/rtw_ap.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
Hi,
This
On 11/1/18 4:50 PM, Yangtao Li wrote:
Signed-off-by: Yangtao Li
---
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm_rtl8188e.c
b/drivers/staging/rtl8188eu/hal/odm_rtl8188e.c
index d5001920f77c.
On Thu, Sep 27, 2018 at 03:52:53PM -0500, Larry Finger wrote:
> On 9/27/18 12:04 PM, Aymen Qader wrote:
> > Avoid null pointer arithmetic in rtw_mlme_ext.c by skipping other field
> > checks if the information element pointer is null.
> >
> > Signed-off-by: Aymen Qader
> > ---
> > drivers/stagi
On 9/27/18 12:04 PM, Aymen Qader wrote:
Avoid null pointer arithmetic in rtw_mlme_ext.c by skipping other field
checks if the information element pointer is null.
Signed-off-by: Aymen Qader
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletio
On Tue, Sep 25, 2018 at 09:07:11PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Sep 20, 2018 at 05:22:21PM -0700, Nathan Chancellor wrote:
> > Clang generates a warning when it sees a logical not followed by a
> > conditional operator like ==, >, or < because it thinks that the logical
> > not should
On Thu, Sep 20, 2018 at 05:22:21PM -0700, Nathan Chancellor wrote:
> Clang generates a warning when it sees a logical not followed by a
> conditional operator like ==, >, or < because it thinks that the logical
> not should be applied to the whole statement:
>
> drivers/staging/rtl8188eu/core/rtw_
It's better to just delete these.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, Sep 14, 2018 at 05:58:58PM +0200, Robert Węcławski wrote:
> > On Thu, Sep 13, 2018 at 10:32:39PM +0200, Robert Węcławski wrote:
> > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> > > b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> > > index eca06f05c0c4..b610443f2ac6 100644
> > >
> On Thu, Sep 13, 2018 at 10:32:39PM +0200, Robert Węcławski wrote:
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> > b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> > index eca06f05c0c4..b610443f2ac6 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> > +++ b/drivers/staging/r
On Thu, Sep 13, 2018 at 10:32:39PM +0200, Robert Węcławski wrote:
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> index eca06f05c0c4..b610443f2ac6 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8188eu/cor
On Mon, 2018-09-10 at 22:38 +0200, Michael Straube wrote:
> The the last two parameters of write_cam() have type u8.
> Change the type of the passed arrays from unsigned char to u8.
> Clears a line over 80 characters checkpatch warning.
>
> Signed-off-by: Michael Straube
> ---
> drivers/staging/
On Wed, Aug 22, 2018 at 02:35:32PM +0530, Bhaskar Singh wrote:
> On Wed, Aug 22, 2018 at 11:16:36AM +0300, Dan Carpenter wrote:
> > On Tue, Aug 21, 2018 at 07:14:28AM +0530, Bhaskar Singh wrote:
> > > This patch fix spelling mistakes in TODO.
> > >
> >
> > Btw, it helps when you say which word yo
On Wed, Aug 22, 2018 at 11:16:36AM +0300, Dan Carpenter wrote:
> On Tue, Aug 21, 2018 at 07:14:28AM +0530, Bhaskar Singh wrote:
> > This patch fix spelling mistakes in TODO.
> >
>
> Btw, it helps when you say which word you're changing, otherwise it
> takes a while to spot the difference. We cha
On Tue, Aug 21, 2018 at 07:14:28AM +0530, Bhaskar Singh wrote:
> This patch fix spelling mistakes in TODO.
>
Btw, it helps when you say which word you're changing, otherwise it
takes a while to spot the difference. We changed "HGz" to "GHz".
Probably someone smarter than I am would have spotted
On Mon, Aug 20, 2018 at 12:35:46PM +0300, Dan Carpenter wrote:
> On Sun, Aug 19, 2018 at 12:36:40AM +0530, Bhaskar Singh wrote:
> > This patch removed function named rtw_malloc2d.
> >
> > I removed this function because this function is used exactly once and
> > function call have some overhead al
On Mon, Aug 20, 2018 at 06:25:39PM +0530, Bhaskar Singh wrote:
> On Mon, Aug 20, 2018 at 12:50:43PM +0300, Dan Carpenter wrote:
> > On Fri, Aug 17, 2018 at 01:17:29PM +0530, Bhaskar Singh wrote:
> > > This patch removed code which are valid for IEEE 802.11a i.e. 5GHz.
> >
> > I would be uncomforta
On Mon, Aug 20, 2018 at 12:50:43PM +0300, Dan Carpenter wrote:
> On Fri, Aug 17, 2018 at 01:17:29PM +0530, Bhaskar Singh wrote:
> > This patch removed code which are valid for IEEE 802.11a i.e. 5GHz.
>
> I would be uncomfortable accepting this kind of change without an Ack
> from the maintainers.
On Fri, Aug 17, 2018 at 01:17:29PM +0530, Bhaskar Singh wrote:
> This patch removed code which are valid for IEEE 802.11a i.e. 5GHz.
I would be uncomfortable accepting this kind of change without an Ack
from the maintainers.
The messes up the indenting so we can accept it anyway.
regards,
dan ca
On Sat, Aug 18, 2018 at 07:54:09PM +0530, Bhaskar Singh wrote:
> This patch might suppress some warrning.
>
Which warning? You should find out which program is generating the
warning and delete it from your computer because that is a nonsense
warning.
regards,
dan carpenter
___
On Sun, Aug 19, 2018 at 12:36:40AM +0530, Bhaskar Singh wrote:
> This patch removed function named rtw_malloc2d.
>
> I removed this function because this function is used exactly once and
> function call have some overhead also.
>
> Maybe this will improve code runtime slightly.
>
> Signed-off-b
On Sat, 2018-08-18 at 20:28 +0530, Bhaskar Singh wrote:
> On Sat, Aug 18, 2018 at 10:33:31PM +0800, zhong jiang wrote:
> > On 2018/8/18 22:24, Bhaskar Singh wrote:
> > > This patch might suppress some warrning.
> > >
> > > The function prototype of rtw_malloc2d is
> > >
> > > void *rtw_malloc2d(i
On Sat, Aug 18, 2018 at 10:33:31PM +0800, zhong jiang wrote:
> On 2018/8/18 22:24, Bhaskar Singh wrote:
> > This patch might suppress some warrning.
> >
> > The function prototype of rtw_malloc2d is
> >
> > void *rtw_malloc2d(int h, int w, int size)
> >
> > This patch also resolves the checkpatch.p
On 2018/8/18 22:24, Bhaskar Singh wrote:
> This patch might suppress some warrning.
>
> The function prototype of rtw_malloc2d is
>
> void *rtw_malloc2d(int h, int w, int size)
>
> This patch also resolves the checkpatch.pl warning
>
> WARNING: line over 80 characters
>
> Signed-off-by: Bhaskar Sin
On Wed, Jul 11, 2018 at 09:24:09PM +0200, Kacper Kołodziej wrote:
> Signed-off-by: Kacper Kołodziej
Sorry, but I need a changelog text in order to be able to take a patch.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://dri
On Sat, Jul 07, 2018 at 01:22:50PM +0200, Michael Straube wrote:
> Simplify rtw_get_rateset_len() by replacing the while loop
> with a shorter for loop. Also replace tabs with spaces in
> the definition line.
Normally I will insist that this be two separate patches, as you are
doing two different
On 07/01/18 11:14, Andy Shevchenko wrote:
On Sat, Jun 30, 2018 at 5:59 PM, Michael Straube
wrote:
The header rtw_ioctl_rtl.h is not used anywhere.
Running 'grep -r rtw_ioctl_rtl *' from kernel root
directory returns nothing, remove the file.
Just a side note, using `git grep` is much more eff
On Sat, Jun 30, 2018 at 5:59 PM, Michael Straube
wrote:
> The header rtw_ioctl_rtl.h is not used anywhere.
> Running 'grep -r rtw_ioctl_rtl *' from kernel root
> directory returns nothing, remove the file.
Just a side note, using `git grep` is much more efficient against
kernel source tree.
Somet
Thanks!
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sat, Nov 25, 2017 at 11:59:51AM -0600, Larry Finger wrote:
> When not associated with an AP, wifi device drivers should respond to the
> SIOCGIWESSID ioctl with a zero-length string for the SSID, which is the
> behavior expected by dhcpcd.
>
> Currently, this driver returns an error code (-1) f
Hi Ishraq,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.14 next-20171124]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/
Hi Ishraq,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.14 next-20171124]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/
On Thu, Nov 23, 2017 at 02:29:06AM +0100, ishraq.i.ash...@gmail.com wrote:
> From: Ishraq Ibne Ashraf
>
> Commit 8bfb36766064 ("wireless: wext: remove ndo_do_ioctl fallback") breaks
> private WEXT
> IOCTL calls of this driver as these are not invoked through ndo_do_ioctl
> interface anymore. As
On Wed, Oct 4, 2017 at 8:11 PM, Julia Lawall wrote:
>
>
> On Wed, 4 Oct 2017, Dan Carpenter wrote:
>
>> On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote:
>> >
>> >
>> > On Wed, 4 Oct 2017, Dan Carpenter wrote:
>> >
>> > > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote:
On Wed, 4 Oct 2017, Dan Carpenter wrote:
> On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote:
> >
> >
> > On Wed, 4 Oct 2017, Dan Carpenter wrote:
> >
> > > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote:
> > > > Use list_for_each_entry_safe when the list elements may
On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote:
>
>
> On Wed, 4 Oct 2017, Dan Carpenter wrote:
>
> > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote:
> > > Use list_for_each_entry_safe when the list elements may get deleted
> > > during traversal.
> >
> > This patch
On Wed, 4 Oct 2017, Dan Carpenter wrote:
> On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote:
> > Use list_for_each_entry_safe when the list elements may get deleted
> > during traversal.
>
> This patch is fine as a cleanup but none of these are actually buggy.
I'm not sure what yo
On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote:
> Use list_for_each_entry_safe when the list elements may get deleted
> during traversal.
This patch is fine as a cleanup but none of these are actually buggy.
regards,
dan carpenter
___
d
On Thu, Jul 27, 2017 at 09:33:45AM -0500, Deb McLemore wrote:
> checkpatch.pl open brace following function declaration goes on
> next line so fix the brace to go properly on next line
>
> Signed-off-by: Deb McLemore
> ---
> drivers/staging/rtl8188eu/include/rtw_ioctl.h | 3 ++-
> 1 file changed
On Sat, Jul 01, 2017 at 04:11:33PM +0530, saloni1996 wrote:
> Remove Camel Case warning found using checkpatch.pl
> ---
> drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
> b/drivers/staging/r
On Tue, May 09, 2017 at 05:07:51PM -0700, Remco Verhoef wrote:
> Fix code indent should use tabs where possible coding style
> error.
Your subject should be a bit better, why, "one"?
please fix and resend.
thanks,
greg k-h
___
devel mailing list
de...
On Mon, May 08, 2017 at 02:13:00PM +0530, Surender Polsani wrote:
> according to coding style else is not generally
> useful after a break or return
>
> Signed-off-by: Surender Polsani
> ---
> drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
On Mon, 2017-05-08 at 14:13 +0530, Surender Polsani wrote:
> according to coding style else is not generally
> useful after a break or return
>
> Signed-off-by: Surender Polsani
> ---
> drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> dif
Nope.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, May 03, 2017 at 11:29:00AM +0530, Surender Polsani wrote:
> kernel coding style doesn't allow the return statement
> in void function.
>
> Signed-off-by: Surender Polsani
> ---
> Changes for v2:
> corrected subject line as suggested
> Changes for v3:
> modified from line as suggested by G
On Fri, Apr 21, 2017 at 09:24:57AM +0530, surenderpolsani wrote:
> kernel coding style doesn't allow the return statement
> in void function.
>
> Signed-off-by: Surenderp
Your "From" line does not match this line.
And I need a "full" name here.
thanks,
greg k-h
___
1 - 100 of 231 matches
Mail list logo
