Re: [PATCH] staging: rtl*: Remove tasklet callback casts

2019-11-15 Thread Kees Cook
On Fri, Nov 15, 2019 at 02:16:10PM +0800, Greg Kroah-Hartman wrote: > On Thu, Nov 14, 2019 at 09:39:00PM -0800, Kees Cook wrote: > > In order to make the entire kernel usable under Clang's Control Flow > > Integrity protections, function prototype casts need to be avoided > > because this will trip

Re: [PATCH] staging: rtl*: Remove tasklet callback casts

2019-11-15 Thread Kees Cook
On Fri, Nov 15, 2019 at 10:42:35AM +0300, Dan Carpenter wrote: > On Fri, Nov 15, 2019 at 10:40:03AM +0300, Dan Carpenter wrote: > > On Thu, Nov 14, 2019 at 09:39:00PM -0800, Kees Cook wrote: > > > In order to make the entire kernel usable under Clang's Control Flow > > > Integrity protections, func

Re: [PATCH] staging: rtl*: Remove tasklet callback casts

2019-11-14 Thread Dan Carpenter
On Fri, Nov 15, 2019 at 10:40:03AM +0300, Dan Carpenter wrote: > On Thu, Nov 14, 2019 at 09:39:00PM -0800, Kees Cook wrote: > > In order to make the entire kernel usable under Clang's Control Flow > > Integrity protections, function prototype casts need to be avoided > > because this will trip CFI

Re: [PATCH] staging: rtl*: Remove tasklet callback casts

2019-11-14 Thread Dan Carpenter
On Thu, Nov 14, 2019 at 09:39:00PM -0800, Kees Cook wrote: > In order to make the entire kernel usable under Clang's Control Flow > Integrity protections, function prototype casts need to be avoided > because this will trip CFI checks at runtime (i.e. a mismatch between > the caller's expected func

Re: [PATCH] staging: rtl*: Remove tasklet callback casts

2019-11-14 Thread Greg Kroah-Hartman
On Thu, Nov 14, 2019 at 09:39:00PM -0800, Kees Cook wrote: > In order to make the entire kernel usable under Clang's Control Flow > Integrity protections, function prototype casts need to be avoided > because this will trip CFI checks at runtime (i.e. a mismatch between > the caller's expected func